Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH inline Tip button is broken on few GH pages #11766

Closed
GeetaSarvadnya opened this issue Sep 18, 2020 · 2 comments · Fixed by brave/brave-core#6789
Closed

GH inline Tip button is broken on few GH pages #11766

GeetaSarvadnya opened this issue Sep 18, 2020 · 2 comments · Fixed by brave/brave-core#6789

Comments

@GeetaSarvadnya
Copy link

Description

Regression of #5040
GH inline Tip button is broken on few GH pages

Steps to Reproduce

Pages that are broken are listed below:

  1. Tip button on stars tab of user profile - https://github.com/feross?tab=stars
  2. Tip button on commits > branch name - https://github.com/brave/brave-core/commits/
  3. Tip button on people page of org - https://github.com/orgs/brave/people
  4. Tip button on team members page - https://github.com/orgs/brave/teams/android/members

Actual result:

GH inline Tip button is broken on few GH pages
image
image

Expected result:

All GH pages should show Tip inline button

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.16.23 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
Revision 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS Windows 10 OS Version 1903 (Build 18362.1016)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes but not in 0.69.x
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@LaurenWags
Copy link
Member

tip button was specifically removed from the org's people page: brave/brave-core#5215

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 29, 2020

Verification passed on

Brave | 1.17.53 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

GH inline button on various GH pages

Tip button on stars tab of user profile - https://github.com/feross?tab=stars
image

Tip button on commits > branch name - https://github.com/brave/brave-core/commits/
image

Tip button on people page of org - https://github.com/orgs/brave/people
image

Tip button on team members page - https://github.com/orgs/brave/teams/android/members
image

Tip button the PR page
image

Tip button on gists page
image

  • Verified tip banner showed profile name on GitHub if existed and username on GitHub if it did not
    image
    image
One time tips sent to GH users
  • Tip from both BR panel and Inline tip button from various GH pages
    image
    image

Verified passed with

Brave | 1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
-- | --
Revision | 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified in-line tip placement on the following pages:

Pull Request

PR description:
PR description

PR comment:
PR comment

Issue

Issue description:
Screen Shot 2020-11-06 at 8 50 58 AM

Issue comment:
Screen Shot 2020-11-06 at 8 51 56 AM

Commits Screen Shot 2020-11-06 at 8 52 46 AM
Starred Repos (must be logged in to GH) Screen Shot 2020-11-06 at 8 53 46 AM
Gist Screen Shot 2020-11-06 at 8 54 54 AM
People Page Screen Shot 2020-11-06 at 8 57 26 AM
Team Page (must be logged in to GH) Screen Shot 2020-11-06 at 8 56 48 AM

Additional testing was completed with #11463 (comment)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment