Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase intent is not extracted from google.com #11704

Closed
btlechowski opened this issue Sep 14, 2020 · 3 comments
Closed

Purchase intent is not extracted from google.com #11704

btlechowski opened this issue Sep 14, 2020 · 3 comments

Comments

@btlechowski
Copy link

It works when searching google through URL bar.
It does not work when searching for keywords through google.com

This is a regression introduced in 1.14.x. Does not reproduce in 1.13.86.

Note: Issue found by @LaurenWags

Steps to Reproduce

  1. Clean profile
  2. Enable rewards
  3. Wait till ads catalog and all components are downloaded
  4. Close Brave
  5. Open google.com and search for amd
  6. Check purchaseIntentSignalHistory in ads_service/client.json

Actual result:

Purchase intent is not extracted from google.com

Expected result:

Purchase intent is extracted from google.com

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.14.79 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS
Brave 1.16.14 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
Revision 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @jsecretan @rebron @moritzhaller @tmancey

@tmancey tmancey added the bug label Sep 24, 2020
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 22, 2020
@yachtcaptain23 yachtcaptain23 self-assigned this Oct 27, 2020
@tmancey tmancey changed the title [Desktop] Purchase intent is not extracted from google.com Purchase intent is not extracted from google.com Oct 28, 2020
@yachtcaptain23 yachtcaptain23 removed their assignment Nov 12, 2020
@tmancey tmancey removed the regression label Dec 6, 2020
@tmancey
Copy link
Contributor

tmancey commented Dec 6, 2020

Fixed as part of #6000

@btlechowski
Copy link
Author

@tmancey #6000 is still open. Can I reopen this one and remove it from 1.20.x milestone?

@tmancey tmancey reopened this Jan 22, 2021
@tmancey tmancey removed this from the 1.20.x - Beta milestone Jan 22, 2021
@tmancey tmancey self-assigned this Jan 27, 2021
@btlechowski
Copy link
Author

Seems to be working.

Verification passed on

Brave 1.28.98 Chromium: 92.0.4515.115 (Official Build) beta (64-bit)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS Ubuntu 18.04 LTS

image

@btlechowski btlechowski added this to the 1.28.x - Beta milestone Aug 2, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants