Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User wallets: brave browser creating multiple wallets #5427

Closed
mandar-brave opened this issue Jul 29, 2019 · 2 comments · Fixed by brave/brave-core#3072
Closed

User wallets: brave browser creating multiple wallets #5427

mandar-brave opened this issue Jul 29, 2019 · 2 comments · Fixed by brave/brave-core#3072

Comments

@mandar-brave
Copy link

For every single browser instance, currently the Brave browser is creating a new BAT card causing too many cards to be created against the same account.

Change asked for;

  • Create card and set it to position-0 (starred)
  • Card name set to "Brave Browser"
  • Before creation, check 2 pages of account to see if BAT card called "Brave Browser"
  • If no card exists, create card (there will be an issue if user renames card)

cc @NejcZdovc @kjozwiak

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jul 29, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 29, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Dev milestone Jul 29, 2019
@mandar-brave
Copy link
Author

@NejcZdovc besides starring the card, set position to 1 when card is created.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 22, 2019

Verification passed on

Brave 0.69.113 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the test plan from Single card brave-core#3072
  • Verified Brave Browser card created when verifying wallet with new uphold account.
  • Verified that no new Brave Browser card is created when verifying wallet with existing uphold account
  • Verified Brave Browser card is picked from the list when connecting uphold with new/existing account

Verified passed with

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Verified the test plan from Single card brave-core#3072
  • Verified Brave Browser card created when verifying wallet with new uphold account.
  • Verified that no new Brave Browser card is created when verifying wallet with existing uphold account
  • Verified Brave Browser card is picked from the list when connecting uphold with new/existing account. Verified by transferring BAT to Brave Browser card and verifying it displays as the wallet balance in the browser. Also verified by checking the address matches the uphold card id in the external_wallets section of Preferences file (default profile folder > preferences).

Verification passed on

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS
  • Verified the test plan from Single card brave-core#3072
  • Verified Brave Browser card created when verifying wallet with new uphold account.
  • Verified that no new Brave Browser card is created when verifying wallet with existing uphold account
  • Verified Brave Browser card is picked from the list when connecting uphold with new/existing account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants