Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User wallets: Pending wallet with Uphold #5426

Closed
mandar-brave opened this issue Jul 29, 2019 · 1 comment · Fixed by brave/brave-core#3042
Closed

User wallets: Pending wallet with Uphold #5426

mandar-brave opened this issue Jul 29, 2019 · 1 comment · Fixed by brave/brave-core#3042

Comments

@mandar-brave
Copy link

In the current user wallet creation flow, Brave is not checking if user's registration information is fully update; Uphold throws a pending user state when registration data is incomplete.

In such a state, when we try to create the BAT card, it fails causing the entire flow to fail.

Brave client needs to handle this state and prevent user from accessing add-funds or withdraw-funds in such a state. If a user is in pending state, the wallet will display BR in default anon wallet state.

cc @NejcZdovc @kjozwiak

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 22, 2019

Verification passed on

Brave 0.69.113 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Verified test plan from Adds support for pending state brave-core#3042
  • Verified that clicking on Add Funds from brave://rewards or panel takes you to Uphold add funds page
  • Verified that clicking on Verify Wallet, Withdraw Funds, or (verify) from brave://rewards page or panel as they are available, takes you to KYC flow on Uphold.

Verification passed on

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants