Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User wallet: Notification reminders #5004

Closed
mandar-brave opened this issue Jun 21, 2019 · 4 comments · Fixed by brave/brave-core#2696
Closed

User wallet: Notification reminders #5004

mandar-brave opened this issue Jun 21, 2019 · 4 comments · Fixed by brave/brave-core#2696

Comments

@mandar-brave
Copy link

First time an Uphold wallet shows as connected but unverified show the following notification (one time);
image

First time an Uphold wallets shows as verified, show the following notification (one time)

image

First time an Uphold wallet is disconnected outside of the context of a transaction (one time);

image

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 21, 2019
@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 24, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 8, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 8, 2019
@NejcZdovc
Copy link
Contributor

@mandar-brave for the first one I don't see any point as soon as you are connected you are redirected to the second step

@LaurenWags
Copy link
Member

Were all of these notifications implemented @NejcZdovc @mandar-brave ? The only one I've seen is the 'Your wallet is unreachable' one (third one) which I logged an issue for re: text updates #5816.

The test plan in brave/brave-core#2696 makes no reference to these notifications.

Please confirm if the first two notifications should be available/tested.

@LaurenWags
Copy link
Member

LaurenWags commented Aug 29, 2019

Per discussion with @NejcZdovc first notification (for Connected, Unverified) was not implemented.

Additionally, per discussion, here's a way to get the second notification (for Connected, Verified):

  1. create an account
  2. connect to a browser
  3. KYC
  4. check if you see a notification

Note - you will not get the Connected, Verified notification if you connect a KYC'd wallet initially.

@LaurenWags
Copy link
Member

LaurenWags commented Sep 3, 2019

Verified passed with

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.70.94 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
    image

image

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
    image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants