Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields should offer a shortcut to allow all scripts once #4567

Closed
cezaraugusto opened this issue May 23, 2019 · 3 comments · Fixed by brave/brave-core#2485
Closed

Shields should offer a shortcut to allow all scripts once #4567

cezaraugusto opened this issue May 23, 2019 · 3 comments · Fixed by brave/brave-core#2485
Assignees
@cezaraugusto
Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
0.68.x - Release

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 23, 2019 •
edited
Loading

Task split of #2996

Test Plan

  1. Go to Shields
  2. Block all scritps
  3. Click "allow scripts once"
  4. All scripts should be allowed
  5. Block all scripts
  6. Option to "allow scripts once" should not be visible

Once user toggle noScript on, an option to allow all scripts once should appear in the main panel.

Screen Shot 2019-05-23 at 17 07 32
@cezaraugusto cezaraugusto added feature/shields The overall Shields feature in Brave. feature/shields/!scripts Blocking JavaScript with Shields labels May 23, 2019
@cezaraugusto cezaraugusto added this to the 0.67.x - Nightly milestone May 23, 2019
@cezaraugusto cezaraugusto self-assigned this May 23, 2019
@cezaraugusto cezaraugusto mentioned this issue May 23, 2019
Merged
6 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue May 27, 2019
@cezaraugusto
add new noScript interface
2cb0d16 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
@rebron rebron removed this from the 0.67.x - Dev milestone May 31, 2019
@rebron
Copy link
Collaborator

rebron commented May 31, 2019

Removed 67.x milestone label as this wasn't closed/completed. Let me know if I'm wrong. Completed issues should only be moved into the appropriate milestone (unless it's a release blocker).

bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 5, 2019
@cezaraugusto @bsclifton
add new noScript interface
86d5b33 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
@cezaraugusto cezaraugusto added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes QA/Test-Plan-Specified labels Jun 7, 2019
@cezaraugusto cezaraugusto added this to the 0.68.x - Nightly milestone Jun 7, 2019
@srirambv
Copy link
Contributor

This issue is superseded by #5342. Although implementation is done as per design there is still a functionality bug that needs to be fixed as part of #5342. @rebron removing this issue from QA/Yes #5342 should be fixed and uplifted to beta

@srirambv srirambv mentioned this issue Jul 30, 2019
Open
This was referenced Aug 2, 2019
Closed
Closed
Closed
@btlechowski
Copy link

Removed QA/Yes per above comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Update NoScript interface brave/brave-core
5 participants
@cezaraugusto @rebron @srirambv @LaurenWags @btlechowski