Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scripts once should allow all scripts, first and third party, once - while the website is open in the tab. #5342

Open
srirambv opened this issue Jul 23, 2019 · 1 comment
Labels
design A design change, especially one which needs input from the design team feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 23, 2019

Description

Allow scripts once should allow all scripts, first and third party, once - while the website is open in the tab.

Steps to Reproduce

  1. Visit any site
  2. Block script via shields
  3. Click on Allow script once, all scripts are not loaded

Actual result:

All scripts are not loaded on the page, user has to allow it multiple times

Expected result:

  1. User click Allow script once, Block script should toggle to off, all scripts(first & third) party scripts should be allowed
  2. User opens a new site on the same tab and navigates back to original site, all scripts should be blocked on the page
  3. User closes tab and revisits the site in a new tab, all scripts should be blocked on the page
  4. User closes browser and relaunches and visit the site, all scripts should be blocked on the page
  5. User clears browser data without site settings and visits the page, all scripts should be blocked on the page
  6. User clears browser data with site settings and then visits the page, scripts should not be blocked

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Original Issue

## Description 
<!--Provide a brief description of the issue-->
Allow script once doesn't clearly states its allowing first party script the first time

## Steps to Reproduce
<!--Please add a series of steps to reproduce the issue-->

   1. Visit any site that has a lot of first party and third party scripts
   2. Block scripts via shields 
   3. Click on `Allow script once`, page reloads and loads first party scripts
   4. Click on `Allow script once`, page reloads and loads third party scripts
   5. Click on `Allow script once` again, page reloads and load remaining third party scripts

## Actual result:
<!--Please add screenshots if needed-->
Allow script once doesn't clearly states its allowing first party script the first time

## Expected result:
First show `Allow first party scripts once` once page reloads, change text to `Allow third party script once` or something else which clearly differentiates which type of scripts is allowed once

## Reproduces how often: 
<!--[Easily reproduced/Intermittent issue/No steps to reproduce]-->
Easy

## Brave version (brave://version info)
<!--For installed build, please copy Brave, Revision and OS from brave://version and paste here. If building from source please mention it along with brave://version details-->


Brave | 0.69.77 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)
-- | --
Revision | 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS | Linux


## Version/Channel Information:
<!--Does this issue happen on any other channels? Or is it specific to a certain channel?-->

- Can you reproduce this issue with the current release? No
- Can you reproduce this issue with the beta channel? No
- Can you reproduce this issue with the dev channel? No 
- Can you reproduce this issue with the nightly channel? Yes

## Other Additional Information:

- Does the issue resolve itself when disabling Brave Shields? N/A
- Does the issue resolve itself when disabling Brave Rewards? N/A
- Is the issue reproducible on the latest version of Chrome? N/A

## Miscellaneous Information:
<!--Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue-->
cc: @karenkliu @cezaraugusto 
@srirambv srirambv added feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team QA/Yes release-notes/include feature/shields/!scripts Blocking JavaScript with Shields labels Jul 23, 2019
@srirambv srirambv changed the title Allow script once doesn't clearly states its allowing first party script the first time Allow scripts once should allow all scripts, first and third party, once - while the website is open in the tab. Jul 30, 2019
@srirambv
Copy link
Contributor Author

cc: @cezaraugusto @karenkliu @rebron this should be part of 68.x as this issue supersedes #4567 in terms of functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

1 participant