Disable Greaselion service if Rewards isn't enabled

[atuchin-m]

Description

We don't use Greaselion for anything else now.
I should save some CPU cycles especially during the startup.

[LaurenWags]

@atuchin-m looks like the issue with the test plan (#39610 (comment)) is still open. Does that need to be closed and uplifted to 1.72.x for this issue (#40872) to be verified?

cc @kjozwiak

[atuchin-m]

@LaurenWags it's a meta issue to track all the related issue. I've closed it because all the depended issues are resolved.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.72.85 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
-- | --
Revision | 2c872aa4d2694bc73ec58e3b14538a4008a6381e
OS | Windows 10 Version 22H2 (Build 19045.5011)

• Verified the test plan from [Perf] Make Brave Extension disabled by default to optimize memory usage #39610 (comment)

Case 1: Rewards and WDP are disabled_PASSED

1. Restart browser
2. Open a new tab and navigate to a page that uses Greaselion (e.g. https://x.com/bravelaurenwags on staging)
3. Verify that the creator checkmark does not appear on the Rewards icon
4. Verify there is no Brave Extension process in menu => More tools => Task manager
5. Verify there is no extension with name greaselion- on brave://extensions-internals/

step 1	step 2,3	step 4	step 5

Case 2: Rewards ON_PASSED

1. Open the browser with a clean profile
2. Enable rewards
3. Open a new tab and navigate to a page that uses Greaselion (e.g. https://x.com/brave on production)
4. Verify that the creator checkmark appears on the Rewards icon
5. Verify there is Brave Extension process in menu => More tools => Task manager

step 3,4	step 5

6. Visit Visit brave://inspect/#extensions
7. Confirm there is a "Brave" extension on this page
8. Click on the "inspect" link and then the "Console" tab
9. Type WDP.isRunning on the console
10. Confirm this does not return "true"
    ---> @atuchin-m confirmed the error is ok as long as WDP is disabled, as it is in this case (confirmed via https://bravesoftware.slack.com/archives/C026Z6C96QK/p1731014486218639?thread_ts=1731013714.353799&cid=C026Z6C96QK). Also note, the error that is returned matches Release channel (1.71.x) when WDP is disabled.

Case 3: WDP ON_PASSED

Note, per discussion with Rémi, used general checks from brave/brave-core#9381 (comment) to confirm WDP functionality per the test plan and incorporated them into my steps below.

1. Open the browser with a clean profile. Close and relaunch to pull griffin.
2. Visit brave://inspect/#extensions
3. Confirm there is no "Brave" extension on this page
   
4. Navigate to brave://settings/search
5. Enable WDP
   
6. Verify there is Brave Extension process in menu => More tools => Task manager
   
7. Navigate back to brave://inspect/#extensions
8. Confirm there is now a "Brave" extension on this page
   
9. Click on the "inspect" link and then the "Console" tab
10. Type WDP.isRunning on the console
11. Confirm this returns "true"
    
12. Back to the console window, select the cog on the right (bottom one) then select "Log XMLHttpRequests"
    
13. Enter the following command in the prompt on the "Console" page:

WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate()

14. Confirm you see requests like below:
    
15. Open a new tab in the browser and visit https://www.google.com/search?q=soup
16. Once the page has finished loading completely, close it
17. Go back to the console and enter the following:

WDP.modules['web-discovery-project'].background.webDiscoveryProject.strictQueries.map(x=>x.tDiff=0)

18. Wait up a bit and you should see network requests being emitted like in the screenshot below

Note, the time the requests can take varies. I've seen it quick (less than ~20s) and longer (~1-1.5 min) for the requests to come through.

[LaurenWags]

Removed QA Pass-Win64 label for now as basic WDP functionality needs to be checked in case 3.

Have asked @remusao on Slack for assistance. Adding QA/Blocked until we have this additional information.

cc @atuchin-m @rebron @kjozwiak

[LaurenWags]

Verified with

Brave | 1.73.86 Chromium: 131.0.6778.39 (Official Build) (x86_64)
-- | --
Revision | 52163bcf4e40f27ddb76ffa79c90a8833084a9bd
OS | macOS Version 14.7.1 (Build 23H222)

Verified test plan from #39610 (comment):

Case 1: Rewards and WDP are disabled - PASSED

1. Restart browser
2. Open a new tab and navigate to a page that uses Greaselion (e.g. https://x.com/brave on production)
3. Verify that the creator checkmark does not appear on the Rewards icon

4. Verify there is no Brave Extension process in menu => More tools => Task manager

5. Verify there is no extension with name greaselion- on brave://extensions-internals/

Case 2: Rewards ON - PASSED

1. Open the browser with a clean profile
2. Enable rewards
3. Open a new tab and navigate to a page that uses Greaselion (e.g. https://x.com/brave on production)
4. Verify that the creator checkmark appears on the Rewards icon

5. Verify there is Brave Extension process in menu => More tools => Task manager

6. Visit Visit brave://inspect/#extensions
7. Confirm there is a "Brave" extension on this page
8. Click on the "inspect" link and then the "Console" tab
9. Type WDP.isRunning on the console
10. Confirm this does not return "true"
    ---> @atuchin-m confirmed the error is ok as long as WDP is disabled, as it is in this case (confirmed via https://bravesoftware.slack.com/archives/C026Z6C96QK/p1731014486218639?thread_ts=1731013714.353799&cid=C026Z6C96QK). Also note, the error that is returned matches Release channel (1.71.x) when WDP is disabled.

Case 3: WDP ON - PASSED

Note, per discussion with Rémi, used general checks from brave/brave-core#9381 (comment) to confirm WDP functionality per the test plan and incorporated them into my steps below.

1. Open the browser with a clean profile. Close and relaunch to pull griffin.
2. Visit brave://inspect/#extensions
3. Confirm there is no "Brave" extension on this page

4. Navigate to brave://settings/search
5. Enable WDP

6. Verify there is Brave Extension process in menu => More tools => Task manager

7. Navigate back to brave://inspect/#extensions
8. Confirm there is now a "Brave" extension on this page

9. Click on the "inspect" link and then the "Console" tab
10. Type WDP.isRunning on the console
11. Confirm this returns "true"

12. Back to the console window, select the cog on the right (bottom one) then select "Log XMLHttpRequests"

13. Enter the following command in the prompt on the "Console" page:

WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate()

14. Confirm you see requests like below:

15. Open a new tab in the browser and visit https://www.google.com/search?q=soup
16. Once the page has finished loading completely, close it
17. Go back to the console and enter the following:

WDP.modules['web-discovery-project'].background.webDiscoveryProject.strictQueries.map(x=>x.tDiff=0)

18. Wait up a bit and you should see network requests being emitted like in the screenshot below

Note, the time the requests can take varies. I've seen it quick (less than ~20s) and longer (~1-1.5 min) for the requests to come through.

[LaurenWags]

Verified with

Brave | 1.73.86 Chromium: 131.0.6778.39 (Official Build) (64-bit)
-- | --
Revision | 52163bcf4e40f27ddb76ffa79c90a8833084a9bd
OS | Linux

Verified test plan from #39610 (comment):

Case 1: Rewards and WDP are disabled - PASSED

1. Restart browser
2. Open a new tab and navigate to a page that uses Greaselion (e.g. https://x.com/brave on production)
3. Verify that the creator checkmark does not appear on the Rewards icon

4. Verify there is no Brave Extension process in menu => More tools => Task manager

5. Verify there is no extension with name greaselion- on brave://extensions-internals/

Case 2: Rewards ON - PASSED

1. Open the browser with a clean profile
2. Enable rewards
3. Open a new tab and navigate to a page that uses Greaselion (e.g. https://x.com/brave on production)
4. Verify that the creator checkmark appears on the Rewards icon

5. Verify there is Brave Extension process in menu => More tools => Task manager

6. Visit Visit brave://inspect/#extensions
7. Confirm there is a "Brave" extension on this page
8. Click on the "inspect" link and then the "Console" tab
9. Type WDP.isRunning on the console
10. Confirm this does not return "true"
    ---> @atuchin-m confirmed the error is ok as long as WDP is disabled, as it is in this case (confirmed via https://bravesoftware.slack.com/archives/C026Z6C96QK/p1731014486218639?thread_ts=1731013714.353799&cid=C026Z6C96QK). Also note, the error that is returned matches Release channel (1.71.x) when WDP is disabled.

Case 3: WDP ON - PASSED

Note, per discussion with Rémi, used general checks from brave/brave-core#9381 (comment) to confirm WDP functionality per the test plan and incorporated them into my steps below.

1. Open the browser with a clean profile. Close and relaunch to pull griffin.
2. Visit brave://inspect/#extensions
3. Confirm there is no "Brave" extension on this page

4. Navigate to brave://settings/search
5. Enable WDP

6. Verify there is Brave Extension process in menu => More tools => Task manager

7. Navigate back to brave://inspect/#extensions
8. Confirm there is now a "Brave" extension on this page

9. Click on the "inspect" link and then the "Console" tab
10. Type WDP.isRunning on the console
11. Confirm this returns "true"

12. Back to the console window, select the cog on the right (bottom one) then select "Log XMLHttpRequests"

13. Enter the following command in the prompt on the "Console" page:

WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate()

14. Confirm you see requests like below:

15. Open a new tab in the browser and visit https://www.google.com/search?q=soup
16. Once the page has finished loading completely, close it
17. Go back to the console and enter the following:

WDP.modules['web-discovery-project'].background.webDiscoveryProject.strictQueries.map(x=>x.tDiff=0)

18. Wait up a bit and you should see network requests being emitted like in the screenshot below

Note, the time the requests can take varies. I've seen it quick (less than ~20s) and longer (~1-1.5 min) for the requests to come through.