Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greaselion scripts loaded on twitch.tv when Rewards is not enabled #40784

Closed
2 of 6 tasks
zenparsing opened this issue Aug 30, 2024 · 3 comments · Fixed by brave/brave-site-specific-scripts#129
Closed
2 of 6 tasks
Assignees

Comments

@zenparsing
Copy link

Description

Greaselion scripts are being loaded on twitch.tv and vimeo.com when Rewards is not enabled. It appears that Greaselion.json is missing some rewards_enabled preconditions.

Steps to reproduce

  1. Open the browser with a new profile
  2. Navigate to twitch.tv or vimeo.com
  3. Open devtools (console tab)

Actual result

Screenshot 2024-08-30 at 11 00 09 AM

Expected result

No "script loaded" messages should appear in the console.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.160 Chromium: 128.0.6613.114 (Official Build) (x86_64)

(Note that this is due to Greaselion configs, rather than Brave Core.)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@LaurenWags

This comment was marked as outdated.

@zenparsing
Copy link
Author

It turns out that GL scripts are loaded for all sites for both Rewards-enabled and Rewards-not-enabled users. This is primarily for historical reasons (the scripts used to insert tip icons).

This issue will be addressed by #40872 and #34237.

@LaurenWags
Copy link
Member

LaurenWags commented Sep 5, 2024

Removed from "Greaselion Next" milestone and updated labels per discussion under https://bravesoftware.slack.com/archives/CNH9Q6REV/p1725560721221089?thread_ts=1725550174.295519&cid=CNH9Q6REV

cc @Miyayes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants