Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Back/forward page transitions should not trigger NotifyTabDidChange #38279

Closed
aseren opened this issue May 13, 2024 · 1 comment · Fixed by brave/brave-core#23886
Closed

[ads] Back/forward page transitions should not trigger NotifyTabDidChange #38279

aseren opened this issue May 13, 2024 · 1 comment · Fixed by brave/brave-core#23886
Assignees
@aseren
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.68.x - Release

Comments

@aseren
Copy link

aseren commented May 13, 2024 •
edited
Loading

Steps to Reproduce

  1. Do a search query on search.brave.com
  2. Tap any link with URL other then brave.com
  3. Tap Back button
  4. Tap Forward button

Actual result:

Back/Forward transition triggers NotifyTabDidChange

Expected result:

Back/Forward transition doesn't trigger NotifyTabDidChange

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced
@aseren aseren added bug feature/ads OS/iOS Fixes related to iOS browser functionality labels May 13, 2024
This was referenced May 13, 2024
Closed
Closed
@aseren aseren self-assigned this May 13, 2024
@aseren aseren mentioned this issue May 29, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 5, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 5, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 5, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (110)
BraveCore: 1.68.110 (127.0.6533.26)

STEPS:

  1. Follow the STR/TP from [ads] Back/forward page transitions should not trigger NotifyTabDidChange #38279 (comment) and [ads] Fixes align iOS NotifyTab[TextContent/HtmlContent]DidChange with Desktop brave-core#23886 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Back/Forward transition on search.brave.com does not trigger the NotifyTabDidChange log.
1 2 3 4
1 2 3 4
2024-07-05_11-51-47.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.68.x - Release
3 participants
@brave-builds @aseren @hffvld