Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Sanity test iOS NotifyTabDidChange business logic #37935

Closed
5 tasks done
Tracked by #33870
tmancey opened this issue Apr 29, 2024 · 0 comments
Closed
5 tasks done
Tracked by #33870

[ads] Sanity test iOS NotifyTabDidChange business logic #37935

tmancey opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
closed/not-actionable feature/ads needs-investigation A bug not 100% confirmed/fixed OS/iOS Fixes related to iOS browser functionality

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 29, 2024

Sanity test:

  • Confirm that we do NOT call ads_service_->NotifyTabDidChange if restoring a tab [Works for me]
  • Confirm that we do NOT call ads_service_->NotifyTabDidChange if the tab is NOT a new navigation (user tapped forward/back button or refreshed the tab) [Filed [ads] Back/forward page transitions should not trigger NotifyTabDidChange #38279]
  • Confirm that we do NOT call ads_service_->NotifyTabDidChange if the redirect chain is empty [Works for me]
  • Confirm that we call ads_service_->NotifyTabDidChange if the tab web content is a single page application (same document) [Filed https://github.com/[ads] iOS same document page navigations should trigger NotifyTabDidChange #38272]
  • Confirm that we call ads_service_->NotifyTabDidChange if the tab web content is a multi page application (document changed) [Works for me]

Please fix any bugs via this issue because they would affect inline content ads and site visits. See desktop/Android business logic in brave/browser/brave_ads/tabs/ads_tab_helper.cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/not-actionable feature/ads needs-investigation A bug not 100% confirmed/fixed OS/iOS Fixes related to iOS browser functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants