Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.60.6 gets "Aw, Snap" in incognito mode with Developer Tools open and you resize the tool window #2799

Closed
aleishman01 opened this issue Jan 3, 2019 · 7 comments · Fixed by brave/brave-core#1272

Comments

@aleishman01
Copy link

aleishman01 commented Jan 3, 2019

When you are in an Incognito window, and open Developer Tools, resizing the Developer Tools panel crashes the page with an "Aw, Snap" message

Steps to Reproduce

  1. Open incognito window
  2. Browse to any web page
  3. Press CTRL+SHIFT+J to open the developer tools
  4. Resize the developer tools panel

Actual result:

The web page crashes to an "Aw, Snap" screen. The Developer Tools Panel display a message: "DevTools was disconnected from the page. Once page is reloaded, DevTools will automatically reconnect"

Expected result:

Web page resizes without a crash.

Reproduces how often:

Easily reproduced in Windows and Linux (Debian).

Brave version (brave://version info)

Version 0.60.6 Chromium: 72.0.3626.28 (Official Build) dev (64-bit) (Windows 10)
Version 0.60.6 Chromium: 72.0.3626.28 (Official Build) dev (64-bit) (Debian Testing)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    My issue is with the Dev Builds

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

Google Chrome does not have this problem

@srirambv srirambv added this to the 1.x Backlog milestone Jan 3, 2019
@Y0HO
Copy link

Y0HO commented Jan 5, 2019

I also have this issue if Im not in Private / incognito Mode.
And if i switch my workspace with ctrl + alt + Arrow Keys on Linux Mint with Cinnamon

@rebron rebron added crash priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 8, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.60.6 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

@kjozwiak kjozwiak removed the needs-investigation A bug not 100% confirmed/fixed label Jan 8, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jan 8, 2019

Pretty easy to reproduce using the original STR, example:

crashresize

Crashes:

Used the following build to reproduce the issue:

Brave 0.60.6 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@iefremov iefremov self-assigned this Jan 9, 2019
iefremov pushed a commit to brave/brave-core that referenced this issue Jan 9, 2019
FrameContentClient of a given frame can obviously be null, lets check it.

Fix brave/brave-browser#2799
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 9, 2019
@bsclifton
Copy link
Member

Updated milestone to 0.59.x; Uplift PRs available here:
brave/brave-core#1275
brave/brave-core#1276

cc: @srirambv @kjozwiak @rebron @bbondy

@dayfuaim
Copy link

I still have the same on OSX 10.10.5
Версия 0.59.21 Chromium: 72.0.3626.28 (Официальная сборка), beta (64 бит)

Any change of size/position of DevTools gets page crashed.

"Версия 0.60.13 Chromium: 72.0.3626.53 (Официальная сборка), dev (64 бит)" is free of this.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 17, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 10
  • Verified the STR from issue. Now there is no crash when we resize the developer tool panel on any site.
  • Verified the STR on Private (Incognito) tabs, Normal Tabs and Tor tabs.

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux
  • Verified webview doesn't crash when developer tools is resized on normal/private/Tor tabs

Verified passed with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X
  • Verified on Normal, Private, Tor tabs.

@dayfuaim
Copy link

dayfuaim commented Jan 17, 2019

0.59.25 Chromium: 72.0.3626.53 (Официальная сборка), beta (64 бит)
Yes, now the bug's gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment