Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2799: Fix tab crash while resizing the devtools window. #1276

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Issue 2799: Fix tab crash while resizing the devtools window. #1276

merged 1 commit into from
Jan 9, 2019

Conversation

bsclifton
Copy link
Member

Uplift #1272 to 0.59.x

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@iefremov @bsclifton
Merge pull request #1272 from brave/devtools_resize_crash
6597ae6 
Issue 2799: Fix tab crash while resizing the devtools window.
@bsclifton bsclifton mentioned this pull request Jan 9, 2019
Closed
@bsclifton bsclifton requested a review from rebron January 9, 2019 16:10
@bsclifton bsclifton changed the base branch from master to 0.59.x January 9, 2019 16:15
@bsclifton bsclifton merged commit d8d0367 into 0.59.x Jan 9, 2019
@bsclifton bsclifton deleted the 0.59.x-2799 branch January 9, 2019 16:16
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@srirambv srirambv Awaiting requested review from srirambv

@rebron rebron Awaiting requested review from rebron

Assignees

@iefremov iefremov

Labels
None yet
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@bsclifton @bbondy @iefremov