-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove icon fetching for unverified media publishers #2717
Comments
for regular sites, the icon is from chromium icon db, not scraping, so
those can be unchanged
…On Sun, Dec 23, 2018 at 12:59 mandar-brave ***@***.***> wrote:
Remove icon scraping for any sites or channel from BR code.
cc @NejcZdovc <https://github.com/NejcZdovc> @diracdeltas
<https://github.com/diracdeltas>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2717>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhjFmfx4K3f8JjWrZ-rEonRfH0ds5fgks5u78SdgaJpZM4Zf70S>
.
|
Verification passed on
Used test plan from brave/brave-core#1200 Verification passed on
Verified passed with
Also verified icons for Twitch publishers in a-c table only (no tips table or panel since tipping is not implemented for Twitch yet): |
Test Plan
Original Issue Filed
Remove icon scraping for media publishers if they are not verified.
cc @NejcZdovc @diracdeltas
The text was updated successfully, but these errors were encountered: