Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon fetching for unverified media publishers #2717

Closed
mandar-brave opened this issue Dec 23, 2018 · 2 comments · Fixed by brave/brave-core#1200
Closed

Remove icon fetching for unverified media publishers #2717

mandar-brave opened this issue Dec 23, 2018 · 2 comments · Fixed by brave/brave-core#1200

Comments

@mandar-brave
Copy link

mandar-brave commented Dec 23, 2018

Test Plan

Original Issue Filed

Remove icon scraping for media publishers if they are not verified.

cc @NejcZdovc @diracdeltas

@mandar-brave mandar-brave added release/blocking feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Dec 23, 2018
@mandar-brave mandar-brave added this to the 0.59.x - Beta milestone Dec 23, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 23, 2018
@diracdeltas
Copy link
Member

diracdeltas commented Dec 23, 2018 via email

@NejcZdovc NejcZdovc changed the title Remove icon scraping for unverified publishers Remove icon scraping for unverified media publishers Dec 23, 2018
@NejcZdovc NejcZdovc changed the title Remove icon scraping for unverified media publishers Remove icon fetching for unverified media publishers Jan 3, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@btlechowski
Copy link

btlechowski commented Jan 9, 2019

Verification passed on

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Used test plan from brave/brave-core#1200
All PASSED
Verified page: https://kjozwiak.github.io/
Unverified page: https://www.interia.pl/
Verified youtube: https://www.youtube.com/watch?v=GNszD3W_G_g
Unverified youtube: https://www.youtube.com/watch?v=ZNjdf0F695Y

Verification passed on

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screenshot from 2019-01-10 13-16-53

Verified passed with

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Verified test plan from Removes icon fetching for unverified publishers brave-core#1200
  • Verified icons for verified sites display in a-c table, tips table, and panel
  • Verified icons for unverified sites display in a-c table, tips table, and panel
  • Verified icons for verified YT channels display in a-c table, tips table, and panel
  • Verified icons for unverified YT channels do not display in a-c table, tips table, or panel (note - one time tips to unverified publishers do not display in tips table per discussion with @NejcZdovc . I used recurring tips to illustrate the icon does not display.)
    screen shot 2019-01-10 at 9 59 06 am
    screen shot 2019-01-10 at 9 59 16 am

Also verified icons for Twitch publishers in a-c table only (no tips table or panel since tipping is not implemented for Twitch yet):
screen shot 2019-01-10 at 10 32 52 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment