Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tipping to only verified publishers #1206

Closed
wants to merge 1 commit into from

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 4, 2019

Resolves brave/brave-browser#2785

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

plan 1

  • enable rewards
  • claim grant
  • go to verified site and youtube channel
  • make sure that you can tip that site

plan 2

  • enable rewards
  • claim grant
  • go to non-verified site and youtube channel
  • make sure that you can't tip that site

plan 3

  • start browser from the master
  • add some verified and non verified sites/channels to monthly tip
  • switch to this PR branch
  • make sure that only verified sites/channel are in the tables
  • wait for contribution to happen and make sure that it went out just to verified publishers

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc force-pushed the only-verified-tipping branch from 9f3e067 to b7be611 Compare January 4, 2019 09:30
@NejcZdovc
Copy link
Contributor Author

closing as this is not desired behaviour anymore

@NejcZdovc NejcZdovc closed this Jan 7, 2019
@NejcZdovc NejcZdovc deleted the only-verified-tipping branch January 7, 2019 04:54
@NejcZdovc NejcZdovc added this to the Closed milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow tipping only for verified publishers
1 participant