Unable to import saved passwords from Vivaldi

[stephendonner]

Description

Unable to import saved passwords from Vivaldi

Steps to Reproduce

1. install latest stable-channel Vivaldi
2. log in to a few sites, saving passwords for each (I did github.com, gmail.com, facebook.com, and fill.dev``
3. shut down Vivaldi
4. install Brave 1.44.34
5. launch Brave
6. click on Skip welcome tour
7. click on Import bookmarks now...
8. select Vivaldi Person 1
9. note that the list includes Saved passwords
10. click Import
11. click Done
12. load brave://settings/passwords
13. look for passwords

Actual result:

No imported passwords

Expected result:

Should import all 4 Vivaldi-saved passwords

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.44.34 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	macOS Version 13.0 (Build 22A5321d)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bsclifton @spylogsster @rebron @MadhaviSeelam

[stephendonner]

Cross-reference this for Opera; maybe the same reason (likely, given Chromium-based?)

#24130

[rebron]

@spylogsster We may need to add additional UX specific to importing passwords for macOS.
cc: @aguscruiz see examples below from Edge.

[spylogsster]

to add additional UX specific to importing passwords for macOS.

Moved to separate issue #24666 as discussed in Slack with @rebron

[kjozwiak]

The above will require 1.43.77 or higher for 1.43.x verification 👍

[stephendonner]

Verified PASSED using

Brave	1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (x86_64)
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	macOS Version 11.6.8 (Build 20G730)

Followed my original steps to reproduce, with the same profile.

Confirmed I was able to import all passwords from Vivaldi

example	example	example	example

[LaurenWags]

Updated to release-notes/exclude as this is a follow up to the original implementation of Vivaldi import which will be included in the release notes via #23704)).

[MadhaviSeelam]

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Working as expected and can not reproduce the issue using original STR #24578 (comment) in Win 11 x64 in 1.44.34

Confirmed this issue still works as expected as passwords are successfully imported from Vivaldi

[aguscruiz]

@spylogsster We may need to add additional UX specific to importing passwords for macOS. cc: @aguscruiz see examples below from Edge.

We should be able to use our current dialogs for this issue, right? I think there's no need to mock it up unless there's something I'm missing