Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from Vivaldi #23704

Closed
rebron opened this issue Jun 27, 2022 · 4 comments · Fixed by brave/brave-core#13990
Closed

Import from Vivaldi #23704

rebron opened this issue Jun 27, 2022 · 4 comments · Fixed by brave/brave-core#13990

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 27, 2022

Description

Follow-up to #13334
Currently not showing options to import Vivaldi.

Steps to Reproduce

  1. Install Vivaldi and have a valid profile with some usage.
  2. Visit brave://settings/importData
  3. Try to import profile

Actual result:

Profile not detected / shown in drop down

Expected result:

Profile should be detected / shown in profile
Should offer information that's available including bookmarks, history, and saved passwords

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added OS/Desktop feature/importer retention priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 27, 2022
@spylogsster spylogsster self-assigned this Jun 27, 2022
@spylogsster spylogsster changed the title Import from Vivaldi and Opera Import from Vivaldi Jun 28, 2022
@spylogsster
Copy link

Opera moved to #23738

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 9, 2022

Verification Passed using

Brave | 1.43.61 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.795)

Prerequisite: Download Vivaldi and create multiple profiles

Before Vivaldi import

image

Profile 1 - Downloaded Vivaldi and added history/bookmarks/extensions

history bookmarks extensions
image image image

Profile 2 - added bookmarks and imported history/bookmarks/passwords from Microsoft Edge

history bookmarks passwords
image image image

Profile 3 - imported bookmarks and passwords from Chrome

passwords bookmarks
image image

Case 1: Vivaldi Profile 1- Import from Import bookmarks now... link on the bookmarks bar - PASSED

  1. Install 1.43.61
  2. launch Brave
  3. click Skip welcome tour
  4. click Import bookmarks now... link in the bookmarks bar
  5. confirmed Vivaldi option displayed in the drop down list of Import bookmarks and settings modal
  6. Select Vivaldi Profile 1
  7. keep default selections
    • Browsing history
    • Favorites/Bookmarks
    • Saved passwords
    • Extensions
  8. click import
  9. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  10. click Done
  11. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://settings/bookmarks
  12. confirmed Extensions imported and shown in brave://extensions
  13. confirmed Browsing history is imported and shown brave://history
  14. confirmed all bookmarks/passwords/extensions/history are imported from Vivaldi as expected
  15. clicked on a bookmark (bbc.com) and the site is loaded
Step 4 Step 5 Step 6 & 7 Step 9 Step 11 Step12 Step 13 Step 14 Step 15
image image image image Step11 Step12 Step11 image image

Case 2: Vivaldi Profile 2 - Import from Hamburger menu - PASSED

  1. new profile
  2. launch Brave
  3. click Hamburger menu
  4. click Bookmarks>>Import bookmarks and settings
  5. confirmed Vivaldi Profile 2 option displayed in the Import bookmarks and settings modal
  6. select Vivaldi Profile 2 and import only Favorites/Bookmarks option
  7. click Import
  8. click Done
  9. confirmed bookmarks shown in the bookmarks bar and brave://settings/bookmarks
  10. confirmed bookmarks displayed in Hamburger menu>>Bookmarks
  11. confirmed Microsoft Edge bookmarks folder that originally imported into Vivaldi are imported into `Brave
Step 3&4 Step 5 Step 6& 7 Step 8 Step 10
image image image image image

Case 3: Multiple profiles - Import Vivaldi Profile 1 & Profile 3 profiles - PASSED

  1. new profile
  2. launch Brave
  3. click Skip welcome tour
  4. visit brave://settings/importData to open Import bookmarks and settings modal
  5. select Vivaldi Profile 1 and import Browsing History and Extensions from the Import bookmarks and settings modal
  6. click import
  7. click Done
  8. confirmed Browsing History and Extensions are successfully imported from Vivaldi Profile 1
  9. return to brave://settings/importData to open Import bookmarks and settings modal again
  10. select Vivaldi Profile 3 and import Favorite Bookmarks and Saved passwords and click import
  11. confirmed and Favorites/Bookmarks and Saved passwords are successfully imported from Vivaldi Profile 3
Step 5 Step 7 Step 8 Step 10 Step 11
image image image image image

Case 4: Multiple browsers - Import from Vivaldi and Microsoft Edge - PASSED

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Vivaldi Profile 1 from the Import bookmarks and settings modal
  5. keep default selections Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  6. click Import and click Done
  7. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions from Vivaldi Profile 1
  8. go to brave://settings/importData and click Import bookmarks and settings
  9. select Microsoft Edge Profile 2 from the Import bookmarks and settings modal
  10. select Browsing history, Favorites/Bookmarks
  11. click Import and click Done
  12. confirmed successful import of Browsing history, Favorites/Bookmarks from Microsoft Edge Profile 2
  13. Imported from Micr.... folder shown in the bookmarks bar and in the bookmarks sidebar
Step 7 Step 12
image image

Case 5: Bookmarks imported from Vivaldi should Sync between devices - PASSED

device 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Vivaldi from `Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  7. visit brave://sync
  8. click on Start using sync>> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the `Sync everything'
Step 5 Step6 Step10 Step 11
image image image image

*device 2 *

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle
  8. confirmed Favorites/Bookmarks, Saved Passwords, Extensions synced successfully
  9. confirmed Browsing history not synced. Only URLs of the sites that were visited in the session are synced
Step 5& 6 Step 7 Step 8&9
image image image

Case 6: Upgrade 1.42.88--->1.43.61 - PASSED

  1. install 1.42.88
  2. launch Brave
  3. click Import bookmarks now in the bookmarks bar
  4. select Chrome in the Import bookmarks and settings
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  7. close the browser
  8. install 1.43.61
  9. relaunch Brave
  10. confirmed Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions are retained
  11. go to Hamburger menu>>Bookmarks>>Import bookmarks and settings
  12. select Vivaldi Profile 1
  13. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and complete import
  14. confirmed successful import from Vivaldi Profile 3
Step 1 Step 5 Step 6 Step 11 Step 12&13 Step 14
image image image image image image

@stephendonner
Copy link

stephendonner commented Aug 10, 2022

Verification PASSED using

Brave 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Prerequisite: Download Vivaldi and create multiple profiles

Before Vivaldi import

Screen Shot 2022-08-10 at 3 40 05 PM

Profile 1 - Downloaded Vivaldi and added history/bookmarks/extensions

history bookmarks extensions
Screen Shot 2022-08-09 at 5 16 39 PM Screen Shot 2022-08-09 at 5 19 05 PM Screen Shot 2022-08-10 at 1 38 36 PM

Profile 2 - added bookmarks and imported history/bookmarks/passwords from Microsoft Edge

history bookmarks passwords
Screen Shot 2022-08-09 at 5 30 58 PM Screen Shot 2022-08-09 at 5 31 18 PM Screen Shot 2022-08-09 at 5 37 09 PM

Profile 3 - imported bookmarks and passwords from Chrome

bookmarks passwords
Screen Shot 2022-08-09 at 5 46 02 PM Screen Shot 2022-08-09 at 5 46 30 PM

Case 1: Vivaldi Profile 1 - Import from Import bookmarks now... link on the bookmarks bar - PASSED

  1. Install 1.43.63
  2. launch Brave
  3. click Skip welcome tour
  4. click Import bookmarks now... link in the bookmarks bar
  5. confirmed Vivaldi option displayed in the drop down list of Import bookmarks and settings modal
  6. Select Vivaldi Profile 1
  7. keep default selections
    • Browsing history
    • Favorites/Bookmarks
    • Saved passwords
    • Extensions
  8. click Import
  9. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  10. click Done
  11. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://settings/bookmarks
  12. confirmed Extensions imported and shown in brave://extensions
  13. confirmed Browsing history is imported and shown brave://history
  14. confirmed all bookmarks/passwords/extensions/history are imported from Vivaldi as expected
  15. clicked on a bookmark (joinhoney.com) and the site is loaded
Step 4 Step 5 Step 6 & 7 Step 9 Step 11 Step12 Step 13 Step 14 Step 15
Screen Shot 2022-08-09 at 5 55 00 PM Screen Shot 2022-08-09 at 5 56 02 PM Screen Shot 2022-08-09 at 6 00 57 PM Screen Shot 2022-08-09 at 6 01 04 PM Screen Shot 2022-08-09 at 6 05 55 PM Screen Shot 2022-08-09 at 6 07 12 PM Screen Shot 2022-08-09 at 6 07 54 PM Screen Shot 2022-08-09 at 6 10 42 PM Screen Shot 2022-08-09 at 6 11 59 PM

Case 2: Vivaldi Profile 2 - Import from Hamburger menu - PASSED

  1. new profile
  2. launch Brave
  3. click Hamburger menu
  4. click Bookmarks>>Import bookmarks and settings
  5. confirmed Vivaldi Profile 2 option displayed in the Import bookmarks and settings modal
  6. select Vivaldi Profile 2 and import only Favorites/Bookmarks option
  7. click Import
  8. click Done
  9. confirmed bookmarks shown in the bookmarks bar and brave://settings/bookmarks
  10. confirmed bookmarks displayed in Hamburger menu>>Bookmarks
  11. confirmed Microsoft Edge bookmarks folder that originally imported into Vivaldi are imported into Brave
Step 3&4 Step 5 Step 6& 7 Step 8 Step 10
Screen Shot 2022-08-09 at 6 28 16 PM Screen Shot 2022-08-10 at 12 33 30 PM Screen Shot 2022-08-10 at 12 33 33 PM Screen Shot 2022-08-09 at 6 20 26 PM Screen Shot 2022-08-09 at 6 25 40 PM

Case 3: Multiple profiles - Import Vivaldi Profile 1 & Profile 3 profiles - PASSED(*)

  1. new profile
  2. launch Brave
  3. click Skip welcome tour
  4. visit brave://settings/importData to open Import bookmarks and settings modal
  5. select Vivaldi Profile 1 and import Browsing History and Extensions from the Import bookmarks and settings modal
  6. click import
  7. click Done
  8. confirmed Browsing History and Extensions are successfully imported from Vivaldi Profile 1
  9. return to brave://settings/importData to open Import bookmarks and settings modal again
  10. select Vivaldi Profile 3 and import Favorite Bookmarks and Saved passwords and click import
  11. checked Favorites/Bookmarks and Saved passwords are successfully imported from Vivaldi Profile 3 - FAILED - didn't import passwords:
Screen Shot 2022-08-10 at 2 42 54 PM
Step 5 Step 7 Step 8 Step 10 Step 11
Screen Shot 2022-08-10 at 2 30 42 PM Screen Shot 2022-08-10 at 2 30 44 PM Screen Shot 2022-08-10 at 2 39 13 PM Screen Shot 2022-08-10 at 2 30 17 PM Screen Shot 2022-08-10 at 2 44 29 PM

Case 4: Multiple browsers - Import from Vivaldi and Microsoft Edge - PASSED

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Vivaldi Profile 1 from the Import bookmarks and settings modal
  5. keep default selections Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  6. click Import and click Done
  7. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions from Vivaldi Profile 1
  8. go to brave://settings/importData and click Import bookmarks and settings
  9. select Microsoft Edge Profile 2 from the Import bookmarks and settings modal
  10. select Browsing history, Favorites/Bookmarks
  11. click Import and click Done
  12. confirmed successful import of Browsing history, Favorites/Bookmarks from Microsoft Edge Profile 2
  13. Imported from Micr.... folder shown in the bookmarks bar and in the bookmarks sidebar
Step 7 Step 12
Screen Shot 2022-08-10 at 2 55 00 PM Screen Shot 2022-08-10 at 3 00 17 PM

Case 5: Bookmarks imported from Vivaldi should Sync between devices - PASSED

device 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Vivaldi from `Import bookmarks and settings modal
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  7. visit brave://sync
  8. click on Start using sync ----> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the `Sync everything' radio button
Step 5 Step6 Step10 Step 11
Screen Shot 2022-08-10 at 3 21 34 PM Screen Shot 2022-08-10 at 3 22 08 PM Screen Shot 2022-08-10 at 3 22 51 PM Screen Shot 2022-08-10 at 3 22 57 PM

device 2

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle
  8. confirmed Favorites/Bookmarks, Saved Passwords, Extensions synced successfully
  9. confirmed Browsing history not synced. Only URLs of the sites that were visited in the session are synced
Step 5& 6 Step 7 Step 8&9
image image (1) image (2)

Case 6: Upgrade 1.42.88 --->1.43.63 - PASSED

  1. install 1.42.88
  2. launch Brave
  3. click Import bookmarks now in the bookmarks bar
  4. select Chrome in the Import bookmarks and settings
  5. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions
  7. close the browser
  8. install 1.43.63
  9. relaunch Brave
  10. confirmed Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions are retained
  11. go to Hamburger menu>>Bookmarks>>Import bookmarks and settings
  12. select Vivaldi Person 1
  13. keep default selections of Browsing history, Favorites/Bookmarks, Saved Passwords, Extensions and complete import
  14. confirmed successful import from Vivaldi Person 1
Step 1 Step 5 Step 6 Step 11 Step 12&13 Step 14
Screen Shot 2022-08-10 at 1 08 38 PM Screen Shot 2022-08-10 at 1 07 38 PM Screen Shot 2022-08-10 at 1 13 30 PM Screen Shot 2022-08-10 at 12 51 59 PM Screen Shot 2022-08-10 at 12 53 15 PM Screen Shot 2022-08-10 at 1 20 55 PM

Logged:

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 10, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 19, 2022

Verification PASSED using

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Linux

Bug filed: # #24826

Case 1: Vivaldi Profile 1- Import from Import bookmarks now... link on the bookmarks bar - PASSED

  1. Install 1.43.74
  2. launch Brave
  3. click Skip welcome tour
  4. click Import bookmarks now... link in the bookmarks bar
  5. confirmed Vivaldi option displayed in the drop down list of Import bookmarks and settings modal
  6. Select Vivaldi Profile 1
  7. keep default selections
    • Browsing history
    • Favorites/Bookmarks
    • Saved passwords
    • Extensions
  8. click import
  9. confirmation modal Your bookmarks and settings are ready is displayed as it's existing functionality
  10. click Done
  11. confirmed Favorites/Bookmarks shown in the bookmarks bar and sidebar and in brave://bookmarks
  12. confirmed Extensions imported and shown in brave://extensions
  13. confirmed Browsing history is imported and shown brave://history
  14. confirmed all bookmarks/extensions/historyare imported fromVivaldi` as expected
  15. clicked on a bookmark (bbc.com) and the site is loaded
Step 5 Step 6 -8 Step 9 Step 11 Step12 Step 13 Step 15
Step 5 Step 6-8 Step9 Step 11Bookmarks step 12 extensions Step 13-history Step 15

Case 2: Vivaldi Profile 2 - Import from Hamburger menu - PASSED

  1. new profile
  2. launch Brave
  3. click Hamburger menu
  4. click Bookmarks>>Import bookmarks and settings
  5. confirmed Vivaldi Profile 2 option displayed in the Import bookmarks and settings modal
  6. select Vivaldi Profile 2 and import only Favorites/Bookmarks option
  7. click Import
  8. click Done
  9. confirmed bookmarks shown in the bookmarks bar and brave://bookmarks
  10. confirmed bookmarks displayed in Hamburger menu>>Bookmarks
Step 3-4 Step 5-8 Step 9 Step 10
Step4-hamburger Step 6Bookmarks Step 9 Step 10

Case 3: Multiple profiles - Import Vivaldi Profile 1 & Profile 2 profiles - PASSED

  1. new profile
  2. launch Brave
  3. click Skip welcome tour
  4. visit brave://settings/importData to open Import bookmarks and settings modal
  5. select Vivaldi Profile 1 and import Browsing History and Extensions from the Import bookmarks and settings modal
  6. click import
  7. click Done
  8. confirmed Browsing History and Extensions are successfully imported from Vivaldi Profile 1
  9. return to brave://settings/importData to open Import bookmarks and settings modal again
  10. select Vivaldi Profile 2 and import Favorite Bookmarks and Saved passwords and click import
  11. confirmed and Favorites/Bookmarks successfully imported from Vivaldi Profile 2
Step 4-5 Step 8Bookmarks Step 8History Step 9-10 Step 11
Step4 Step8 Step 8Extensions Step10 Step 11

Case 4: Multiple browsers - Import from Vivaldi and Chrome - PASSED

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Vivaldi Profile 1 from the Import bookmarks and settings modal
  5. keep default selections Browsing history, Favorites/Bookmarks, Extensions
  6. click Import and click Done
  7. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions from Vivaldi Profile 1
  8. go to brave://settings/importData and click Import bookmarks and settings
  9. select Chrome Person 1 from the Import bookmarks and settings modal
  10. select Browsing history, Favorites/Bookmarks
  11. click Import and click Done
  12. confirmed successful import of Browsing history, Favorites/Bookmarks from Chrome Person 1
  13. Imported from Micr.... folder shown in the bookmarks bar and in the bookmarks sidebar
Step 4-5 Step 7bookmarks Step 7History Step 7Extension Step 9-10 Step 12 Step 13
Step 4-5 Step 7-Bookmarks Step7History Step 7Extensions Step 9-10 Step 12 Step 13

Case 5: Bookmarks imported from Vivaldi should Sync between devices - PASSED

Profile 1

  1. new profile
  2. launch Brave
  3. click Import bookmarks now...in the bookmarks bar
  4. select Vivaldi Person 1 from Import bookmarks and settings modal
  5. select Browsing history, Favorites/Bookmarks,Extensions and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions
  7. visit brave://sync
  8. click on Start using sync>> Start a new Sync Chain
  9. click Computer
  10. copy the code words
  11. under Sync Settings, click on the `Sync everything'
Step 5 Step 6 Step 10 Step 11
Step 5 Step 6 Step 10 Step 11

*profile 2 *

  1. go to Profile 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from Profile1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle
  8. confirmed Favorites/Bookmarks, Extensions synced successfully
  9. confirmed Browsing history not synced. Only URLs of the sites that were visited in the session are synced
Step 4-6 Step 7 Step 8-9
Step 5-6 Step 7 Step 8-9

Case 6: Upgrade 1.42.97--->1.43.74 - PASSED

  1. install 1.42.97
  2. launch Brave
  3. click Import bookmarks now in the bookmarks bar
  4. select Chrome in the Import bookmarks and settings
  5. select Browsing history, Favorites/Bookmarks and complete import
  6. confirmed successful import of Browsing history, Favorites/Bookmarks
  7. close the browser
  8. install 1.43.74
  9. relaunch Brave
  10. confirmed Browsing history, Favorites/Bookmarks are retained
  11. go to Hamburger menu>>Bookmarks>>Import bookmarks and settings
  12. select Vivaldi Profile 1
  13. select Browsing history, Favorites/Bookmarks, Extensions and complete import
  14. confirmed successful import from Vivaldi Profile 1
Step 1 Step4-5 Step 6 Step 11 Step 12&13 Step 14
Step 1 Step 4-5 Step 6 Step 11 Step 12-13 Step 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants