default shield-on option lost

[MadhaviSeelam]

Description

Shields default option Enabled fix worked in 1.42.x and 1.43.x via brave/brave-core#14031 but this fix didn't work with 1.41.x. This is a follow up issue to #23214

Steps to Reproduce

• Installed 1.41.95
• Visit buzzfeed.com
• Toggle OFF Shields in the Shields panel
• close the browser
• open AppData\Local\BraveSoftware\Brave-Browser\User Data\Default\Preferences
• changed "buzzfeed.com,*" -> *,* via the braveShields section
• relaunched the browser

Actual result:

Shields was disabled
*,* entry was still shown

Expected result:

Shields should be enabled for buzzfeed.com
, entry should be removed in preference file

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Windows 11 Version 21H2 (Build 22000.739)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[kjozwiak]

Closing as brave/brave-core#14121 was uplifted directly into 1.41.x. The above will require 1.41.96 or higher for 1.41.x verification 👍

[GeetaSarvadnya]

Reproduced the issue in 1.41.95. Good catch @MadhaviSeelam!

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.41.96 Chroium: 103.0.5060.114 (Official Build) (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 10 Version 21H2 (Build 19044.1806)

Clean profile:

1. Installed 1.41.96
2. Followed the steps from STR

• Ensured that the shield for the site is enabled and *,* is removed from the preference file
  

Upgrade profile:

1. Installed 1.41.95
2. Visited several sites and modified shield configurations (some up, some down, some with various changes to individual settings like Aggressively Block Ads, Aggressively Block Fingerprinting, etc)
3. Closed 1.41.95
4. Modified Preferences file as per Do not allow wildcard content settings entries for "shields enabled" brave-core#14031 (comment) for just one of the entries
5. Relaunched 1.41.95 and experienced the issue
6. "Upgraded" and launched with 1.41.96
7. Confirmed new sites visited did not reproduce the issue and shields were up for them
8. Confirmed previously set shield settings (up, down, modifications to individual settings) were now showing as expected
9. Closed 1.41.96 and viewed the Preferences file
10. Confirmed the wildcard , was removed from the braveShield section of the Preferences file

[LaurenWags]

Verified with

Brave | 1.41.96 Chromium: 103.0.5060.114 (Official Build) (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Clean profile - PASSED

Verified STR from #23988 (comment)
Confirmed the *,* entry was removed from Preferences file on relaunch.
Confirmed visiting sites did not show shields down by default.

Upgrade profile - PASSED

Using 1.40.113, modified the Preferences file to reproduce the issue.
Upgraded to 1.41.96.
Confirmed the *,* entry was removed from Preferences file after update.
Confirmed visiting sites did not show shields down by default.
Confirmed sites with previously set shield settings (Aggressively block FP, etc) are respected and shown as expected.

---

Verification passed on

Brave	1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Ubuntu 18.04 LTS

Clean profile - PASSED

Verified STR from #23988 (comment)
Confirmed the *,* entry was removed from Preferences file on relaunch.
Confirmed visiting sites did not show shields down by default.

Upgrade profile - PASSED

Using 1.40.113, modified the Preferences file to reproduce the issue.
Upgraded to 1.41.96.
Confirmed the *,* entry was removed from Preferences file after update.
Confirmed visiting sites did not show shields down by default.
Confirmed sites with previously set shield settings (Aggressively block FP, etc) are respected and shown as expected.