Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default shield-on option lost since a recent update #23214

Closed
fche opened this issue Jun 2, 2022 · 27 comments · Fixed by brave/brave-core#14031 or brave/brave-core#14074
Closed

default shield-on option lost since a recent update #23214

fche opened this issue Jun 2, 2022 · 27 comments · Fixed by brave/brave-core#14031 or brave/brave-core#14074

Comments

@fche
Copy link

fche commented Jun 2, 2022

Description

In versions prior to an update ~2-3 weeks ago (unknown exactly where this broke), my former default-shields-up setting (orange lion) has been broken. Now, new websites default to shields-down (grey lion), and I can't find a setting to turn it back on. This makes my browsing less secure than it was and than it should be.

Brave version (brave://version info)

brave-browser-1.39.111-1.x86_64 (fedora 35)

Brave 1.38.119 Chromium: 101.0.4951.67 (Official Build) (64-bit) 
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS Linux

@fche fche added the OS/Desktop label Jun 2, 2022
@rebron rebron added needs-investigation A bug not 100% confirmed/fixed feature/shields The overall Shields feature in Brave. labels Jun 3, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 3, 2022

@fche Shields is on by default for all sites and there's no global setting to turn it off on new sites. We do have shields disabled on internal pages like the new tab page and settings. Sounds like you're saying every site you visit has Brave Shields off by default though?

@fche
Copy link
Author

fche commented Jun 3, 2022

Yup, that's right, it's off by default on any new site I visit.
I can flick it on, and it stays on for future visits.
I wonder if some brave configuration item got messed up after many years of use & upgrading?

@rebron
Copy link
Collaborator

rebron commented Jun 3, 2022

We were thinking it was just a UI issue where the icon was greyed out but Shields is still on so an issue with front end icon. But sounds like truly having Shields turned off for all new sites you visit.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 3, 2022
@fche
Copy link
Author

fche commented Jun 3, 2022

Yup, it is truly off (javascript crap works, even though global defaults are to block), etc.

@fche
Copy link
Author

fche commented Jun 3, 2022

A possibly related phenomenon: my brave://settings has become very short indeed:

foo

@rebron
Copy link
Collaborator

rebron commented Jun 3, 2022

@fche That one above is an issue with minimum window, we're working on addressing it. If you expand window size, should see the rest of settings.

@MadhaviSeelam
Copy link

I couldn't reproduce the above issue for fresh install and upgrade profile. Shields toggle ON and OFF behavior works as expected in Win 11x64 and Ubuntu.

Tested on Win 11x64 as below:

Installed 1.38.119 Chromium 101.0.4951.67 and then upgraded to 1.39.111 Chromium: 102.0.5005.61 and both the versions have V2 Shields

  • Install 1.38.119 Chromium 101.0.4951.67
  • Launch brave
  • open few websites (CNN.com, BBC.com, theguardian.com)
  • Verified all three websites opened with default Shields ON
  • Toggle OFF for one of the sites (theguardian.com)
  • Close and relaunch the browser
  • CNN and BBC sites Shields setting correctly shows 'ON"
  • Guardian site Shield displayed 'OFF'
  • Upgrade to 1.39.111 Chromium: 102.0.5005.61
  • All 3 tabs are preserved
  • Shields icon is 'ON' for CNN and BBC sites
  • Shields icon is 'OFF' for Guardian
  • Open two more new sites brave.com or nyimes.com and the toggle is 'ON`

Couldn't reproduce the issue with fresh install of 1.39.111.

Tested upgrading V1 Shields>>V2 Shields with same above steps

  • Upgrade from 1.37.116 Chromium: 100.0.4896.127 to 1.39.111 Chromium: 102.0.5005.61
  • Results were same as above

@fche
Copy link
Author

fche commented Jun 4, 2022

Thanks! I wouldn't be surprised if it were some sort of corruption in my local settings, but have no idea where to look. ISTR shield default-on vs. default-off being a user selected option a while ago, but can't find that now. Maybe some configuration migration broke it?

@ziggiesandvik
Copy link

ziggiesandvik commented Jun 11, 2022

I'm having the same issue - I tried clearing "Site and Shields Settings" but that did not help.

1.39.122 Chromium: 102.0.5005.115 (Official Build) (x86_64)
--
Revision | 174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS | macOS Version 12.3.1 (Build 21E258)

@alexandrpunk
Copy link

alexandrpunk commented Jun 13, 2022

I have the same issue
`

Brave 1.39.122 Chromium: 102.0.5005.115 (Build oficial) (64 bits)
Revisión 174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
Sistema operativo Linux

`

@Werve
Copy link

Werve commented Jun 17, 2022

I think this problem is linked with #23113

@gpowers01
Copy link

gpowers01 commented Jun 20, 2022

I'm having the same problem. Shields are down unless I manually enable them on each site I visit - then the setting persists. How does one fix this issue? This issue seems to have surfaced in the past few weeks. Currently on Release Notes V1.39.122 (June 10th, 2022), which is the latest update. Do I need to somehow reset my local settings?

UPDATE: I first disabled sync in the Brave browser, completely uninstalled Brave checking the option to clear the local browsing history (Windows 10 Pro fully updated) and then downloaded an reinstalled Brave. I then re-enabled the sync. Now shields seem to be up by default for everything.

@leotm
Copy link

leotm commented Jun 21, 2022

if you want to avoid re-installing, this did the trick for me

@fche
Copy link
Author

fche commented Jun 21, 2022

(Clearing shields/sites settings did not work for me.)

@leotm
Copy link

leotm commented Jun 21, 2022

gotcha, i wonder if a reinstall on 1.39.122 works for you too (then re-sync) as a temp workaround

@fche
Copy link
Author

fche commented Jun 22, 2022

Another odd observation: on my linux/fedora brave installation, since the default-shield breakage, it often happens that visiting a new site HANGS with the lion-greyed, just waits while loading. If during this time, I turn the shields on via the lion icon, the site load completes right away.

FWIW, on this browser, I also run a copy of ublock-origin.

@dacioAlvira
Copy link

Same issue with Windows 11

@r-erd
Copy link

r-erd commented Jun 25, 2022

I had the same issue on MacOS Monterey 12.4 and my Android phone using Brave (synced).
I managed to fix it by leaving the sync chain and deleting the site and shield settings.
I also often had the issue of websites loading very slowly / hanging with the grey lion, which doesnt seem to happen anymore.

I also run ublock-origin in the same browser.

Tested it with random websites from google search results.

@eduncan911
Copy link

eduncan911 commented Jun 29, 2022

Version 1.39.122 Chromium: 102.0.5005.115 (Official Build) (64-bit)

  • Exact same issue for days as OP. I thought it was an extension and removed all - nope.
  • All shields is off / ads show up! Manually enabling shields hides the ads on pages.
  • There was nothing to "clear" in Shields, as suggested above.
  • Ubuntu 21.10

@rebron rebron removed needs-investigation A bug not 100% confirmed/fixed OS/Linux labels Jul 4, 2022
@kjozwiak
Copy link
Member

The above will require 1.41.95 or higher for 1.41.x verification.

@eduncan911
Copy link

eduncan911 commented Jul 10, 2022

It would be nice to know what exactly "broke" with the last update of Brave. I have never, not once, entered anything into the Shields Down manually: including no "wildcards" that this commit seems to have addressed as a "fix." Did wildcards somehow get automatically added, and break? Ok, that makes sense - but how did that happen?

As a follow-up to my "Confirmation" post above where I had the same issue, I was able to resolve my issue with the instructions below - even though at first I had "nothing to clear."

It's the subtle but key dropdown menu on that Advanced tab, at the very top that SCROLLS AWAY when you SCROLL DOWN to look for and select "Sites and Shields Settings."

You must SCROLL BACK UP that checkbox list, and change the Time range DropDownList to All Time to get all the sites to show up. Then I had a list of 100+ sites that needed to be "cleared."

Most concerning though: Why do I have an exception list of over 100 sites? That seems, unusually high when I barely ever disable a shield. And when I do disable shields, it's briefly until I flip it back on as it didn't fix the site.

This was not in any of the directions or suggested fixes.

@bridiver
Copy link
Contributor

Most concerning though: Why do I have an exception list of over 100 sites? That seems, unusually high when I barely ever disable a shield. And when I do disable shields, it's briefly until I flip it back on as it didn't fix the site.

Toggling a shields value back to the original does not unset it, it just changes the value of the override. This is a long-standing issue I've wanted addressed and I believe @petemill is working on a change to differentiate between changing the override and unsetting it.

As far as the actual cause, we don't know how this is happening so we added some debugging to give us more information to help track it down. Fortunately because there should never be a wildcard value for shields this was easy to address without knowing the root cause.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 11, 2022

Verification PASSED on


Brave | 1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 10 Version 21H2 (Build 19044.1766)

Additional testing

Case 1: Install 1.37.x with bunch of sites with shields ON/OFF, extensions installed and rewards and sync enabled and then upgrade to 1.41.96_PASSED
  1. Clean profile 1.37.x
  2. Visited several sites and modified shield configurations (some up, some down, some with various changes to individual settings like Aggressively Block Ads, Aggressively Block Fingerprinting, etc)
  3. Enable brave rewards
  4. Establish sync between devices and import bookmarks
  5. Install a few extensions
  6. Upgrade the profile to 1.41.96
  7. Confirmed shield settings are retained for the opened sites in 1.41.96
Case 1.1: Install 1.37.x with few sites opened turn off and then turn on shield for all the sites and then upgrade to 1.41.96_PASSED
  1. Clean profile 1.37.x
  2. Visited several sites and modified shield settings to off and then on for all the sites
  3. Upgrade the profile to 1.41.96
  4. Confirmed shield settings are retained for the opened sites in 1.41.96
Case 1.2: Install 1.37.x with a few sites opened with a shield ON in Normal window and shield OFF for the same sites in Private window and then upgrade to 1.41.96_PASSED
  1. Clean profile 1.37.x
  2. Visited several sites in normal windows
  3. Visit the same sites in the Private window and turn off the shield for all the sites
  4. Upgrade the profile to 1.41.96
  5. Confirmed shield settings are retained for the opened sites in the normal window in 1.41.96
Case 2: Install 1.38.x with bunch of sites opened with shields ON/OFF extensions installed and rewards and sync enabled then upgrade to 1.41.96_PASSED
  1. Clean profile 1.38.x
  2. Visited several sites and modified shield configurations (some up, some down, some with various changes to individual settings like Aggressively Block Ads, Aggressively Block Fingerprinting, etc)
  3. Enable brave rewards
  4. Establish sync between devices and import bookmarks
  5. Install a few extensions
  6. Upgrade the profile to 1.41.96
  7. Confirmed shield settings are retained for the opened sites in 1.41.96
Case 2.1: Install 1.38.x with bunch of sites opened with shields ON/OFF in multiple normal windows and then upgrade to 1.41.96_
  1. Clean profile 1.38.x
  2. Visited several sites and modified shield configurations some up, some down, some with various changes to individual settings like Aggressively Block Ads, Aggressively Block Fingerprinting, in two normal windows
  3. Upgrade the profile to 1.41.96
  4. Confirmed shield settings are retained for the opened sites in 1.41.96
  5. Confirmed shield settings are retained in multiple windows
Case 3: Install 1.39.x with a bunch of sites opened with shields ON/OFF extensions installed and rewards and sync enabled then upgrade to 1.41.96_PASSED
  1. Clean profile 1.39.x
  2. Visited several sites and modified shield configurations (some up, some down, some with various changes to individual settings like Aggressively Block Ads, Aggressively Block Fingerprinting, etc)
  3. Enable brave rewards
  4. Establish sync between devices and import bookmarks
  5. Install a few extensions
  6. Upgrade the profile to 1.41.96
  7. Confirmed shield settings are retained for the opened sites in 1.41.96
Case 4: Install 1.40.x with bunch of sites opened with shields ON/OFF extensions installed and rewards and sync enabled then upgrade to 1.41.96_PASSED
  1. Clean profile 1.40.x
  2. Visited several sites and modified shield configurations (some up, some down, some with various changes to individual settings like Aggressively Block Ads, Aggressively Block Fingerprinting, etc)
  3. Enable brave rewards
  4. Establish sync between devices and import bookmarks
  5. Install a few extensions
  6. Upgrade the profile to 1.41.96
  7. Confirmed shield settings are retained for the opened sites in 1.41.96

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 11, 2022

Verification Complete using

Brave | 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 11 Version 21H2 (Build 22000.739)

Filed #23988 - Verified the fix

Case 1: New Install - Default shields-on option is retained

  1. Installed 1.41.96
  2. Visit buzzfeed.com
  3. Toggle OFF Shields in the Shields panel
  4. close the browser
  5. open AppData\Local\BraveSoftware\Brave-Browser\User Data\Default\Preferences
  6. changed "buzzfeed.com,*" -> , via the braveShields section in the preference file
  7. relaunched the browser
  8. Confirmed default Shields-on option is retained
  9. *,* was removed in braveShields section in the preference file
Step 3 Step 6 Step 8 Step 9
step 3 step 6 step 8 step 9

Case 2: Upgrade - Default shields-on option is retained

  1. Installed 1.38.119
  2. Toggle OFF Shields in the Shields panel
  3. Close the browser
  4. open AppData\Local\BraveSoftware\Brave-Browser\User Data\Default\Preferences
  5. changed "buzzfeed.com,*" -> , via the braveShields section in the preference file
  6. relaunched the browser
  7. Shields is still down
  8. Upgrade to 1.41.96
  9. Confirmed Shields-on default option is retained.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 12, 2022

Verified with

Brave | 1.41.96 Chromium: 103.0.5060.114 (Official Build) (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Verified test plan from brave/brave-core#14031 (comment)
Additional testing done with #23988 (comment)
Verified test scenarios from brave/brave-core#14031 (comment):

Clean profile - PASSED

Verified STR from brave/brave-core#14031 (comment)
Confirmed the *,* entry was removed from Preferences file on relaunch.
Confirmed visiting sites did not show shields down by default.

Upgrade profile (simple check) - PASSED

Using 1.40.113, modified the Preferences file to reproduce the issue.
Confirmed visiting sites showed shields down by default.
Upgraded to 1.41.96.
Confirmed the *,* entry was removed from Preferences file after update.
Confirmed visiting sites did not show shields down by default.
Confirmed sites with previously set shield settings (Aggressively block FP, etc) are respected and shown as expected.

Verified additional upgrade scenarios from brave/brave-core#14031 (comment):

Test Case 2 - Upgrade profile affected by issue - PASSED
  • installed 1.40.113
  • visited https://videocardz.com and several other websites
  • closed Brave and opened Preferences file
  • changed "videocardz.com,*" -> "*,*" via the braveShields section
  • re-launched the browser and reproduced the issue re: shields being disabled
  • opened ~10 websites and closed the browser (each website had shields disabled due to the issue)
  • upgraded to 1.41.96
  • ensured that Brave shields was enabled for all the opened tabs including https://videocardz.com
  • ensured "*,*" was removed from Preferences file
Test Case 3 - Clean Upgrading (no issue present when upgrading) - PASSED

Quick check to ensure that shields settings are being retained on profiles that are not experiencing the issue

  • installed 1.40.113
  • visited several websites and changed their Brave shields settings (Settings that were changed/modified):
    • Aggressively block trackers & ads, Block trackers & ads, Allow all trackers & ads
    • Upgrade connections to HTTPS, Block Scripts
    • Aggressively block fingerprinting, Block fingerprinting, Allow fingerprinting
    • Block all cookies, Block cross-site cookies, Allow all cookies
  • upgraded to 1.41.96
  • ensured that all the shields settings were retained without any issues
Test Case 4 - Upgrading affected profile (additional shield settings) - PASSED
  • installed 1.40.113
  • visited several websites and changed their Brave shields settings (Settings that were changed/modified):
    • Aggressively block trackers & ads, Block trackers & ads, Allow all trackers & ads
    • Upgrade connections to HTTPS, Block Scripts
    • Aggressively block fingerprinting, Block fingerprinting, Allow fingerprinting
    • Block all cookies, Block cross-site cookies, Allow all cookies
    • Put shields down entirely for buzzfeed.com and one other site
  • closed Brave and opened Preferences file
  • changed buzzfeed.com entry in the settings to "*,*" via the braveShields section
  • launched the browser and verified the that issue was reproducible
  • upgraded to 1.41.96
  • ensured that all the shields settings were retained without any issues (including the site which was not buzzfeed.com which had shields down entirely) and the issue wasn't occurring

Verification passed on

Brave 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#14031 (comment)
Additional testing done with #23988 (comment)
Verified test scenarios from brave/brave-core#14031 (comment):

Clean profile - PASSED

Verified STR from brave/brave-core#14031 (comment)
Confirmed the *,* entry was removed from Preferences file on relaunch.
Confirmed visiting sites did not show shields down by default.

Upgrade profile (simple check) - PASSED

Using 1.40.113, modified the Preferences file to reproduce the issue.
Confirmed visiting sites showed shields down by default.
Upgraded to 1.41.96.
Confirmed the *,* entry was removed from Preferences file after update.
Confirmed visiting sites did not show shields down by default.
Confirmed sites with previously set shield settings (Aggressively block FP, etc) are respected and shown as expected.

Verified additional upgrade scenarios from brave/brave-core#14031 (comment):

Test Case 2 - Upgrade profile affected by issue - PASSED
  • installed 1.40.113
  • visited https://videocardz.com and several other websites
  • closed Brave and opened Preferences file
  • changed "videocardz.com,*" -> "*,*" via the braveShields section
  • re-launched the browser and reproduced the issue re: shields being disabled
  • opened ~10 websites and closed the browser (each website had shields disabled due to the issue)
  • upgraded to 1.41.96
  • ensured that Brave shields was enabled for all the opened tabs including https://videocardz.com
  • ensured "*,*" was removed from Preferences file
Test Case 3 - Clean Upgrading (no issue present when upgrading) - PASSED

Quick check to ensure that shields settings are being retained on profiles that are not experiencing the issue

  • installed 1.40.113
  • visited several websites and changed their Brave shields settings (Settings that were changed/modified):
    • Aggressively block trackers & ads, Block trackers & ads, Allow all trackers & ads
    • Upgrade connections to HTTPS, Block Scripts
    • Aggressively block fingerprinting, Block fingerprinting, Allow fingerprinting
    • Block all cookies, Block cross-site cookies, Allow all cookies
  • upgraded to 1.41.96
  • ensured that all the shields settings were retained without any issues
Test Case 4 - Upgrading affected profile (additional shield settings) - PASSED
  • installed 1.40.113
  • visited several websites and changed their Brave shields settings (Settings that were changed/modified):
    • Aggressively block trackers & ads, Block trackers & ads, Allow all trackers & ads
    • Upgrade connections to HTTPS, Block Scripts
    • Aggressively block fingerprinting, Block fingerprinting, Allow fingerprinting
    • Block all cookies, Block cross-site cookies, Allow all cookies
    • Put shields down entirely for buzzfeed.com and one other site
  • closed Brave and opened Preferences file
  • changed buzzfeed.com entry in the settings to "*,*" via the braveShields section
  • launched the browser and verified the that issue was reproducible
  • upgraded to 1.41.96
  • ensured that all the shields settings were retained without any issues (including the site which was not buzzfeed.com which had shields down entirely) and the issue wasn't occurring

@leotm
Copy link

leotm commented Jul 18, 2022

the issue returned for me on Windows on Version 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)

my suggestion earlier no longer worked, i suspected a reinstall would, but thought must be an easier way

flicking it off and on again did the trick again

Capture

@Werve
Copy link

Werve commented Aug 18, 2022

I confirm me too on 1.42.97 Chromium: 104.0.5112.102 (Official Build) (a 64 bit) Windows 10 Version 21H2 (Build 19044.1889) the shields are still default off on never seen websites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment