-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default shield-on option lost since a recent update #23214
default shield-on option lost since a recent update #23214
Comments
@fche Shields is on by default for all sites and there's no global setting to turn it off on new sites. We do have shields disabled on internal pages like the new tab page and settings. Sounds like you're saying every site you visit has Brave Shields off by default though? |
Yup, that's right, it's off by default on any new site I visit. |
We were thinking it was just a UI issue where the icon was greyed out but Shields is still on so an issue with front end icon. But sounds like truly having Shields turned off for all new sites you visit. |
Yup, it is truly off (javascript crap works, even though global defaults are to block), etc. |
@fche That one above is an issue with minimum window, we're working on addressing it. If you expand window size, should see the rest of settings. |
I couldn't reproduce the above issue for fresh install and upgrade profile. Shields toggle Tested on Win 11x64 as below: Installed 1.38.119 Chromium 101.0.4951.67 and then upgraded to 1.39.111 Chromium: 102.0.5005.61 and both the versions have V2 Shields
Couldn't reproduce the issue with fresh install of 1.39.111. Tested upgrading V1 Shields>>V2 Shields with same above steps
|
Thanks! I wouldn't be surprised if it were some sort of corruption in my local settings, but have no idea where to look. ISTR shield default-on vs. default-off being a user selected option a while ago, but can't find that now. Maybe some configuration migration broke it? |
I'm having the same issue - I tried clearing "Site and Shields Settings" but that did not help.
|
I have the same issue
` |
I think this problem is linked with #23113 |
I'm having the same problem. Shields are down unless I manually enable them on each site I visit - then the setting persists. How does one fix this issue? This issue seems to have surfaced in the past few weeks. Currently on Release Notes V1.39.122 (June 10th, 2022), which is the latest update. Do I need to somehow reset my local settings? UPDATE: I first disabled sync in the Brave browser, completely uninstalled Brave checking the option to clear the local browsing history (Windows 10 Pro fully updated) and then downloaded an reinstalled Brave. I then re-enabled the sync. Now shields seem to be up by default for everything. |
if you want to avoid re-installing, this did the trick for me |
(Clearing shields/sites settings did not work for me.) |
gotcha, i wonder if a reinstall on 1.39.122 works for you too (then re-sync) as a temp workaround |
Another odd observation: on my linux/fedora brave installation, since the default-shield breakage, it often happens that visiting a new site HANGS with the lion-greyed, just waits while loading. If during this time, I turn the shields on via the lion icon, the site load completes right away. FWIW, on this browser, I also run a copy of ublock-origin. |
Same issue with Windows 11 |
I had the same issue on MacOS Monterey 12.4 and my Android phone using Brave (synced). I also run ublock-origin in the same browser. Tested it with random websites from google search results. |
Version 1.39.122 Chromium: 102.0.5005.115 (Official Build) (64-bit)
|
The above will require |
It would be nice to know what exactly "broke" with the last update of Brave. I have never, not once, entered anything into the Shields Down manually: including no "wildcards" that this commit seems to have addressed as a "fix." Did wildcards somehow get automatically added, and break? Ok, that makes sense - but how did that happen? As a follow-up to my "Confirmation" post above where I had the same issue, I was able to resolve my issue with the instructions below - even though at first I had "nothing to clear." It's the subtle but key dropdown menu on that Advanced tab, at the very top that SCROLLS AWAY when you SCROLL DOWN to look for and select "Sites and Shields Settings." You must SCROLL BACK UP that checkbox list, and change the Most concerning though: Why do I have an exception list of over 100 sites? That seems, unusually high when I barely ever disable a shield. And when I do disable shields, it's briefly until I flip it back on as it didn't fix the site. This was not in any of the directions or suggested fixes. |
Toggling a shields value back to the original does not unset it, it just changes the value of the override. This is a long-standing issue I've wanted addressed and I believe @petemill is working on a change to differentiate between changing the override and unsetting it. As far as the actual cause, we don't know how this is happening so we added some debugging to give us more information to help track it down. Fortunately because there should never be a wildcard value for shields this was easy to address without knowing the root cause. |
Verification PASSED on
Additional testingCase 1: Install 1.37.x with bunch of sites with shields ON/OFF, extensions installed and rewards and sync enabled and then upgrade to 1.41.96_PASSED
Case 1.1: Install 1.37.x with few sites opened turn off and then turn on shield for all the sites and then upgrade to 1.41.96_PASSED
Case 1.2: Install 1.37.x with a few sites opened with a shield ON in Normal window and shield OFF for the same sites in Private window and then upgrade to 1.41.96_PASSED
Case 2: Install 1.38.x with bunch of sites opened with shields ON/OFF extensions installed and rewards and sync enabled then upgrade to 1.41.96_PASSED
Case 2.1: Install 1.38.x with bunch of sites opened with shields ON/OFF in multiple normal windows and then upgrade to 1.41.96_
Case 3: Install 1.39.x with a bunch of sites opened with shields ON/OFF extensions installed and rewards and sync enabled then upgrade to 1.41.96_PASSED
Case 4: Install 1.40.x with bunch of sites opened with shields ON/OFF extensions installed and rewards and sync enabled then upgrade to 1.41.96_PASSED
|
Verification
Filed #23988 - Verified the fix Case 1: New Install - Default shields-on option is retained
Case 2: Upgrade - Default shields-on option is retained
|
Verified with
Verified test plan from brave/brave-core#14031 (comment) Clean profile - PASSEDVerified STR from brave/brave-core#14031 (comment) Upgrade profile (simple check) - PASSEDUsing 1.40.113, modified the Preferences file to reproduce the issue. Verified additional upgrade scenarios from brave/brave-core#14031 (comment): Test Case 2 - Upgrade profile affected by issue - PASSED
Test Case 3 - Clean Upgrading (no issue present when upgrading) - PASSEDQuick check to ensure that shields settings are being retained on profiles that are not experiencing the issue
Test Case 4 - Upgrading affected profile (additional shield settings) - PASSED
Verification passed on
Verified test plan from brave/brave-core#14031 (comment) Clean profile - PASSEDVerified STR from brave/brave-core#14031 (comment) Upgrade profile (simple check) - PASSEDUsing 1.40.113, modified the Preferences file to reproduce the issue. Verified additional upgrade scenarios from brave/brave-core#14031 (comment): Test Case 2 - Upgrade profile affected by issue - PASSED
Test Case 3 - Clean Upgrading (no issue present when upgrading) - PASSEDQuick check to ensure that shields settings are being retained on profiles that are not experiencing the issue
Test Case 4 - Upgrading affected profile (additional shield settings) - PASSED
|
the issue returned for me on Windows on my suggestion earlier no longer worked, i suspected a reinstall would, but thought must be an easier way flicking it off and on again did the trick again |
I confirm me too on |
Description
In versions prior to an update ~2-3 weeks ago (unknown exactly where this broke), my former default-shields-up setting (orange lion) has been broken. Now, new websites default to shields-down (grey lion), and I can't find a setting to turn it back on. This makes my browsing less secure than it was and than it should be.
Brave version (brave://version info)
brave-browser-1.39.111-1.x86_64 (fedora 35)
Brave 1.38.119 Chromium: 101.0.4951.67 (Official Build) (64-bit) 
Revision 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS Linux
The text was updated successfully, but these errors were encountered: