Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Intermittently Invalid Brave Rewards Wallet ("Rewards profile not yet created" even though has already been created) #21057

Closed
jonathansampson opened this issue Feb 11, 2022 · 19 comments
Assignees
Labels
bug feature/rewards help wanted intermittent-issue needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/include

Comments

@jonathansampson
Copy link
Contributor

Description

The Rewards Wallet on Android appears to intermittently enter into an invalid state for some users. Interruptions with Brave Ads (confirmations failing) are observed in addition to this, and are likely related.

Steps to reproduce

TBD

Actual result

The wallet fails to load, and/or is believed to be invalid.

When this happens brave://rewards-internals/ will state that the Wallet has not yet been created. Restarting the application may resolve this for some users (possible race condition?). Verbose Logs will also record a failure to redeem unblinded tokens due to an invalid wallet.

Issue reproduces how often

Intermittently. Frequency TBD.

Version/Channel Information:

Observed on multiple releases, but most recently on 1.35.100.

Device details

  • Device type (Phone, Tablet, Phablet): Pixel 5
  • Android version: 12

Brave version

1.35.100

Additional information

Potentially related to other issues, including #18717 and #13026.

@jonathansampson jonathansampson added bug feature/rewards OS/Android Fixes related to Android browser functionality labels Feb 11, 2022
@newuser-web
Copy link

Similar issue were reported related to Brave News and NTP sponsored image #17352 #19800

@srirambv
Copy link
Contributor

This seems to be same as #13489. Ads show up but may not be redeemed due to wallet showing as invalid. Disabling ads and reenabling fixes it but may remove the custodian linkage.

cc: @Miyayes please look at the linked issues and close them as needed

@jonathansampson
Copy link
Contributor Author

@srirambv In my case, disabling ads resulted in the inability to turn them back on. I had to restart the mobile browser to resolve the issue.

@srirambv
Copy link
Contributor

disabling ads resulted in the inability to turn them back on.

I think you can just close the rewards page and reopen another one and enable it. I don't think a browser restart is required. But yes I have seen this happen as well. I have been running into this issue for a very long time and still not able to figure out whats causing the issue.

@zenparsing zenparsing added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 16, 2022
@Miyayes Miyayes added the needs-investigation A bug not 100% confirmed/fixed label Mar 1, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Mar 22, 2022

@srirambv When the Rewards wallet info shows up again, do you know if it is the same Wallet Payment ID as before, or was a new one written? Just want to doublecheck.

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 8, 2022

@Brave-Matt just reproduced this on his Android device.

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 12, 2022

Seems like frequency of this is increasing. Will increase priority. Causes problems in Rewards too, such as not being able to verify Brave Rewards because wallet is invalid, as well as a bunch of other consequences.

@Miyayes Miyayes added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 12, 2022
@lazymonkey2
Copy link

lazymonkey2 commented May 18, 2022

any news on this?
It is happening on my phone (samsung a50 android 11), and the only way to fix it is to end the brave task and restart it.
Problem is that brave it doesn't warn me of this situation, so I have to keep checking brave:rewards-internals.
At least add a warning that the wallet is invalid!

@Miyayes
Copy link
Collaborator

Miyayes commented Jun 28, 2022

Seems like this hasn't been happening in more recent versions of Brave. May have resolved itself, but will keep issue open for awhile longer and keep monitoring for reports. Our Android engineers no longer reproducing it.

@lazymonkey2
Copy link

unfortunately it's not resolved. happened tom me yesterday.
I agree that currently it seems less frequent than before, but it's still not fixed.

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 15, 2022

unfortunately it's not resolved. happened tom me yesterday. I agree that currently it seems less frequent than before, but it's still not fixed.

@424344 Can you confirm which version of the Brave app you are on when you see this happen again? Thanks. Would also be lovely if you could capture some screenshots/evidence when it occurs so we can see.

@lazymonkey2
Copy link

I'm not sure about the version, but I'm always up to date with the release in the play store (right now it's v1.41.96)
Probably last time it happened I was running v1.40.x

@Uni-verse
Copy link
Contributor

Reproduced using version 1.43.86

09-03 01:28:34.002 26586 26586 I chromium: [INFO:redeem_unblinded_payment_tokens.cc(53)] Failed to redeem unblinded payment tokens due to invalid wallet
09-03 01:28:34.002 26586 26586 V chromium: [VERBOSE1:redeem_unblinded_payment_tokens.cc(148)] Failed to redeem unblinded payment tokens

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 1, 2022

Reproduced using version 1.43.86

09-03 01:28:34.002 26586 26586 I chromium: [INFO:redeem_unblinded_payment_tokens.cc(53)] Failed to redeem unblinded payment tokens due to invalid wallet
09-03 01:28:34.002 26586 26586 V chromium: [VERBOSE1:redeem_unblinded_payment_tokens.cc(148)] Failed to redeem unblinded payment tokens

Do you have some information about the Android device and its particular configuration/state? Thanks.

@TMTRTLP
Copy link

TMTRTLP commented Dec 7, 2022

Yeah, I believe I'm running into the same issue right now.

Pixel 6a - November Security Patch

Screenshot_20221206-201237~2
Screenshot_20221206-200817

@Miyayes Miyayes changed the title Intermittently Invalid Android Rewards Wallet Intermittently Invalid Brave Rewards Wallet ("Rewards profile not yet created" even though has already been created) Dec 7, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 4, 2023

Report from user who runs into this regularly:

I’ve previously reported this happens (months ago when the rewards were all paying out wrong) yes, and yes this also fixes itself when the browser relaunch works. The only difference with mine is I cannot see the balance just a whirring wheel, whereas I noted in the screenshot above they can at least see their balance so perhaps not the same issue after all.
Nothing unique, standard set up no modifications or VPN - Samsung A50
Android phone running Brave version 1.46.146, Chromium 108.0.53591.128.
Yes I can but timing is important, I cannot do this during work hours

https://community.brave.com/t/why-is-it-showing-unverified/461044/6?u=chriscat

@Miyayes Miyayes assigned emerick and unassigned srirambv Mar 6, 2023
@Miyayes Miyayes removed the OS/Desktop label Mar 6, 2023
@Miyayes Miyayes changed the title Intermittently Invalid Brave Rewards Wallet ("Rewards profile not yet created" even though has already been created) [Android] Intermittently Invalid Brave Rewards Wallet ("Rewards profile not yet created" even though has already been created) Mar 6, 2023
@emerick
Copy link
Contributor

emerick commented Mar 6, 2023

Sample failure log (from @deeppandya):

brave_rewards_log.txt

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 22, 2023

This issue may have been resolved as part of 1.48.x., so will keep an eye out for more support reports, and if there are any more reports here.

Update: Does not seem resolved as of 1.48.x. Still an issue.

@Miyayes
Copy link
Collaborator

Miyayes commented May 8, 2023

Still seeing a lot of reports of this as of May 2023. On Android, users need to force kill the app or restart their phone.

Some symptoms are custodian selection buttons not working (unresponsive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards help wanted intermittent-issue needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/include
Projects
Status: Done
Development

No branches or pull requests

10 participants