Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only default bg image is displayed in NTP when "New Tab Page Branded Wallpapers" flag is off #19754

Closed
simonhong opened this issue Nov 26, 2021 · 3 comments · Fixed by brave/brave-core#11307
Closed

Only default bg image is displayed in NTP when "New Tab Page Branded Wallpapers" flag is off #19754

simonhong opened this issue Nov 26, 2021 · 3 comments · Fixed by brave/brave-core#11307
Assignees
@simonhong
Labels
OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.35.x - Release

Comments

@simonhong
Copy link
Member

When New Tab Page Branded Wallpapers is off from the brave://flags,
NTP only shows default bg image because NTPBackgroundImagesService is not
launched.
@simonhong
Copy link
Member Author

@rebron @bsclifton I think we can remove this feature flag because user can control in NTP settings. WDYT?

@simonhong simonhong self-assigned this Nov 27, 2021
simonhong added a commit to brave/brave-core that referenced this issue Nov 27, 2021
@simonhong
Removed NTPBrandedWallpaper feature flag
e808cf1 
fix brave/brave-browser#19754

As we customize this feature in NTP, we don't need to maintain this
feature flag. Also this makes regression when this flag is off.
@simonhong simonhong mentioned this issue Nov 27, 2021
Merged
24 tasks
@bsclifton
Copy link
Member

bsclifton commented Nov 29, 2021 •
edited
Loading

@simonhong SGTM! 😄 Let's remove it

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Nov 30, 2021
simonhong added a commit to brave/brave-core that referenced this issue Dec 7, 2021
@simonhong
Removed NTPBrandedWallpaper feature flag
4735112 
fix brave/brave-browser#19754

As we can customize this feature in NTP, we don't need to maintain this
feature flag. Also this makes regression when this flag is off.
@simonhong simonhong added this to the 1.35.x - Nightly milestone Dec 7, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.35.72 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Used the testplan from brave/brave-core#11307.

  1. new profile
  2. launched Brave
  3. loaded brave://flags
  4. confirmed the feature flag brave://flags/#brave-ntp-branded-wallpaper no longer exists
  5. confirmed both new-tab page wallpapers as well as Sponsored Images were still working/toggleable
1.33.106 1.35.72 toggled off wallpaper Sponsored Image
19754-1 19754-2 19754-3 19754-4 19754-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Removed NTPBrandedWallpaper feature flag brave/brave-core
4 participants
@stephendonner @bsclifton @rebron @simonhong