Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up #19349] Fix alignment for translated text #19558

Closed
srirambv opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#12744
Closed

[Follow up #19349] Fix alignment for translated text #19558

srirambv opened this issue Nov 18, 2021 · 1 comment · Fixed by brave/brave-core#12744
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

[Follow up #19349] Unfixed translated string issue

Actual result:

image

Expected result:

Proper alignment for translated text

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.34.22 Chromium: 96.0.4664.45 (Official Build) nightly (64-Bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 11 Version 21H2 (Build 22000.318)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Follow up #19349 cc: @Douglashdaniel

@srirambv srirambv added l10n QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 18, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 18, 2021
@bbondy bbondy changed the title [Follow up #19349] Unfixed translated string issue [Follow up #19349] Fix alignment for translated text Nov 18, 2021
@muliswilliam muliswilliam self-assigned this Jan 10, 2022
@muliswilliam muliswilliam removed their assignment Jan 24, 2022
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 16, 2022
@josheleonard josheleonard self-assigned this Mar 24, 2022
@josheleonard josheleonard added this to the 1.39.x - Nightly milestone Mar 29, 2022
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.39.108 Chromium: 101.0.4951.67 (Offizieller Build) beta (64-Bit)
Überarbeitung 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
Betriebssystem Windows 11 Version 22H2 (Build 22621.1)
  • Verified translated text is properly aligned
  • Encountered #22941 & #22942
Transaction Approval
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants