Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button/Images are not properly aligned for translated string #22942

Closed
srirambv opened this issue May 19, 2022 · 3 comments
Closed

Button/Images are not properly aligned for translated string #22942

srirambv opened this issue May 19, 2022 · 3 comments
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet Integrating Ethereum+ wallet support l10n OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Button are not properly aligned for translated string

Steps to Reproduce

Transaction

  1. Set locale to German
  2. Initiate transaction
  3. Check the panel, text and button doesn't have padding

Limit Approval

  1. Set locale to German
  2. Initiate limit approval transaction
  3. Check the panel, warning icon is not aligned on the same line as the warning text

Actual result:

Transaction Approval
image image

Expected result:

Properly aligned text/icons

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.39.108 Chromium: 101.0.4951.67 (Offizieller Build) beta (64-Bit)
Überarbeitung 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
Betriebssystem Windows 11 Version 22H2 (Build 22621.1)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @josheleonard

@jamesmudgett
Copy link

@srirambv are you referring to the edit gas link? I think it's ok since it's a different color.

@srirambv
Copy link
Contributor Author

srirambv commented Jun 8, 2022

@jamesmudgett taking specifically about these
image
image

@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jun 17, 2022
@josheleonard josheleonard added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Apr 23, 2024
@josheleonard
Copy link

Doesn't look like this issue is valid anymore. Closing.

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet Integrating Ethereum+ wallet support l10n OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
Archived in project
Development

No branches or pull requests

3 participants