Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Wallet UI issues due to translated strings #19349

Closed
srirambv opened this issue Nov 10, 2021 · 2 comments · Fixed by brave/brave-core#11123
Closed

Brave Wallet UI issues due to translated strings #19349

srirambv opened this issue Nov 10, 2021 · 2 comments · Fixed by brave/brave-core#11123
Assignees
Labels
feature/user-interface All UI related feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 10, 2021

Description

UI issues due to translated strings

Steps to Reproduce

  1. Use a non-EN locale and use wallet

Note: Will update if I come across any other UI issue

Actual result:

Icon on panel gets cut off
image

Swap button needs padding (Not specific to translated strings)
image

Panel text overload
image

Button oversized for custom gas price

image image

Insufficient funds message
image

Panel lock screen padding missing
image

Expected result:

No UI issues

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.95 Chromium: 95.0.4638.69 (Offizieller Build) beta (64-Bit)
Überarbeitung 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
Betriebssystem Windows 11 Version 21H2 (Build 22000.282)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett @bbondy @Douglashdaniel

@srirambv srirambv added l10n feature/user-interface All UI related QA/Yes release-notes/exclude OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 10, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 10, 2021
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 10, 2021
@Miyayes Miyayes changed the title UI issues due to translated strings Brave Wallet UI issues due to translated strings Nov 10, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 10, 2021
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 17, 2021
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified UI is shown correctly for translated strings
Bildschirmfoto 2021-11-23 um 8 22 43 AM Bildschirmfoto 2021-11-23 um 8 23 20 AM Bildschirmfoto 2021-11-23 um 8 26 40 AM Bildschirmfoto 2021-11-23 um 8 26 51 AM Bildschirmfoto 2021-11-23 um 8 26 57 AM Bildschirmfoto 2021-11-23 um 8 27 07 AM Bildschirmfoto 2021-11-23 um 8 27 28 AM

Verification passed on

Brave 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 11 Version 21H2 (Build 22000.318)
  • Verified UI is shown correctly for translated strings
1 2 3 4 5 6 7

@bbondy
Copy link
Member

bbondy commented Nov 25, 2021

Changing to release-notes/include because users using translated builds would want to know about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/user-interface All UI related feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants