Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from std::function<> to base::OnceCallback<>. #18560

Open
szilardszaloki opened this issue Oct 5, 2021 · 0 comments
Open

Switching from std::function<> to base::OnceCallback<>. #18560

szilardszaloki opened this issue Oct 5, 2021 · 0 comments
Assignees
@szilardszaloki
Labels
dev-concern OS/Desktop

Comments

@szilardszaloki
Copy link
Contributor

szilardszaloki commented Oct 5, 2021 •
edited
Loading

We shouldn't introduce std::function<>s into new code, but currently, there are quite a couple of places where it would be a lot more effort to use base::OnceCallback<> than would make sense for a PR which should rather focus on the issue it resolves. We should convert to base::OnceCallback<>s in one go instead, or probably on a per-Ledger-flow basis.

Part1: #24051
Part2: #24108
Part3: #24200
Part4: #24294
Part5: #32400
Part6: #32625

Miscellaneous Information:

@emerick @Miyayes @zenparsing
@jumde jumde mentioned this issue Oct 15, 2021
Merged
24 tasks
@szilardszaloki szilardszaloki mentioned this issue Nov 10, 2021
Closed
24 tasks
@szilardszaloki szilardszaloki self-assigned this Jul 5, 2022
This was referenced Jul 13, 2022
Closed
Closed
This was referenced Jul 21, 2022
Closed
Closed
@szilardszaloki szilardszaloki changed the title Switching from std::bind<>() to base::Bind*<>(). Switching from std::function<> to base::OnceCallback<>. Jul 29, 2022
@szilardszaloki szilardszaloki mentioned this issue Apr 19, 2023
Merged
25 tasks
@szilardszaloki szilardszaloki mentioned this issue Aug 20, 2023
Closed
@szilardszaloki szilardszaloki mentioned this issue Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szilardszaloki szilardszaloki

Labels
dev-concern OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szilardszaloki