Disconnect existing external wallets when connecting a new wallet #10863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
force-pushed
the
ksmith-one-wallet-only
branch
from
8f04977 to
bd7dd8d
Compare
emerick
reviewed
Nov 10, 2021
| const std::string& wallet_type, | ||
| const base::flat_map<std::string, std::string>& args, | ||
| ExternalWalletAuthorizationCallback callback, | ||
| ledger::type::Result result) { | ||
| if (!Connected()) { |
There was a problem hiding this comment.
Do we need to check result here?
There was a problem hiding this comment.
Yes, good call. The question then becomes: what do we do when disconnecting fails?
There was a problem hiding this comment.
Yeah, I'm not sure there's much we can do other than log it for support purposes and move on (unless you're thinking showing the user some sort of UI would be useful, but I feel like that could happen down the line beyond this PR).
There was a problem hiding this comment.
I added a logged error.
zenparsing
force-pushed
the
ksmith-one-wallet-only
branch
from
bd7dd8d to
80a4bc5
Compare
zenparsing
commented
Nov 24, 2021
| @@ -805,6 +805,10 @@ void LedgerImpl::DisconnectWallet(const std::string& wallet_type, | |||
| }); | |||
| } | |||
|
|
|||
| void LedgerImpl::DisconnectExternalWallets(ResultCallback callback) { | |||
| WhenReady([this, callback]() { wallet()->DisconnectAllWallets(callback); }); | |||
There was a problem hiding this comment.
This currently doesn't work for the following reasons:
DisconnectAllWalletscalls the de-linking endpoints unconditionally, whether the user has an active wallet for a given provider or not.DisconnectAllWalletscalls its callback immediately, without waiting for the de-linking operations to complete.
zenparsing
force-pushed
the
ksmith-one-wallet-only
branch
from
80a4bc5 to
a60019b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#19119
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
See https://github.com/brave/internal/issues/823