Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove std::function<> from further Ledger flows #24200

Closed
szilardszaloki opened this issue Jul 21, 2022 · 4 comments · Fixed by brave/brave-core#14286
Closed

Remove std::function<> from further Ledger flows #24200

szilardszaloki opened this issue Jul 21, 2022 · 4 comments · Fixed by brave/brave-core#14286

Comments

@szilardszaloki
Copy link
Contributor

Part3 of #18560.

@szilardszaloki szilardszaloki added dev-concern QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jul 21, 2022
@szilardszaloki szilardszaloki self-assigned this Jul 21, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 26, 2022
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 18, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 18, 2022

Verification PASSED on

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 10 Version 21H2 (Build 19044.1889)
Create a wallet flow_PASSED
  • Confirmed that rewards wallet can be created via rewards setting page(hamburger menu), BR panel and NTP
  • Confirmed AC, monthly tips, one-time tips are processed
  • Confirmed custom tips can be sent to verified pubs and tips are processed successfully
  • Confirmed tips sent to unverified pubs are listed in pending contribution table
  • Confirmed monthly tips are processed even when the AC switch is OFF
  • Confirmed that one time tips and monthly tips can be sent when AC switch is OFF
  • Confirmed monthly tips are processed when AC switch is turned OFF
  • Confirme re-enable AC switch doesn't lose the rewards data
Example Example Example Example
image image image image

Notifications:

Example Example
image image
BAT to USD exchange rate_tipping banner_PASSED
  • Confirmed BAT to USD exchange rate is shown correctly on one-time tipping banner
  • Confirmed BAT to USD exchange rate is shown correctly on monthly tipping banner

USD conversion on tipping banner:

Example Example Example
image image image

USD conversion

Example Example Example
image image image

USD converstion on all panels

Example Example Example Example
image image image image
Rewards parameters fetch_PASSED
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[25332:14996:0822/145044.254:VERBOSE1:recovery.cc(22)] Running empty balance check...
[25332:14996:0822/145044.264:VERBOSE1:publisher_prefix_list_updater.cc(65)] Fetching publisher prefix list
[25332:14996:0822/145044.265:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://rewards-stg.bravesoftware.com/publishers/prefix-list
> Method: GET
[25332:14996:0822/145044.270:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=windows
> Method: GET
[25332:14996:0822/145044.280:VERBOSE1:promotion.cc(582)] Promotion is empty
[25332:14996:0822/145044.283:VERBOSE1:recovery_empty_balance.cc(110)] Creds batch list is emtpy
[25332:14996:0822/145044.353:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=windows
> Method: GET
[25332:14996:0822/145044.355:VERBOSE1:wallet_balance.cc(42)] Wallet is not created
[25332:14996:0822/145044.359:VERBOSE1:ledger_impl.cc(519)] Rewards parameters not set - fetching from server
[25332:14996:0822/145044.364:VERBOSE1:api_parameters.cc(33)] API parameters fetch in progress
[25332:14996:0822/145046.183:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=windows
> Result: Success
> HTTP Code: 200
> Body: {"promotions":[{"id":"f05568e6-f4a1-4438-8e81-cc0490fd14f7","createdAt":"2022-07-05T16:19:25.919928Z","expiresAt":"2022-10-05T16:19:25.919928Z","version":5,"suggestionsPerGrant":120,"approximateValue":"30","type":"ugp","available":true,"platform":"desktop","publicKeys":["6AphTvx13IgxVRG1nljV2ql1Y7yGUol6yrVMhEP85wI="],"legacyClaimed":false,"claimableUntil":"2022-10-05T16:19:25.919928Z"}]}

[25332:14996:0822/145046.183:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=windows

> Header content-length: 391
> Header content-type: application/json
> Header date: Mon, 22 Aug 2022 09:20:44 GMT
> Header request-id: cc1kkr085m7827jcbkm0
> Header via: 1.1 6518cc3b6d618d5c50a6692afcb46410.cloudfront.net (CloudFront)
> Header x-amz-cf-id: rrtkJWAaLbGHGktlnkSKvMNKpncmr8KIVFoxW1WBcOxv4ewfMUj7qA==
> Header x-amz-cf-pop: MAA51-C2
> Header x-cache: Miss from cloudfront
> Header x-request-id: HH6o26HBS6cAAeKo
[25332:14996:0822/145046.361:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.353225,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}

[25332:14996:0822/145046.361:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters

> Header content-length: 574
> Header content-type: application/json
> Header date: Mon, 22 Aug 2022 09:20:45 GMT
> Header request-id: cc1kkr3upf42j5sihgag
> Header x-request-id: 91oC4B6co2JB91L9
[25332:14996:0822/145046.367:VERBOSE1:api_parameters.cc(90)] Params timer set for 11136 s
[25332:14996:0822/145046.391:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=windows
> Result: Success
> HTTP Code: 200
> Body: {"promotions":[{"id":"f05568e6-f4a1-4438-8e81-cc0490fd14f7","createdAt":"2022-07-05T16:19:25.919928Z","expiresAt":"2022-10-05T16:19:25.919928Z","version":5,"suggestionsPerGrant":120,"approximateValue":"30","type":"ugp","available":true,"platform":"desktop","publicKeys":["6AphTvx13IgxVRG1nljV2ql1Y7yGUol6yrVMhEP85wI="],"legacyClaimed":false,"claimableUntil":"2022-10-05T16:19:25.919928Z"}]}

[25332:14996:0822/145046.396:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=windows

> Header age: 1
> Header content-length: 391
> Header content-type: application/json
> Header date: Mon, 22 Aug 2022 09:20:44 GMT
> Header request-id: cc1kkr085m7827jcbkm0
> Header via: 1.1 6518cc3b6d618d5c50a6692afcb46410.cloudfront.net (CloudFront)
> Header x-amz-cf-id: sbyCsHy480I9mR8cQxmOn0kK2zCfAHEY5DbCe3W4UN820AttfAYYVA==
> Header x-amz-cf-pop: MAA51-C2
> Header x-cache: Hit from cloudfront
> Header x-request-id: HH6o26HBS6cAAeKo
[25332:14996:0822/145047.275:VERBOSE7:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://rewards-stg.bravesoftware.com/publishers/prefix-list
> Result: Success
> HTTP Code: 200
> Body:�����"C��
[25332:14996:0822/145047.275:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://rewards-stg.bravesoftware.com/publishers/prefix-list
....
> Header accept-ranges: bytes
> Header age: 9812
> Header content-length: 1111499
> Header content-type: binary/octet-stream
> Header date: Mon, 22 Aug 2022 06:37:13 GMT
> Header etag: "8eb5931572feb7dd5f4ef40c894258d5"
> Header last-modified: Mon, 22 Aug 2022 05:00:11 GMT
> Header server: AmazonS3
> Header via: 1.1 8105f0ab150eecf20c3e922a3608be3a.cloudfront.net (CloudFront)
> Header x-amz-cf-id: YAlLjz_3iBrF8NOinUg4h9TL6Hsu-fs6EF4oT0xUZD1JsZ3WGBot3g==
> Header x-amz-cf-pop: MAA51-C2
> Header x-cache: Hit from cloudfront
[25332:14996:0822/145047.298:VERBOSE1:publisher_prefix_list_updater.cc(102)] Resetting publisher prefix list table
[25332:14996:0822/145047.298:VERBOSE1:database_publisher_prefix_list.cc(120)] Clearing publisher prefixes table
publisher prefix table
[25332:14996:0822/145050.259:VERBOSE1:database_publisher_prefix_list.cc(130)] Inserting 157 records into publisher prefix table
[25332:14996:0822/145050.267:VERBOSE1:publisher_prefix_list_updater.cc(58)] Scheduling publisher prefix list update in 259199 seconds
[25332:14996:0822/145050.267:VERBOSE1:unverified.cc(31)] Pending tips processing starting
[25332:14996:0822/145050.273:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[25332:14996:0822/145050.274:VERBOSE1:unverified.cc(77)] List is empty
[25332:14996:0822/145050.274:VERBOSE1:unverified.cc(249)] Pending tips processing completed
[25332:14996:0822/145051.906:VERBOSE1:rewards_service_impl.cc(454)] Ledger process is already running
[25332:14996:0822/145051.917:VERBOSE5:ledger_impl.cc(117)]
payout status_PASSED
fetch and claim promotions_PASSED
exclude and restore publishers_PASSED
  • Confirmed that a site can be excluded from AC table
  • Confirmed that click on Restore all remove all the sites from the table
  • Confirmed that a site can be excluded from the BR panel
Example Example Example Example
image image image image
auto-contribute choices_PASSED
  • Verified AC cab be triggered for the various monthly payments 1 BAT, 2 BAT, 3 BAT, 5 BAT and 7 BAT etc
  • Verified AC is processed succesfully for the various monthly payments
  • When the wallet balance (6.75) is lesser than the AC (7 BAT) amount then the AC will be processed for the remaining amount 6.75 BAT
  • Verified AC settings can be updated via rewards advanced settings
Example Example Example Example Example
image image image image image
monthly tip choices_PASSED
  • Confirmed monthly tips are processed for various tip choices 1.25 BAT, 5 BAT, 10 BAT etc
  • Confirmed custom tips can be set for the monthly tips
  • Confirmed monthly tips set can be updated/changed via BR panel
  • Confirmed monthly tips can be canceled via tipping banner/BR panel
  • Confirmed monthly tips are pocessed
  • Confirmed monthly tips can be removed via Monthly Tips panel
Example Example Example Example Example Example Example
image image image image image image image
one-time tip choices_PASSED
  • Confirmed user can send default or custom one time tips
  • Confirmed tips are sent to the verified pubs
  • Confirmed tips sent to unverified pubs are stored in pending contribution table
  • Confirmed that one time tips sent to verified pubs are listed under Tips panel
Example Example Example
image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 22, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 22, 2022

Verification PASSED using

Brave | 1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Linux
Create a wallet flow_PASSED
  • Confirmed that rewards wallet can be created via rewards setting page(hamburger menu), BR panel and NTP
  • Confirmed AC, monthly tips, one-time tips are processed
  • Confirmed custom tips can be sent to verified pubs and tips are processed successfully
  • Confirmed tips sent to unverified pubs are listed in pending contribution table
  • Confirmed monthly tips are processed even when the AC switch is OFF
  • Confirmed that one time tips and monthly tips can be sent when AC switch is OFF
  • Confirmed monthly tips are processed when AC switch is turned OFF
  • Confirmed re-enable AC switch doesn't lose the rewards data
Example Example Example Example
recent Pending contribution Statement pending contributions stmt

Notifications:

Example Example
Monthlytips autocontribute
BAT to USD exchange rate_tipping banner_PASSED
  • Confirmed BAT to USD exchange rate is shown correctly on one-time tipping banner
  • Confirmed BAT to USD exchange rate is shown correctly on monthly tipping banner

USD conversion on tipping banner:

one-time monthly custom
one-time monthly custom

USD conversion

Example Example Example Example Example Example
1 2 3 AC OT MT

USD converstion on all panels

Example Example Example Example
USD Conversion -Ads USD conversion AC USD Conversion Tops Monthly tips
Rewards parameters fetch_PASSED
 [REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[46995:46995:0822/134900.384506:VERBOSE1:recovery.cc(22)] Running empty balance check...
[46995:46995:0822/134900.400057:VERBOSE1:publisher_prefix_list_updater.cc(65)] Fetching publisher prefix list
[46995:46995:0822/134900.401123:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://rewards-stg.bravesoftware.com/publishers/prefix-list
> Method: GET
[46995:46995:0822/134900.427258:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=linux
> Method: GET
[46995:46995:0822/134900.487358:VERBOSE1:promotion.cc(582)] Promotion is empty
[46995:46995:0822/134900.494214:VERBOSE1:recovery_empty_balance.cc(110)] Creds batch list is emtpy
[46995:46995:0822/134900.774771:WARNING:CONSOLE(1)] "Could not find style data in module named br-shared-style", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)
[46995:46995:0822/134901.759362:VERBOSE1:ledger_impl.cc(519)] Rewards parameters not set - fetching from server
[46995:46995:0822/134901.759885:VERBOSE1:api_parameters.cc(33)] API parameters fetch in progress
[46995:46995:0822/134901.789665:VERBOSE1:wallet_balance.cc(42)] Wallet is not created
[46995:46995:0822/134901.808520:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=linux
> Method: GET
[46995:46995:0822/134902.233474:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[46995:46995:0822/134902.653200:VERBOSE6:logging_util.cc(137)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=linux
> Result: Success
> HTTP Code: 200
> Body: {"promotions":[{"id":"f05568e6-f4a1-4438-8e81-cc0490fd14f7","createdAt":"2022-07-05T16:19:25.919928Z","expiresAt":"2022-10-05T16:19:25.919928Z","version":5,"suggestionsPerGrant":120,"approximateValue":"30","type":"ugp","available":true,"platform":"desktop","publicKeys":["6AphTvx13IgxVRG1nljV2ql1Y7yGUol6yrVMhEP85wI="],"legacyClaimed":false,"claimableUntil":"2022-10-05T16:19:25.919928Z"}]}
[46995:46995:0822/134902.654344:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=linux
> Result: Success
> HTTP Code: 200
> Body: {"promotions":[{"id":"f05568e6-f4a1-4438-8e81-cc0490fd14f7","createdAt":"2022-07-05T16:19:25.919928Z","expiresAt":"2022-10-05T16:19:25.919928Z","version":5,"suggestionsPerGrant":120,"approximateValue":"30","type":"ugp","available":true,"platform":"desktop","publicKeys":["6AphTvx13IgxVRG1nljV2ql1Y7yGUol6yrVMhEP85wI="],"legacyClaimed":false,"claimableUntil":"2022-10-05T16:19:25.919928Z"}]}
[46995:46995:0822/134902.654344:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=linux
> Header content-length: 391
> Header content-type: application/json
> Header date: Mon, 22 Aug 2022 20:49:02 GMT
> Header request-id: cc1unfg85m7827jcbsrg
> Header via: 1.1 1ffd5cdb315141702d5377ba909be92a.cloudfront.net (CloudFront)
> Header x-amz-cf-id: 5AB6ScuDldirPTo6HgFDXU0mMO7hYImRXrdDl82FZqlgedLRVji2zQ==
> Header x-amz-cf-pop: LAX50-P1
> Header x-cache: Miss from cloudfront
> Header x-request-id: 33fYMJG8Xj2YfYDH
[46995:46995:0822/134902.728809:VERBOSE6:logging_util.cc(137)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&platform=linux
> Result: Success
> HTTP Code: 200
> Body: {"promotions":[{"id":"f05568e6-f4a1-4438-8e81-cc0490fd14f7","createdAt":"2022-07-05T16:19:25.919928Z","expiresAt":"2022-10-05T16:19:25.919928Z","version":5,"suggestionsPerGrant":120,"approximateValue":"30","type":"ugp","available":true,"platform":"desktop","publicKeys":["6AphTvx13IgxVRG1nljV2ql1Y7yGUol6yrVMhEP85wI="],"legacyClaimed":false,"claimableUntil":"2022-10-05T16:19:25.919928Z"}]}
[46995:46995:0822/134902.729120:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://rewards-stg.bravesoftware.com/publishers/prefix-list
> Header accept-ranges: bytes
> Header age: 26036
> Header content-length: 1111499
> Header content-type: binary/octet-stream
> Header date: Mon, 22 Aug 2022 20:49:02 GMT
> Header etag: "8eb5931572feb7dd5f4ef40c894258d5"
> Header last-modified: Sat, 20 Aug 2022 07:00:16 GMT
> Header server: AmazonS3
> Header vary: Accept-Encoding
> Header via: 1.1 e4e9f958f2aecd2a30698721fc907076.cloudfront.net (CloudFront)
> Header x-amz-cf-id: DlaJcgLlQaBTNpu2J4GTUa6uoyn6ZMZpi9IX23GxXZSUmdv1wyEfOA==
> Header x-amz-cf-pop: LAX53-P2
> Header x-cache: Hit from cloudfront
[46995:46995:0822/134903.061018:VERBOSE1:publisher_prefix_list_updater.cc(102)] Resetting publisher prefix list table
[46995:46995:0822/134903.062011:VERBOSE1:database_publisher_prefix_list.cc(120)] Clearing publisher prefixes table
[46995:46995:0822/134919.671238:VERBOSE1:database_publisher_prefix_list.cc(130)] Inserting 157 records into publisher prefix table
[46995:46995:0822/134920.091801:VERBOSE1:unverified.cc(31)] Pending tips processing starting
[46995:46995:0822/134920.244311:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[46995:46995:0822/134920.359879:VERBOSE1:unverified.cc(77)] List is empty
[46995:46995:0822/134920.384386:VERBOSE1:unverified.cc(249)] Pending tips processing completed
[46995:46995:0822/134905.515032:VERBOSE1:rewards_service_impl.cc(454)] Ledger process is already running
payout status_PASSED

REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
[71404:71404:0824/084511.264137:VERBOSE6:logging_util.cc(137)] 
[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"processing","uphold":"processing","gemini":"processing","bitflyer":"processing"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.376433,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}

Fetch and claim promotions_PASSED
Unverified (no custodian connected)_& Gemini claim promotion_view_PASSED
  • Confirmed ad grants promotion can be claimed via BR panel
  • Confirmed ad grants promotion can be claimed via rewards settings page
  • Confirmed ad grants promotion can be claimed via NTP rewards panel
Ex1 Ex2 Ex3
image image image
Uphold connected_claim promotion_via rewards settings page_PASSED
  • Confirmed ad grants promotion can be claimed via rewards settings page
  • Confirmed claimed grants are shown in the wallet balance
  • Confirmed claimed ad grants promotion is shown in the rewards summary, BR panel, NTP, monthly statement and brave://rewards-internal pages
  • Confirmed claimed Ad grants moved to the uphold wallet
  • Confirmed claimed ad grants reflected in the uphold wallet balance and the transaction history
Ex Ex Ex Ex Ex Ex Ex Ex
Rewards settings Screenshot from 2022-08-23 09-08-03 Rewards_claimed claimed ad grants on NTP claimed ad grants on rewards settings claimed ad grant on stmt uphold claimed ads grant on rewards internals
exclude and restore publishers_PASSED
  • Confirmed that a site can be excluded from AC table
  • Confirmed that click on Restore all remove all the sites from the table
  • Confirmed that a site can be excluded from the BR panel
Example Example Example Example
AC1 AC2 AC3 AC4
auto-contribute choices_PASSED
  • Verified AC cab be triggered for the various monthly payments 1 BAT, 2 BAT, 3 BAT, 5 BAT and 10 BAT etc
  • Verified AC is processed successfully for the various monthly payments
  • When the wallet balance (9.00) is lesser than the AC (10 BAT) amount then the AC will be processed for the remaining amount 3.00 BAT
  • Verified AC settings can be updated via rewards advanced settings
Ex1 Ex2 Ex3 Ex4 Ex5 Ex6 Ex7 Ex8
AC-1 BAT AC-2 BAT AC-3 BAT AC1 AC10 2-less than the AC 1- Less than balance stmt
monthly tip choices_PASSED
  • Confirmed monthly tips are processed for various tip choices 1.25 BAT, 5 BAT, 10 BAT etc
  • Confirmed custom tips can be set for the monthly tips
  • Confirmed monthly tips set can be updated/changed via BR panel
  • Confirmed monthly tips can be canceled via tipping banner/BR panel
  • Confirmed monthly tips are processed
  • Confirmed monthly tips can be removed via Monthly Tips panel
Example Example Example Example Example Example Example
5m 2 10 8m 6m 4m 7m
one-time tip choices_PASSED
  • Confirmed user can send default or custom one time tips
  • Confirmed tips are sent to the verified pubs
  • Confirmed tips sent to unverified pubs are stored in pending contribution table
  • Confirmed that one time tips sent to verified pubs are listed under Tips panel
Example Example Example
tips1 Tips2 tips3

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 24, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Aug 24, 2022

Verified with

Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5.1 (Build 21G83)
Create a wallet flow - PASSED
  • Confirmed that rewards wallet can be created via the following:
    • panel
    • NTP
    • brave://rewards page (either accessed directly or via hamburger menu)
Example Example Example
1 2 3
BAT to USD exchange rate display - PASSED
  • Confirmed BAT to USD exchange rate is shown correctly on one-time tipping banner
  • Confirmed BAT to USD exchange rate is shown correctly on monthly tipping banner
  • Confirmed BAT to USD exchange rate is shown correctly for custom tip amounts on tipping banner
  • Confirmed BAT to USD exchanged rate is shown correctly on special tipping banners (in-line tips for Twitter and Reddit)
  • Spot checked other USD exchange rate displays

USD conversion on tipping banner:

Example Example Example Example Example Example
Screen Shot 2022-08-24 at 9 40 08 AM Screen Shot 2022-08-24 at 9 40 18 AM Screen Shot 2022-08-24 at 9 40 26 AM Screen Shot 2022-08-24 at 9 40 54 AM Screen Shot 2022-08-24 at 9 43 16 AM Screen Shot 2022-08-24 at 9 44 15 AM

USD conversion other places

Example Example Example Example Example Example Example Example Example Example Example Example
Screen Shot 2022-08-24 at 11 08 02 AM Screen Shot 2022-08-24 at 11 08 10 AM Screen Shot 2022-08-24 at 11 08 17 AM Screen Shot 2022-08-24 at 11 08 24 AM Screen Shot 2022-08-24 at 11 08 30 AM Screen Shot 2022-08-24 at 11 09 01 AM Screen Shot 2022-08-24 at 11 35 34 AM Screen Shot 2022-08-24 at 11 35 43 AM Screen Shot 2022-08-24 at 11 35 51 AM Screen Shot 2022-08-24 at 11 35 59 AM Screen Shot 2022-08-24 at 11 36 06 AM Screen Shot 2022-08-24 at 11 36 11 AM
Rewards parameters fetch - PASSED
  • Confirmed parameters fetch completed without error
[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET
........
[13409:259:0824/132347.670460:VERBOSE1:ledger_impl.cc(519)] Rewards parameters not set - fetching from server
[13409:259:0824/132347.670505:VERBOSE1:api_parameters.cc(33)] API parameters fetch in progress
......
[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"processing","uphold":"processing","gemini":"processing","bitflyer":"processing"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.375941,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
[13409:259:0824/132348.028734:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
[13409:259:0824/132348.029944:VERBOSE1:api_parameters.cc(90)] Params timer set for 11295 s
fetch and claim promotions - PASSED

Verified as part of #24108 (comment)

exclude and restore publishers - PASSED
  • Confirmed that a site can be excluded from AC table
  • Confirmed that click on Restore all remove all the sites from the table
    • Confirmed a site can be re-added once removed from the exclude list
  • Confirmed that a site can be excluded from the BR panel
    • Confirmed that a site can be added back from the panel
Example Example Example
Screen Shot 2022-08-24 at 2 28 09 PM Screen Shot 2022-08-24 at 2 28 18 PM Screen Shot 2022-08-24 at 2 28 28 PM
auto-contribute choices - PASSED
  • Verified AC settings can be updated via Auto Contribute advanced settings as well as directly on brave://rewards page
  • Verified AC can be triggered
    • Spot checked that AC is processed successfully for various monthly payment values (I used default value of 1 BAT and a user selected value of 3 BAT to test with)
    • Confirmed when the wallet balance (ex. 4.5 BAT) is less than the AC amount (5 BAT) then the AC will be processed for the remaining amount
Example Example Example Example Example Example
Screen Shot 2022-08-24 at 2 48 28 PM Screen Shot 2022-08-24 at 2 48 46 PM Screen Shot 2022-08-24 at 3 04 43 PM Screen Shot 2022-08-24 at 2 55 56 PM Screen Shot 2022-08-24 at 3 10 06 PM Screen Shot 2022-08-24 at 3 13 46 PM

Verified AC with Uphold as the custodian could be completed:

Example Example Example Example
Screen Shot 2022-08-24 at 3 20 17 PM Screen Shot 2022-08-24 at 3 24 29 PM Screen Shot 2022-08-24 at 3 24 38 PM Screen Shot 2022-08-24 at 3 24 55 PM

Unable to check Gemini AC on staging as it does not work due to known server side problem.

monthly tip choices - PASSED
  • Confirmed default monthly tip choices are 1.25 BAT, 5 BAT, 10 BAT as per parameters endpoint, except where defined by the creator
  • Confirmed custom tip value can be set for the monthly tips
  • Confirmed monthly tips set can be updated/changed via BR panel
  • Confirmed monthly tips can be canceled via tipping banner/BR panel
  • Confirmed monthly tips can be removed via Monthly Tips panel
Default Values Custom Values Monthly Tip - Default Monthly Tip - Custom Panel options Cancel Monthly Tip Cancel Monthly Tip
Screen Shot 2022-08-24 at 4 15 39 PM Screen Shot 2022-08-24 at 4 15 55 PM Screen Shot 2022-08-24 at 4 16 58 PM Screen Shot 2022-08-24 at 4 17 27 PM Screen Shot 2022-08-24 at 4 17 43 PM Screen Shot 2022-08-24 at 4 18 24 PM Screen Shot 2022-08-24 at 4 18 40 PM
  • Confirmed monthly tips are processed
brave://rewards brave://rewards-internals Monthly Statement Wallet Panel
Screen Shot 2022-08-24 at 4 25 51 PM Screen Shot 2022-08-24 at 4 29 09 PM Screen Shot 2022-08-24 at 4 29 26 PM Screen Shot 2022-08-24 at 4 29 32 PM
one-time tip choices - PASSED

One time tips were extensively covered with the following issue verifications:

payout status - PASSED

Verified as part of https://github.com/brave/internal/issues/882#issuecomment-1227251327

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 25, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 26, 2022

Verified on Samsung Galaxy S21 using the following build:

Brave	1.43.82 Chromium: 105.0.5195.58 (Official Build) (64-bit) 
Revision	1907e1693887af4463221a10247360b7a056db49-refs/branch-heads/5195_47@{#3}
OS	Android 12; Build/SP1A.210812.016
Create a wallet flow

Confirmed that rewards wallet can be created via the following:

  • BR panel
  • brave://rewards page (either accessed directly or via hamburger menu)
Example Example Example Example
screenshot-1661543201917 screenshot-1661543212965 screenshot-1661543221188 screenshot-1661543434216
BAT to USD exchange rate display

Confirmed BAT to USD exchange rate is shown correctly on

  • One time tip banner
  • Monthly tip banner
  • All pages under brave://rewards
  • Rewards Summary on panel/rewards page
Tip Banner Tip Banner
screenshot-1661540146100 screenshot-1661540172183
Example Example Example Example Example
screenshot-1661540253701 screenshot-1661540298399 screenshot-1661540360256 screenshot-1661540374906 screenshot-1661539866954
Exclude and restore publishers
  • Confirmed that a site can be excluded from AC table
  • Confirmed that click on Restore all remove all the sites from the table
  • Confirmed a site can be re-added once removed from the exclude list
  • Confirmed that a site can be excluded from the BR panel
  • Confirmed that a site can be added back from the panel
Auto-contribute choices
  • Verified AC settings can be updated via Auto Contribute advanced settings as well as directly on brave://rewards page
  • Verified AC can be triggered
  • Spot checked that AC is processed successfully for various monthly payment values (I used default value of 1 BAT and a user selected value of 3 BAT to test with)
  • Confirmed when the wallet balance (ex. 5 BAT) is less than the AC amount (7 BAT) then the AC will be processed for the remaining amount
Example Example Example Example
screenshot-1661548561493 screenshot-1661548570194 screenshot-1661548723411 screenshot-1661548759276
Monthly tip choices
  • Confirmed default monthly tip choices are 1.000 BAT, 5.000 BAT, 10.000 BAT as per parameters endpoint, except where defined by the creator
  • Confirmed user can set tip to be a monthly contribution via the checking Make this monthly Deselecting will change submit CTA value to Send My Tip
  • Confirmed Make this monthly checkbox option will not be shown if there is already a monthly contribution set.
  • Confirmed monthly tips set can be updated/changed via BR panel
  • Confirmed monthly tips can be canceled via tipping banner/BR panel
  • Confirmed monthly tips can be removed via Monthly Tips panel
Example Example
screenshot-1661540146100 screenshot-1661540172183
one-time tip choices
  • Confirmed user is able to make a one time tip
  • Confirmed one time tips are shown under tipping in rewards page
  • Confirmed tip amount is reflected in the rewards summary and BR panel.
  • Confirmed successful tip message is shown after sending tip
  • Confirmed banner is displayed when there are insufficient tokens for tips
Example Example Example Example
screenshot-1661550069367 screenshot-1661550083112 screenshot-1661550106775 screenshot-1661550123396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants