-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove std::function<>
from further Ledger
flows
#24200
Comments
Verification PASSED on
Create a wallet flow_PASSED
Notifications:
BAT to USD exchange rate_tipping banner_PASSED
USD conversion on tipping banner:
USD conversion
USD converstion on all panels
Rewards parameters fetch_PASSED
payout status_PASSED
fetch and claim promotions_PASSED
exclude and restore publishers_PASSED
auto-contribute choices_PASSED
monthly tip choices_PASSED
one-time tip choices_PASSED
|
Verification
Create a wallet flow_PASSED
Notifications:
BAT to USD exchange rate_tipping banner_PASSED
USD conversion on tipping banner:
USD conversion
USD converstion on all panels
Rewards parameters fetch_PASSED
payout status_PASSED
Fetch and claim promotions_PASSEDUnverified (no custodian connected)_& Gemini claim promotion_view_PASSED
Uphold connected_claim promotion_via rewards settings page_PASSED
exclude and restore publishers_PASSED
auto-contribute choices_PASSED
monthly tip choices_PASSED
one-time tip choices_PASSED
|
Verified with
Create a wallet flow - PASSED
BAT to USD exchange rate display - PASSED
USD conversion on tipping banner:
USD conversion other places
Rewards parameters fetch - PASSED
fetch and claim promotions - PASSEDVerified as part of #24108 (comment) exclude and restore publishers - PASSED
auto-contribute choices - PASSED
Verified AC with Uphold as the custodian could be completed:
Unable to check Gemini AC on staging as it does not work due to known server side problem. monthly tip choices - PASSED
one-time tip choices - PASSEDOne time tips were extensively covered with the following issue verifications: payout status - PASSEDVerified as part of https://github.com/brave/internal/issues/882#issuecomment-1227251327 |
Part3 of #18560.
The text was updated successfully, but these errors were encountered: