Follow up of #15055 - Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT #15889

GeetaSarvadnya · 2021-05-17T08:26:47Z

Description

Follow up of #15055
Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT

Steps to Reproduce

Scenarios 1:

Clean profile 1.25.60, enable rewards and claim UGP grants
Open a verified pub and send 6 BAT to a verified pubs
Make sure wallet balance is less than 25 BAT
Click on "Verify wallet" in BR panel
Uphold Authorize page is displayed instead on Verify Wallet modal popup

Scenarios 2:

Clean profile 1.25.60, enable rewards and claim UGP grants
Open a verified pub and send 15 BAT to a verified pubs
Make sure wallet balance is equals to 15 BAT
Click on "Verify wallet" in BR panel
Uphold Authorize page is displayed instead on Verify Wallet modal popup

Note: Please note, if wallet balance is 30 BAT click on Verify wallet via BR panel opens up "Verify wallet" modal popup, issue is arising only when wallet balance is less than 25 BAT and equals to 15 BAT

Actual result:

Click on "Verify wallet" in BR panel is redirecting to Uphold Authorize page

Expected result:

Click on "Verify wallet" in BR panel should opens up "Verify wallet" modal popup

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Windows 10 OS Version 2004 (Build 19041.985)

Version/Channel Information:

Can you reproduce this issue with the current release? NA
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @zenparsing @emerick @rebron

The text was updated successfully, but these errors were encountered:

LaurenWags · 2021-05-17T14:35:05Z

cc @Miyayes as this does not occur on 1.24.x so this is a regression. Please advise on if this is needed to be fixed for 1.25.x.

Note - with 1.24.x if you click on "Verify Wallet" from the panel with an adequate balance (>= 25 BAT), a new tab opens and redirects the user to brave://rewards/#verify.

LaurenWags · 2021-05-17T14:39:00Z

Additionally, on 1.25.x, if you click on "Verify Wallet" from brave://rewards page, you get the modal. But clicking on "Verify Wallet" from the panel does not show this.

LaurenWags · 2021-05-18T12:16:29Z

Adding QA/Blocked until this is uplifted to 1.25.x

GeetaSarvadnya · 2021-05-21T09:57:49Z

Verification passed on


Brave | 1.25.65 Chromium: 91.0.4472.57&nbsp;(Official Build)&nbsp;(64-bit)
-- | --
Revision | e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

Verified the STR from #15889 (comment)

Scenario 1: wallet balance is 24 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Scenario 2: wallet balance is 15 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Wallet balance 15 BAT	Click Verify wallet via BR panel	Verify wallet modal popup	uphold authorization

Scenario 3: wallet balance is 20 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Wallet balance 20 BAT	Click Verify wallet via BR panel	Verify wallet modal popup	uphold authorization

Scenario 4: Upgrade case which has wallet balance less than 25 BAT

Installed 1.24.x nightly build and made sure wallet balance is less than 25 BAT
Confirmed that click on Verify wallet via BR panel in 1.24.x shows the message as min wallet balance should be 25 BAT to create uphold account
Upgrade the profile to 1.26.x nightly build
Confirmed that click on Verify wallet via BR panel in 1.25.x displays the Verify wallet modal popup as expected

1.24.x	1.24.x	1.25.x	1.25.x	1.25.x

Verified passed with

Brave	1.25.65 Chromium: 91.0.4472.57 (Official Build) (x86_64)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	macOS Version 10.15.7 (Build 19H1030)

Verified scenarios below.

Scenario 1: wallet balance is 24 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Wallet balance 24 BAT/Click Verify wallet via BR panel	Verify wallet modal popup	uphold authorization

Scenario 2: wallet balance is 20 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Wallet balance 20 BAT/Click Verify wallet via BR panel	Verify wallet modal popup	uphold authorization

Scenario 3: wallet balance is 15 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Wallet balance 15 BAT/Click Verify wallet via BR panel	Verify wallet modal popup	uphold authorization

Scenario 4: wallet balance is 14 BAT

Confirmed that the Login popup is displayed upon clicking on Verify wallet via BR panel and on brave://rewards when balance is less than 15 BAT

Wallet balance 14 BAT	Login prompt via BR panel	Wallet balance 14 BAT	Login prompt via brave://rewards

Scenario 5: Upgrade case which has wallet balance less than 25 BAT

Installed 1.24.x release build and made sure wallet balance is less than 25 BAT
Confirmed that click on Verify wallet via BR panel in 1.24.x shows the message as min wallet balance should be 25 BAT to create uphold account
Upgrade the profile to 1.25.x release preview build
Confirmed that click on Verify wallet via BR panel in 1.25.x displays the Verify wallet modal popup as expected

1.24.x	1.24.x	1.25.x	1.25.x

Verification passed on

Brave	1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	Linux

Verified the STR from #15889 (comment)

Scenario 1: wallet balance is 24 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

||

--|--|--

Scenario 2: wallet balance is 15 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel
||
--|--|--

Scenario 3: wallet balance is 20 BAT

Confirmed that the Verify wallet modal popup is displayed upon clicking on Verify wallet via BR panel

Scenario 4: Upgrade case which has wallet balance less than 25 BAT

Installed 1.24.x build and made sure wallet balance is less than 25 BAT
Confirmed that click on Verify wallet via BR panel in 1.24.x shows the message as min wallet balance should be 25 BAT to create uphold account
Upgrade the profile to 1.26.x nightly build
Confirmed that click on Verify wallet via BR panel in 1.25.x displays the Verify wallet modal popup as expected

GeetaSarvadnya added bug feature/rewards QA/Yes QA/Test-Plan-Specified OS/Desktop labels May 17, 2021

GeetaSarvadnya mentioned this issue May 17, 2021

Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT #15055

Closed

LaurenWags added the regression label May 17, 2021

LaurenWags added the release/blocking label May 17, 2021

LaurenWags added this to the 1.25.x - Beta milestone May 17, 2021

zenparsing mentioned this issue May 17, 2021

Use correct uphold minimum balance amount on the Rewards panel brave/brave-core#8824

Merged

24 tasks

zenparsing closed this as completed in brave/brave-core#8824 May 18, 2021

LaurenWags added the QA/Blocked label May 18, 2021

brave-builds mentioned this issue May 18, 2021

Use correct uphold minimum balance amount on the Rewards panel (uplift to 1.25.x) brave/brave-core#8844

Merged

7 tasks

LaurenWags added release-notes/exclude QA/Test-All-Platforms labels May 19, 2021

GeetaSarvadnya removed the QA/Blocked label May 21, 2021

GeetaSarvadnya added the QA Pass-Win64 label May 21, 2021

LaurenWags added the QA Pass-macOS label May 21, 2021

btlechowski added the QA Pass-Linux label May 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow up of #15055 - Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT #15889

Follow up of #15055 - Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT #15889

GeetaSarvadnya commented May 17, 2021 •

edited

Loading

LaurenWags commented May 17, 2021 •

edited

Loading

LaurenWags commented May 17, 2021

LaurenWags commented May 18, 2021

GeetaSarvadnya commented May 21, 2021 •

edited by btlechowski

Loading

Follow up of #15055 - Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT #15889

Follow up of #15055 - Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT #15889

Comments

GeetaSarvadnya commented May 17, 2021 • edited Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

LaurenWags commented May 17, 2021 • edited Loading

LaurenWags commented May 17, 2021

LaurenWags commented May 18, 2021

GeetaSarvadnya commented May 21, 2021 • edited by btlechowski Loading

GeetaSarvadnya commented May 17, 2021 •

edited

Loading

LaurenWags commented May 17, 2021 •

edited

Loading

GeetaSarvadnya commented May 21, 2021 •

edited by btlechowski

Loading