Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT #15055

Miyayes · 2021-03-31T22:02:28Z

Description

Currently, users need to have 25 BAT to verify their user wallet with Uphold.

Uphold has approved lowering the verification threshold to 15 BAT as of March 31, 2021.

Solution

Reduce all relevant wallet verification gating logic to a 15 BAT threshold.

CloggyAbroad · 2021-04-16T17:39:29Z

It looks like the text hasn't been updated in all locations

stephendonner · 2021-04-21T17:46:33Z

Verified PASSED using the testplan from brave/brave-core#8453

Brave	1.25.33 Chromium: 90.0.4430.85 (Official Build) nightly (x86_64)
Revision	5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

Scenario: User has less than 15 BAT (Rewards panel & `brave://rewards` page)

launched Brave using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
clicked Start using Rewards and confirmed UGP token grant of 30.000 BAT
loaded https://www.github.com/laurenwags, and clicked on the BAT icon
clicked Send a tip...
chose 20 BAT and clicked Send Tip
BAT balance was now 10.000 BAT
clicked on the BAT icon again and clicked Verify Wallet
confirmed that the text about minimum BAT to create an Uphold account read 15 BAT
loaded brave://rewards and clicked on the Verify Wallet link
confirmed also that the text there about minimum BAT to create an Uphold account read 15 BAT
from both entry-points, I clicked on the orange Login button and was taken to Uphold's sandbox (https://wallet-sandbox.uphold.com/)
verified I could log in to Uphold, but my wallet wasn't verified

Scenario: User has more than 15 BAT (Rewards panel)

launched Brave using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
clicked Start using Rewards and confirmed UGP token grant of 30.000 BAT
clicked on the BAT icon again and clicked Verify Wallet
clicked on the orange Login button and was taken to Uphold's sandbox (https://wallet-sandbox.uphold.com/)
verified I could log in to Uphold, and my wallet was verified

Scenario: User has more than 15 BAT (`brave://rewards` page)

launched Brave using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
clicked Start using Rewards and confirmed UGP token grant of 30.000 BAT
loaded brave://rewards and clicked on the Verify Wallet link
clicked on the orange Login button and was taken to Uphold's sandbox (https://wallet-sandbox.uphold.com/)
verified I could log in to Uphold, and my wallet was verified

example	example	example	example	example	example	example	example

Verification passed on

Brave	1.25.59 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#8453

Brave Rewards Panel

Brave Rewards page

Verification passed on


Brave | 1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows 10 OS Version 2004 (Build 19041.985)

Verified the test plan from Adjust minimum BAT amount for Uphold to 15 brave-core#8453

UGP grants less than 15 BAT

Scenario 1: User has less than 15 BAT UGP Grants and click "Verify Wallet" via BR panel

Confirmed click on "Verify wallet" opens up "login popup" with text "15 BAT" displayed within the popup
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Scenario 2: User has less than 15 BAT UGP Grants and click "Verify Wallet" via brave://rewards settings page

Confirmed click on "Verify wallet" opens up "login popup" with text "15 BAT" displayed within the popup
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

UGP grants =15 BAT

Scenario 1: User has 15 BAT UGP Grants and click "Verify Wallet" via BR panel

Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when rewards wallet has 15 BAT - Logged #15889
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`

Scenario 2: User has 15 BAT UGP Grants and click "Verify Wallet" via brave://rewards settings page

Confirmed click on "Verify wallet" opens up Verify Modal popup
Confirmed click on Verify wallet in modal popup redirects to Uphold authorization page
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

UGP grants greater than15 BAT

Scenario 1: User has 30 BAT UGP Grants and click "Verify Wallet" via BR panel

Confirmed click on "Verify wallet" opens up Verify Modal popup
Confirmed click on Verify wallet in modal popup redirects to Uphold authorization page
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Scenario 2: User has 30 BAT UGP Grants and click "Verify Wallet" via brave://rewards settings page

Confirmed click on "Verify wallet" opens up Verify Modal popup
Confirmed click on Verify wallet in modal popup redirects to Uphold authorization page
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

AD grants less than 15 BAT

Scenario 1: User has less than 15 BAT AD grants and click "Verify Wallet" via BR panel

Confirmed click on "Verify wallet" opens up "login popup" with text "15 BAT" displayed within the popup
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly and Ad grants are moved to brave browser uphold card
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`

Scenario 2: User has less than 15 BAT AD grants and click "Verify Wallet" via brave://rewards settings page

Confirmed click on "Verify wallet" opens up "login popup" with text "15 BAT" displayed within the popup
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly and Ad grants are moved to brave browser uphold card
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`

AD grants greater than15 BAT

Scenario 1: User has 23 BAT Ad Grants and click "Verify Wallet" via BR panel

Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT - logged #15889
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly and Ad grants are moved to brave browser uphold card
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`

Scenario 2: User has 23 BAT AD Grants and click "Verify Wallet" via brave://rewards settings page

Confirmed click on "Verify wallet" opens up Verify Modal popup
Confirmed click on Verify wallet in modal popup redirects to Uphold authorization page
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly and Ad grants are moved to brave browser uphold card
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Ad grants =15 BAT

Scenario 1: User has 15 BAT AD grants and click "Verify Wallet" via BR panel

Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when rewards wallet has 15 BAT - Logged #15889
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly and Ad grants are moved to brave browser uphold card
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`

Scenario 2: User has 15 BAT AD Grants and click "Verify Wallet" via brave://rewards settings page

Confirmed click on "Verify wallet" opens up Verify Modal popup
Confirmed click on Verify wallet in modal popup redirects to Uphold authorization page
Confirmed click on "Login" redirect to the user to Uphold for authorization
Confirmed able to login using existing uphold credentials
Confirmed wallet balance is shown correctly and Ad grants are moved to brave browser uphold card
Confirmed user can tip KYC'd pub using uphold amount
Confirmed transactions were shown correctly in uphold dashboard

`Example`	`Example`	`Example`

stephendonner · 2021-04-21T17:47:57Z

@CloggyAbroad can you still reproduce this with a nightly build (https://brave.com/download-nightly/), against the staging environment, following my steps? Thanks!

CloggyAbroad · 2021-04-22T07:34:55Z

@stephendonner the steps you describe are primarily to verify the limit has been reduced to 15 BAT. I have no doubt this works. What I highlighted is that if you have less than 15 BAT in your rewards wallet (0.25 in my case) and you press the Rewards Logo in the address bar, followed by the Verify Wallet button, a text box pops up saying you need 25 BAT to verify. If I do the same from the brave://reward page a text box pops up saying I need 15 BAT to verify. This is what I showed in the picture I uploaded. This is still the case now (1.25.33 on W10)

AdityaSher · 2021-04-29T08:40:16Z

Is this live on android as well? ( Can't see it on my end)

srirambv · 2021-05-17T08:14:13Z

Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build

Scenario 1 : User has less than 15 BAT (rewards panel)

Verified when wallet has less than 15 BAT the info modal is shown when clicked on Verify Wallet
Verified text clearly mentions min balance of 15 BAT
Verified Login button is shown below the min balance message
Verified clicking that opens Uphold page to connect existing wallet
Verified able to successfully connect existing wallet and balance updates accordingly even when wallet balance is below the min threshold value

Android.ARM.15.BAT.mp4

Scenario 2 : User has exactly 15 BAT (rewards panel)

Verified when wallet has exact 15 BAT and clicks on Verify Wallet on rewards panel, no info message is shown
Verified clicking on Verify Wallet opens up uphold page
Verified able to successfully connect existing wallet and balance updates accordingly

Android.ARM.15BAT.mp4

Scenario 3: User has more than 15 BAT (rewards panel)

Verified when wallet balance is more than 15BAT clicking on verify wallet doesn't show info modal
Verified able to successfully connect to existing Uphold account and balance updates accordingly

Android.ARM.15.BAT.mp4

Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build

Scenario 1 : User has less than 15 BAT (rewards panel)

Verified when wallet has less than 15 BAT the info modal is shown when clicked on Verify Wallet
Verified text clearly mentions min balance of 15 BAT
Verified Login button is shown below the min balance message
Verified clicking that opens Uphold page to connect existing wallet
Verified able to successfully connect existing wallet and balance updates accordingly even when wallet balance is below the min threshold value

Scenario 2 : User has exactly 15 BAT (rewards panel)

Verified when wallet has exact 15 BAT and clicks on Verify Wallet on rewards panel, no info message is shown
Verified clicking on Verify Wallet opens up uphold page
Verified able to successfully connect existing wallet and balance updates accordingly

Scenario 3: User has more than 15 BAT (rewards panel)

Verified when wallet balance is more than 15BAT clicking on verify wallet doesn't show info modal
Verified able to successfully connect to existing Uphold account and balance updates accordingly

Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 31, 2021

Miyayes assigned deeppandya and zenparsing Mar 31, 2021

zenparsing mentioned this issue Apr 6, 2021

Adjust minimum BAT amount for Uphold to 15 brave/brave-core#8453

Merged

24 tasks

zenparsing closed this as completed in brave/brave-core#8453 Apr 8, 2021

zenparsing added this to the 1.25.x - Nightly milestone Apr 8, 2021

zenparsing added QA/Yes release-notes/include labels Apr 9, 2021

stephendonner added the QA Pass-macOS label Apr 21, 2021

LaurenWags added the QA/Test-All-Platforms label May 10, 2021

btlechowski added the QA Pass-Linux label May 12, 2021

srirambv added QA Pass - Android ARM QA Pass - Android Tab labels May 17, 2021

GeetaSarvadnya mentioned this issue May 17, 2021

Follow up of #15055 - Verify wallet modal popup isn't shown after clicking on "Verify wallet" via BR panel when the wallet balance is less than 25 BAT #15889

Closed

GeetaSarvadnya added the QA Pass-Win64 label May 17, 2021

This was referenced May 17, 2021

[Android] Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT on Android #15196

Closed

Wallet verification on Desktop and Android should parity one another #13220

Closed

LaurenWags mentioned this issue May 26, 2021

[Desktop] Release Notes for 1.25.x Release #1 #16089

Closed

This was referenced May 27, 2021

Pending verifications/Release Notes from 1.25.x Release #2 #16107

Closed

Release notes for 1.25.x - Release #2 #16108

Closed

stephendonner mentioned this issue Jun 8, 2021

Change minimum BAT needed for wallet verification to 15 from 25 brave/qa-resources#306

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT #15055

Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT #15055

Miyayes commented Mar 31, 2021

CloggyAbroad commented Apr 16, 2021

stephendonner commented Apr 21, 2021 •

edited by GeetaSarvadnya

Loading

stephendonner commented Apr 21, 2021

CloggyAbroad commented Apr 22, 2021 •

edited

Loading

AdityaSher commented Apr 29, 2021

srirambv commented May 17, 2021 •

edited

Loading

Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT #15055

Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT #15055

Comments

Miyayes commented Mar 31, 2021

Description

Solution

CloggyAbroad commented Apr 16, 2021

stephendonner commented Apr 21, 2021 • edited by GeetaSarvadnya Loading

Scenario: User has less than 15 BAT (Rewards panel & brave://rewards page)

Scenario: User has more than 15 BAT (Rewards panel)

Scenario: User has more than 15 BAT (brave://rewards page)

stephendonner commented Apr 21, 2021

CloggyAbroad commented Apr 22, 2021 • edited Loading

AdityaSher commented Apr 29, 2021

srirambv commented May 17, 2021 • edited Loading

stephendonner commented Apr 21, 2021 •

edited by GeetaSarvadnya

Loading

Scenario: User has less than 15 BAT (Rewards panel & `brave://rewards` page)

Scenario: User has more than 15 BAT (`brave://rewards` page)

CloggyAbroad commented Apr 22, 2021 •

edited

Loading

srirambv commented May 17, 2021 •

edited

Loading