Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve import of bookmarks and settings during the onboarding process #1530

Closed
rebron opened this issue Oct 11, 2018 · 10 comments
Closed

Improve import of bookmarks and settings during the onboarding process #1530

rebron opened this issue Oct 11, 2018 · 10 comments

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 11, 2018

Description

Add import bookmarks/settings to new welcome flow. Invoke something similar to: brave://settings/importData

but need to keep users in the flow after import and not taken to separate page.

Design

screen shot 2018-10-11 at 9 22 22 am

@rebron rebron added this to the 0.56.x milestone Oct 11, 2018
@rossmoody
Copy link
Contributor

This requires a little nuanced consideration. My initial hope with this screen was to just make it truly one click and we make Brave as much like your previous browser as possible. So whatever we can import from any given competitor we would in one click.

If this is not possible or requires some other much greater consideration I'm unaware of, it would be preferable to surface the import dialog right on top of this panel and when a user imports we auto advance to the next panel. I think regardless, the first option would be what we should push for in the long term. This is a quick mock of that process:

@garrettr I think this might be a thing I would look to your expertise on.
image

@garrettr
Copy link
Contributor

A couple of thoughts:

For users auto-upgrading from browser-laptop to brave-browser, we will auto-import their browser-laptop data (#1545).

For users installing brave-browser from the website, the first run experience should offer the option to import data from another browser (as shown in @rossmoody's screenshots).

If you think the "one click" experience is really important, I think the most sensible UX would be to auto-detect the user's current default browser and offer to import its data as the primary option. Something similar is already partially implemented for Firefox: if Firefox is detected to be the current user's default browser, the list of browser profiles to import from is ordered such that Firefox is the first selected choice, which potentially saves the user a click. We could extend this to detect whether other browsers are the default, and order the list of choices accordingly. This would probably result in a "one-click" experience for a large fraction of users.

I think it's important to keep the dropdown list of choices visible and easy to use to avoid irritating users who have more complicated setups (e.g. one browser with multiple profiles, multiple browsers used concurrently). In this case we really can't guess what the user would want and should leave the choice up to them.

@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 6, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron changed the title add import to welcome flow add import to onboarding process Mar 13, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jun 10, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jun 10, 2019

cc: @clifton thoughts after having gone through #1548?
fyi @cezaraugusto

@bsclifton
Copy link
Member

This should be a fairly easy win, but we'd need to try a proof of concept first 😄When quickly trying it, I didn't see a way to pop up the modal shown above. We could expose the content of the model in our wizard instead (providing a better experience). ex: have a dropdown with:

don't import
import from Chrome
import from HTML file
etc

Will get back to you after trying this out

imptrx pushed a commit to brave/brave-core that referenced this issue Jul 9, 2019
Tracked with brave/brave-browser#1530

Code is rough, but this does work (ex: you can pick an option and import will happen)
@imptrx imptrx added this to the 0.69.x - Nightly milestone Jul 9, 2019
@btlechowski
Copy link

Verification passed on

Brave 0.69.117 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-ui#504

image

@LaurenWags
Copy link
Member

@rebron @bsclifton - just to confirm, when importing from brave://welcome, is the expectation that any item checked by default on brave://settings/importData will be imported when importing from welcome? So if you were to import Chrome from brave://settings/importData cookies, history, etc are checked and imported unless unchecked. So, if you import Chrome from brave://welcome, will you also import cookies, history, etc?

@rebron
Copy link
Collaborator Author

rebron commented Aug 29, 2019

@LaurenWags Yes. Any items that would normally be checked by default (as seen by skipping this step and doing the manual import from settings), should be imported over.

There shouldn't be an "unless checked" by users scenario.

Unchecking items from the manual import bookmarks/settings screen shouldn't affect this screen since this is a one way new user/new profile flow.

@rebron rebron changed the title add import to onboarding process Add import of bookmarks and settings to the onboarding process Sep 4, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 5, 2019

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from ✨New welcome flow for importing settings from other browsers brave-ui#504
  • Verified the import from the welcome screen is successfully importing the bookmarks, history, cookies, and password by default.
  • Verified that the Import button gets enabled only after selecting specific from browser option from the drop-down
  • Verified that the Import button is disabled by default in the welcome screen Import bookmarks and settings slide
  • Verified that only selected items from brave://settings/importData are imported when we initiate the import from the welcome screen.
  • Verified that no items get imported when uncheck all the items in brave://settings/importData
Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

@rebron rebron changed the title Add import of bookmarks and settings to the onboarding process Improve import of bookmarks and settings to the onboarding process Oct 2, 2019
@rebron rebron changed the title Improve import of bookmarks and settings to the onboarding process Improve import of bookmarks and settings during the onboarding process Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests