Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regions for search engine integrations #13511

Closed
15 tasks done
bsclifton opened this issue Jan 12, 2021 · 3 comments · Fixed by brave/brave-core#7622
Closed
15 tasks done

Update regions for search engine integrations #13511

bsclifton opened this issue Jan 12, 2021 · 3 comments · Fixed by brave/brave-core#7622

Comments

@bsclifton
Copy link
Member

bsclifton commented Jan 12, 2021

Description

Follow up to #13283

Test plan

Verify changes in the Default search engines list

  1. Set locale to one of the supported locales (see list above)- for example CA
  2. New profile
  3. Launch Brave, go through onboarding to search engine step. Verify:
    • Ecosia shows in list (should be towards the end)
  4. Open brave://settings/searchEngines in a new tab. Verify:
    • Ecosia shows in list (should be towards the end)

Verify the Ecosia referral IDs used are correct

  1. Do a search (on Android/Desktop) using Ecosia
  2. Verify tt= part of URL fragment matches referral code shown in https://github.com/brave/internal/wiki/Search-engine-integrations
@kjozwiak
Copy link
Member

@brave/legacy_qa because the above was already checked on every region on Win 10 x64 via brave/brave-core#7622 (comment), let's just run through a few regions on each platform rather than running through the entire list on every platform.

Group 1::

  • Italy (IT)
  • Canada (CA)
  • Denmark (DK)
  • Greece (GR)

Group 2::

  • Austria (AT)
  • Norway (NO)
  • Ireland (IE)
  • Spain (ES)
  • Portugal (PT)

Group 3::

  • Finland (FI)
  • Australia (AU)
  • Luxembourg (LU)
  • Hungary (HU)

Please split the three groups between Win 10 x64, Linux & macOS 👍 @srirambv re: Android, we can probably just run through two groups. Once for ARM (Phone) and the other ARM (Tablet).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 27, 2021

Verification passed on


Brave | 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Clean Install

Italy
  • Verified Ecosia was being added via the following area's:
    brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
  • ensured that tt=e8eb07a6 is being appended to search queries from the omnibox/URL bar
    • ensured tt=e8eb07a6 isn't being appended if you're doing a search via https://www.ecosia.org
  • ensured that you can set Ecosia as the default via the following:
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
Region Onboarding Search Settings Search Settings Search
image image image image image
Canada
Region Onboarding Search Settings Search Settings Search
image image image image image
Denmark
Region Onboarding Search Settings Search Settings Search
image image image image image
Greece
Region Onboarding Search Settings Search Settings Search
image image image image image

Upgrade cases

Denmark
  • downloaded 1.19.86 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and Google was the default SE
  • upgraded to 1.19.87 Chromium: 88.0.4324.96
  • ensured that Google is still the default SE
  • ensured that Ecosia is being displayed in the following areas
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.19.86) 1.19.87 brave://settings/search 1.19.87 brave://settings/searchEngines
image image image
----------------------------

Verified passed with

Brave	1.19.87 Chromium: 88.0.4324.96 (Official Build) (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Clean Install Tests

Austria (German)
Region Onboarding Search Settings Search Settings Search
Region - Austria Onboarding - Austria Search Settings - Austria 1 Search Settings - Austria 2 Search - Austria
Norway (Norwegian)
Region Onboarding Search Settings Search Settings Search
Region - Norway Onboarding - Norway Search Settings - Norway 1 Search Settings - Norway 2 Search - Norway
Ireland (English)
Region Onboarding Search Settings Search Settings Search
Region - Ireland Onboarding - Ireland Search Settings - Ireland 1 Search Settings - Ireland 2 Search - Ireland
Spain (Spanish)
Region Onboarding Search Settings Search Settings Search
Region - Spain Onboarding - Spain Search Settings - Spain 1 Search Settings - Spain 2 Search - Spain
Portugal (Portuguese)
Region Onboarding Search Settings Search Settings Search
Region - Portugal Onboarding - Portugal Search Settings - Portugal 1 Search Settings - Portugal 2 Search - Portugal

Upgrade Tests

Norway - Google Default
  • downloaded 1.19.86 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and Google was the default SE
  • upgraded to 1.19.87 Chromium: 88.0.4324.96
  • ensured that Google is still the default SE
  • ensured that Ecosia is being displayed in the following areas
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.19.86) 1.19.87 brave://settings/search 1.19.87 brave://settings/searchEngines
1 19 86 Norway 1 19 87 Norway settings 1 19 87 Norway settings 2
Ireland - DDG Default
  • downloaded 1.19.86 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and DDG was the default SE
  • upgraded to 1.19.87 Chromium: 88.0.4324.96
  • ensured that DDG is still the default SE
  • ensured that Ecosia is being displayed in the following areas
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.19.86) 1.19.87 brave://settings/search 1.19.87 brave://settings/searchEngines
1 19 86 Ireland 1 19 87 Ireland settings 1 1 19 87 Ireland settings 2
Spain - Changing Default
  • downloaded 1.19.86 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and Google was the default SE
  • changed the default SE to Bing using brave://settings/searchEngines
  • upgraded to 1.19.87 Chromium: 88.0.4324.96
  • ensured that Bing is still the default SE
  • ensured that Ecosia is being displayed in the following area's
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Changed (1.19.86) 1.19.87 brave://settings/search 1.19.87 brave://settings/searchEngines
Spain 1 19 86 Spain 1 19 87 settings Spain 1 19 87 settings 2

Verification passed on

Brave 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Clean install

Finland - Finish (fi_FI)

image
image
image
image

Australia - English (en_AU)

image
image
image
image

Luxemburg - Luxemburgish (lb_LU)

Ecosia not found. Added the country to #13571

image

Hungary - Hungarian (hu_HU)

Ecosia not found. Added the country to #13571

image

Upgrade

Australia - English (en_AU)
  • downloaded 1.19.86 and ensured Ecosia wasn't being listed and duckduckgo was the default SE
    image
  • upgraded to 1.19.87
    • ensured that Google is still the default SE
    • ensured that Ecosia is being displayed in the following areas: brave://welcome, brave://settings/search, brave://settings/searchEngines
    • ensured Ecosia uses the following formatting via brave://settings/searchEngines: https://www.ecosia.org/search?tt=e8eb07a6&q=%s

image
image
image
image


Verified PASSED on Win 10 x64 using the following build:

Brave | 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
--- | ---
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2009 (Build 19042.746)

Clean Install Tests

Hungary
Region Onboarding Search Settings Search Settings Search
image image image image image
Luxemburg
Region Onboarding Search Settings Search Settings Search
image image image image image

@srirambv
Copy link
Contributor

srirambv commented Jan 27, 2021

Verification passed on OnePlus 6T with Android 10 running 1.19.87 x64 build

  • Verified Yahoo is removed from the list of SE during onboarding and from list of default SE

  • Verified Ecosia is available as an option in SE onboarding

  • Verified tt=42b8ae98 is appended to query string as part of referral

  • Verified referral code is added on both Standard and Private tabs

  • Verified visiting https://ecosia.org doesn't append any referral code to URL

  • Verified on the following locales

    Italy (IT)
    Onboarding Standard Tab Private Tab
    image image image
    Canada (CA)
    Onboarding Standard Tab Private Tab
    image image image
    Denmark (DK)
    Onboarding Standard Tab Private Tab
    image image image
    Greece (GR)
    Onboarding Standard Tab Private Tab
    image image image
    Austria (AT)
    Onboarding Standard Tab Private Tab
    image image image
    Norway (NO)
    Onboarding Standard Tab Private Tab
    image image image
    Ireland (IE) - Note: Ireland doesn't show SE Onboarding as DDG is set as default and at the top of the SE list
    Default List Standard Tab Private Tab
    image image image

Verification passed on Samsung Tab A with Android 10 running 1.19.87 x64 build

  • Verified Yahoo is removed from the list of SE during onboarding and from list of default SE

  • Verified Ecosia is available as an option in SE onboarding

  • Verified tt=42b8ae98 is appended to query string as part of referral

  • Verified referral code is added on both Standard and Private tabs

  • Verified visiting https://ecosia.org doesn't append any referral code to URL

  • Verified on the following locales

    Spain (ES)
    Onboarding Standard Tab Private Tab
    image image image
    Portugal (PT)
    Onboarding Standard Tab Private Tab
    image image image
    Finland (FI)
    Onboarding Standard Tab Private Tab
    image image image
    Australia (AU) Note: Australia doesn't show SE onboarding since DDG is set as default and shown at the top of the list
    Default SE(DDG) Standard Tab Private Tab
    image image image
    Luxembourg (LU)
    Onboarding Standard Tab Private Tab
    image image image
    Hungary (HU)
    Onboarding Standard Tab Private Tab
    image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment