Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecosia as an alternative search in several regions #7622

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#13511

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#13511

@bsclifton bsclifton self-assigned this Jan 15, 2021
@bsclifton bsclifton requested a review from a team as a code owner January 15, 2021 20:23
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton force-pushed the bsc-ecosia-addl-regions branch from 7fd5003 to e556653 Compare January 19, 2021 08:20
@bsclifton bsclifton force-pushed the bsc-ecosia-addl-regions branch from e556653 to a7bd9d1 Compare January 19, 2021 16:54
@bsclifton
Copy link
Member Author

CI looked good; there was just a lint fix... I pushed this fix and will merge (so CI doesn't run again)

@bsclifton bsclifton merged commit 3295fd9 into master Jan 19, 2021
@bsclifton bsclifton deleted the bsc-ecosia-addl-regions branch January 19, 2021 20:49
@bsclifton bsclifton added this to the 1.21.x - Nightly milestone Jan 19, 2021
brave-builds pushed a commit that referenced this pull request Jan 19, 2021
bsclifton pushed a commit that referenced this pull request Jan 20, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jan 22, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.21 Chromium: 88.0.4324.96 (Official Build) nightly (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2009 (Build 19042.746)

Went through the following with the new regions motioned via brave/brave-browser#13511 (comment):

  • ensured that Yahoo was removed and Ecosia was being added via the following area's:
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
  • ensured that tt=e8eb07a6 is being appended to search queries from the omnibox/URL bar
  • ensured tt=e8eb07a6 isn't being appended if you're doing a search via https://www.ecosia.org
  • ensured that you can set Ecosia as the default via the following:
    • brave://welcome, brave://settings/search & brave://settings/searchEngines

Clean Install

Austria
Region Onboarding Search Settings Search Settings Search
image image image image image
Ireland

Ensured that DDG was the default search engine as per the following:

Region Onboarding Search Settings Search Settings Search
image image image image image
Denmark
Region Onboarding Search Settings Search Settings Search
image image image image image
Luxembourg
Region Onboarding Search Settings Search Settings Search
image image image image image
Norway
Region Onboarding Search Settings Search Settings Search
image image image image image
Australia
Region Onboarding Search Settings Search Settings Search
image image image image image
Spain
Region Onboarding Search Settings Search Settings Search
image image image image image
Greece
Region Onboarding Search Settings Search Settings Search
image image image image image
Italy
Region Onboarding Search Settings Search Settings Search
image image image image image
Hungary
Region Onboarding Search Settings Search Settings Search
image image image image
Portugal
Region Onboarding Search Settings Search Settings Search
image image image image image
Canada
Region Onboarding Search Settings Search Settings Search
image image image image image
Finland
Region Onboarding Search Settings Search Settings Search
image image image image image

Updates

Ireland - DDG Default
  • downloaded 1.21.12 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and DDG was the default SE
  • upgraded to 1.21.21 Chromium: 88.0.4324.96
  • ensured that DDG is still the default SE
  • ensured that Ecosia is being displayed in the following area's
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.21.12) Search Settings Search Settings
image image image
Canada - Google Default
  • downloaded 1.21.12 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and Google was the default SE
  • upgraded to 1.21.21 Chromium: 88.0.4324.96
  • ensured that Google is still the default SE
  • ensured that Ecosia is being displayed in the following area's
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.21.12) Search Settings Search Settings
image image image
Austria - Changing Default
  • downloaded 1.21.12 CR: 88.0.4324.96 and ensured Ecosia wasn't being listed and Google was the default SE
  • changed the default SE to Bing using brave://settings/searchEngines
  • upgraded to 1.21.21 Chromium: 88.0.4324.96
  • ensured that Bing is still the default SE
  • ensured that Ecosia is being displayed in the following area's
    • brave://welcome, brave://settings/search & brave://settings/searchEngines
  • ensured Ecosia uses the following formatting via brave://settings/searchEngines
    • https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Changed (1.21.12) Search Settings Search Settings
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update regions for search engine integrations
5 participants