-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ecosia as an alternative search in several regions #7622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
7fd5003
to
e556653
Compare
e556653
to
a7bd9d1
Compare
CI looked good; there was just a lint fix... I pushed this fix and will merge (so CI doesn't run again) |
Verification PASSED on
Went through the following with the new regions motioned via brave/brave-browser#13511 (comment):
|
Region |
Onboarding |
Search Settings |
Search Settings |
Search |
---|---|---|---|---|
Updates
Ireland - DDG Default
- downloaded
1.21.12 CR: 88.0.4324.96
and ensuredEcosia
wasn't being listed andDDG
was the default SE - upgraded to
1.21.21 Chromium: 88.0.4324.96
- ensured that
DDG
is still the default SE - ensured that
Ecosia
is being displayed in the following area'sbrave://welcome
,brave://settings/search
&brave://settings/searchEngines
- ensured
Ecosia
uses the following formatting viabrave://settings/searchEngines
https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.21.12) |
Search Settings |
Search Settings |
---|---|---|
Canada - Google Default
- downloaded
1.21.12 CR: 88.0.4324.96
and ensuredEcosia
wasn't being listed andGoogle
was the default SE - upgraded to
1.21.21 Chromium: 88.0.4324.96
- ensured that
Google
is still the default SE - ensured that
Ecosia
is being displayed in the following area'sbrave://welcome
,brave://settings/search
&brave://settings/searchEngines
- ensured
Ecosia
uses the following formatting viabrave://settings/searchEngines
https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Default (1.21.12) |
Search Settings |
Search Settings |
---|---|---|
Austria - Changing Default
- downloaded
1.21.12 CR: 88.0.4324.96
and ensuredEcosia
wasn't being listed andGoogle
was the default SE - changed the default SE to
Bing
usingbrave://settings/searchEngines
- upgraded to
1.21.21 Chromium: 88.0.4324.96
- ensured that
Bing
is still the default SE - ensured that
Ecosia
is being displayed in the following area'sbrave://welcome
,brave://settings/search
&brave://settings/searchEngines
- ensured
Ecosia
uses the following formatting viabrave://settings/searchEngines
https://www.ecosia.org/search?tt=e8eb07a6&q=%s
Changed (1.21.12) |
Search Settings |
Search Settings |
---|---|---|
Fixes brave/brave-browser#13511
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
See brave/brave-browser#13511