-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't hide Bookmarks bar on New Tab page #1306
Comments
@rebron, not that I mind but to clarify, is there a particular reason you retitled and labeled it as bug? I'm just wondering because Chrome behaves this way as well on live release (also doesn't have option to change it). |
I really want to see this fixed too, the bookmarks bar looks visually not pleasing and it makes the new tab page look less beautiful than what it really is... |
+1 from @NumpDeP via #1919 for private window |
+1 also on Brave. No problem on chrome 70 |
Do we want to make bookmark in ntp also follow bookmark visibility prefs? @rebron |
+1 from #1306 |
I would love to see this fixed too. It makes the otherwise beautiful page look ugly and is annoying. |
+1 from Community https://community.brave.com/t/hide-bookmarks-bug/43718?u=eljuno |
Just finished migrating from Ubuntu's 'Software' version of Brave to the new src repo, and just noticed that the bookmarks bar is gone on new tabs, meaning I have to have it on all the time (waste of visual space and ugly). Any way to get it showing on just new tabs again? |
I think some users will want to show bookmark bar on NTP when |
@simonhong This is behavior I believe we should support and @petemill wants as well. I'll file a separate issue for it. We'll need to figure out how to display the pref for it. |
@JoshuaCarter we got a new issue tracking that feature request (#4782 - thanks, @rebron!) in case you wanted to subscribe for updates We'll just need to find a place to land this proposed setting as I believe the default behavior we want for users would be to hide on new tab page (users who want to see it would adjust the setting). |
Verification passed on
Verified test plan from brave/brave-core#2563 Checked the Verified passed with
|
Any idea when this is coming to windows? |
@mazupicua Currently, this feature is in dev channel(0.68.x) on Windows also. |
+1 |
Oh. So the bookmarks bar disappeard because it was asked for. And i didn't know where did it gone.... Do i understand correctly if it will be switcheable on new tab? I liked the way it worked. When i opened a new tab, i could load a page from the bookmarks bar (especially from the bookmarks button on the right of the bookmarks bar) , but i don't need that bar on other tabs. But now, i can turn it on only on all tabs. It's nonsense. |
@Curuphan the fix for that is here #4782. There's a setting to always show bookmarks bar and the fact that setting didn't work on the new tab page was the problem. People who don't want to use bookmarks at all don't want to see the bookmarks bar anywhere and we should honor that setting which we did. |
@rebron That's fine, but many of us don't want it on all the time, yet still want easy access to it, which is what a 'new tab only bookmarks bar' gives. Also this is how it's works for me for years on Chrome anyway so I took it for granted that this was the intention. It needs to be 3 options: [on, off, new-tab]. This might be a non-issue if I could find a half-decent new-tab-bookmarks-bar extension, but I can't (I last checked around the time of my last comment on this issue). |
@JoshuaCarter See here please: brave/brave-core#2869 |
@rebron @simonhong Outstanding, many thanks. |
Are there plans to bring 3 options as mentioned by Joshua? I preferred to only see the bookmarks bar on a new tab and agree that giving the option to pick which one you want is better than omitting an option. |
So this is why my NTP bookmark bar has disappeared. This sucks, I use that thing constantly. |
This was a silly issue to raise. Now we can't access our bookmark bar in a new tab anymore without being forced to see the bar for every... single... tab. Someone please hit undo. |
@adamreisnz Sorry for your inconvenience. |
Description
Even with the "Show Bookmarks Bar" option set to off, Brave still displays bookmarks bar on the new tab screen. There should be an option to turn this off. Tangentially related to #1022
Note: Chrome behaves in this same way (at the time of writing this, Chrome v69.0.3497.100) so this is more of a feature request than a bug. Would be good to have an option for this before Chrome.
Steps to Reproduce
Actual result:
Bookmarks Bar is not shown when viewing website tab as expected but new tab page still shows bookmarks bar.
Expected result:
Bookmarks bar should not be visible anywhere until option is turned back on.
Reproduces how often:
Always.
Brave version (chrome://version info)
Version 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Website problems only:
Additional Information
Screenshots:
The text was updated successfully, but these errors were encountered: