Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank whitespace under NTP image while page is loading #2568

Open
srirambv opened this issue Dec 14, 2018 · 3 comments
Open

Blank whitespace under NTP image while page is loading #2568

srirambv opened this issue Dec 14, 2018 · 3 comments
Labels
bug feature/new-tab priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@srirambv
Copy link
Contributor

Description

Blank whitespace under NTP image while page is loading. Originally reported at https://community.brave.com/t/when-navigation-from-dashboard-bookmarks-bar-is-hidind-and-white-stripe-is-showed/39753

Steps to Reproduce

  1. Open a new tab
  2. Type in a site and wait for the page to load
  3. Once bookmarks bar is hidden the image jumps creating a blank space at the bottom

Actual result:

image

Expected result:

Should not create a blank whitespace

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Might be fixed with #1306

@srirambv srirambv added this to the 1.x Backlog milestone Dec 14, 2018
@rebron
Copy link
Collaborator

rebron commented Feb 6, 2019

Looks like this is still an issue with new tab page in 60.x still, only really apparent if page is slow to load.

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 6, 2019
@rossmoody
Copy link
Contributor

rossmoody commented Feb 6, 2019

I have a small amount of insight @petemill pointed out to add to this for posterity. This is actually behavior Chrome exhibits too currently, it's not specific to Brave.

jump

It relates to a user's setting for bookmark bar behavior. If you show it all the time, you won't see the jump. If you hide it, the frame change from NTP to web page will exhibit that jump as it loses the bookmark bar (because you can't hide bookmark bar on NTP). A way to mitigate noticing the stark white background is to give the body a dark grey background color. A more cohesive solve would be to investigate assigning the background image to the body. @karenkliu

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron
Copy link
Collaborator

rebron commented Nov 21, 2019

@srirambv Is this still an issue?

@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/new-tab priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 backlog
Development

No branches or pull requests

3 participants