Improved error handling

brave-intl · Jan 17, 2019 · 953939d · 953939d
1 parent b180a1c
commit 953939d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/ads_serve.cc b/src/ads_serve.cc
@@ -129,8 +129,7 @@ bool AdsServe::ProcessCatalog(const std::string& json) {
 
   LOG(INFO) << "Parsing catalog";
 
-  auto result = catalog.FromJson(json);
-  if (result != SUCCESS) {
+  if (!catalog.FromJson(json)) {
     LOG(ERROR) << "Failed to parse catalog";
 
     return false;

diff --git a/src/bundle.cc b/src/bundle.cc
@@ -122,6 +122,7 @@ std::unique_ptr<BundleState> Bundle::GenerateFromCatalog(
       }
 
       if (heirarchy.empty()) {
+        LOG(ERROR) << "creativeSet segments are empty";
         return nullptr;
       }
 
@@ -160,6 +161,7 @@ std::unique_ptr<BundleState> Bundle::GenerateFromCatalog(
       }
 
       if (entries == 0) {
+        LOG(ERROR) << "creativeSet creatives are empty";
         return nullptr;
       }
     }

diff --git a/src/client.cc b/src/client.cc
@@ -267,8 +267,7 @@ void Client::OnStateLoaded(const Result result, const std::string& json) {
 
     client_state_.reset(new ClientState());
   } else {
-    auto result = FromJson(json);
-    if (result != SUCCESS) {
+    if (!FromJson(json)) {
       return;
     }