Improved error handling

brave-intl · Jan 17, 2019 · b180a1c · b180a1c
1 parent 9cef400
commit b180a1c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/ads_impl.cc b/src/ads_impl.cc
@@ -1019,8 +1019,6 @@ bool AdsImpl::IsSustainingAdInteraction() const {
 }
 
 bool AdsImpl::IsStillViewingAd() const {
-  std::string error_description;
-
   UrlComponents last_shown_notification_info_url_components;
   if (!ads_client_->GetUrlComponents(last_shown_notification_info_.url,
       &last_shown_notification_info_url_components)) {

diff --git a/src/bat/ads/issuers_info.cc b/src/bat/ads/issuers_info.cc
@@ -40,7 +40,7 @@ Result IssuersInfo::FromJson(
 
   // Public key
   if (!document.HasMember("public_key")) {
-    if (error_description != nullptr) {
+    if (error_description) {
       *error_description = "Catalog issuers public key is missing";
     }
 
@@ -51,7 +51,7 @@ Result IssuersInfo::FromJson(
 
   // Issuers
   if (!document.HasMember("issuers")) {
-    if (error_description != nullptr) {
+    if (error_description) {
       *error_description = "No catalog issuers";
     }