Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUR-242, SUR-323 - Setup Tests for UI components #159

Merged
merged 86 commits into from
Nov 18, 2024
Merged

SUR-242, SUR-323 - Setup Tests for UI components #159

merged 86 commits into from
Nov 18, 2024

Conversation

jaieds
Copy link
Contributor

@jaieds jaieds commented Oct 18, 2024

Description

  • Setup test environment.

  • Added test for Button and Select Component.

  • How to Run test:

    • Run npm install for the first time only.
    • Run npm run storybook
    • In the command/terminal run npm run test (bulk test). It will begin the test and will show the result.
    • To run test in watch mode run npm run test:watch.

👉 All about React component testing with Storybook

CI Setup instructions: Storybook Doc

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@vrundakansara
Copy link
Contributor

@jaieds - Please write a short document about it too.

  • What are tests?
  • Why are they important?
  • How to write tests?
  • What points should one keep in mind while writing tests?

You can add the readme in this PR or write a wiki for the same.

@vrundakansara vrundakansara removed the request for review from HimanshuSangale October 18, 2024 09:38
@jaieds
Copy link
Contributor Author

jaieds commented Oct 18, 2024

@vrundakansara, I've created a wiki page 👉 All about React component testing with Storybook

@jaieds
Copy link
Contributor Author

jaieds commented Oct 18, 2024

@vrundakansara, I've added CI for the Test.

Copy link
Contributor

@vrundakansara vrundakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaieds - Shall we fix the a11y issues as well?
Or shall we do it in another PR?

@jaieds
Copy link
Contributor Author

jaieds commented Oct 22, 2024

@jaieds - Shall we fix the a11y issues as well? Or shall we do it in another PR?

@vrundakansara, We can fix it in another PR.

@vrundakansara vrundakansara changed the base branch from staging to dev October 24, 2024 08:18
jaieds and others added 28 commits November 14, 2024 09:26
 from the select component
for the entire storybook
SUR-323 - Accessibility fixes for Force UI components.
fix: Use `use client` after importing components from @bsf/force-ui in Nextjs
@vrundakansara vrundakansara merged commit d7f396c into dev Nov 18, 2024
2 checks passed
@vrundakansara vrundakansara deleted the SUR-242 branch November 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants