Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUR-323 - Accessibility fixes for Force UI components. #189

Merged
merged 53 commits into from
Nov 18, 2024
Merged

SUR-323 - Accessibility fixes for Force UI components. #189

merged 53 commits into from
Nov 18, 2024

Conversation

jaieds
Copy link
Contributor

@jaieds jaieds commented Nov 14, 2024 •
edited
Loading

Description

  • Resolved Accessibility issues.
  • Resolved the issue where the Tooltip and the Dropdown weren’t showing.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

JelenaTakac and others added 30 commits November 5, 2024 13:44
@JelenaTakac
Initialized accessibility fixes branch
4256261
@JelenaTakac
Fixed accessibility violation for Alert component
da3aaa3
@JelenaTakac
Fixed accessibility violation for Breadcrumb component
f169840
@JelenaTakac
Fixed accessibility violation for Progress Bar component
9340ab9
@JelenaTakac
Fixed accessibility violation for Pagination component
65bf5f9
@JelenaTakac
Fixed accessibility violation for Datapicker component
a69b0dd
@JelenaTakac
Merge branch 'SUR-242' into SUR-323/accessibility-fixes
1b2df14
@JelenaTakac
Added accessibility fixes for Alert, Breadcrumb, Progress Bar and Dat…
1d134b7 
…apicker components
@JelenaTakac
Fixed 'Buttons must have discernible text' issue for Area, Bar and Pi…
60f642e 
…e Chart components
@jaieds
fix: Dropdown not visible
4ef3477
@jaieds
Spread other props to the Avatar
04323d1
@jaieds
fix: DropdownMenu component accessibility issues
29d7209
@JelenaTakac
Resolved a11y violation "Elements must meet minimum color contrast ra…
acc1091 
…tio thresholds" for components
@jaieds
fix: Menu component accessibility issue
fd4b4c3
@jaieds
Disabled color contrast accessibility violation
167ee35
@jaieds
fix: Area & Bar chart accessibility issues
bbfaee1
@jaieds
fix: The Tooltip is not visible
d20ad4d
@jaieds
Update the test runner config
0141848
@jaieds
fix: Cards story accessibility issue
472601e
@jaieds
fix: Drawer component accessibility issue
48d8a19
@jaieds
fix: Pie chart accessibility issues
6779851
@jaieds
disabled accessibility check for the templates
9e55288
@jaieds
Merge branch 'SUR-323/accessibility-fixes' into SUR-323-Fixes
212b4a8
@jaieds
Update Area, bar and pie chart component
3a2651d
@jaieds
disabled editor input component accessibility issue
657d806
@jaieds
fix: Pagination component accessibility issues
6286479
@JelenaTakac
Fixed Input component a11y violations
5ba78e6
@JelenaTakac
Fixed Radio Button component a11y violation
3452dcd
@JelenaTakac
Fixed Switch component a11y violation
1076079
@JelenaTakac
Fixed TextArea component a11y violation
8cab8e9
JelenaTakac
JelenaTakac approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@JelenaTakac JelenaTakac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

vrundakansara
vrundakansara requested changes Nov 14, 2024
View reviewed changes
src/components/breadcrumb/breadcrumb.tsx Outdated Show resolved Hide resolved
.storybook/preview.tsx Outdated Show resolved Hide resolved
@jaieds
Copy link
Contributor Author

jaieds commented Nov 14, 2024 •
edited
Loading

@vrundakansara, Resolved templates accessibility issues.

vrundakansara
vrundakansara requested changes Nov 14, 2024
View reviewed changes
.storybook/preview.tsx Outdated Show resolved Hide resolved
.storybook/test-runner.js Outdated Show resolved Hide resolved
@jaieds
Disable color contrast ratio check
baee63c 
for the entire storybook
@vrundakansara vrundakansara merged commit 825070a into SUR-242 Nov 18, 2024
2 checks passed
@vrundakansara vrundakansara deleted the SUR-323-Fixes branch November 18, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelenaTakac JelenaTakac JelenaTakac approved these changes

@vrundakansara vrundakansara vrundakansara approved these changes

@ravindra114 ravindra114 Awaiting requested review from ravindra114

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaieds @vrundakansara @JelenaTakac