Find conda-installed binaries on Windows #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
niftyreg
backend binariesAddresses a difference between Windows and Mac/Linux OSes when attempting to locate CONDA-installed
niftyreg
binaries.Addresses #116, but does not close it.
Changes
If the user has installed
niftyreg
into a conda environment, then installedbrainreg
into the same environment, we should detect the conda-installedniftyref
binaries and use these in the backend rather than the binaries that we bundle with the package.Previously, Windows users experienced an error due to the conda install path of the niftyreg binaries being different to that on Linux/MacOS. Full changes are:
.exe
is now explicitly appended to all executables/binaries when on Windows OSCONDA_PREFIX/Library/bin
vsCONDA_PREFIX/bin
on Mac/Linux)