Remove niftyreg binaries from package

[dstansby]

In the future we should remove the niftyreg binaries from the packages, and give users clear instructures on how to install niftyreg from conda-forge.

[adamltyson]

Or even better, just move to conda install -c conda-forge brainreg as the default installation option.

[lacan]

Perhaps linked to this, but on a windows installation using Mamba, the niftyreg binaries are installed in
CONDA_PREFIX\Library\bin

Whereas in your conda_install_path method in niftyreg_binaries.py references them as being in
CONDA_PREFIX\bin

brainreg/src/brainreg/backend/niftyreg/niftyreg_binaries.py

Line 17 in fd6475f

def conda_install_path() -> Optional[Path]:

Moreover, your test if (bin_path / "reg_aladin").exists() returns False for me, as the only way to get it to return True is to add .exe

if (bin_path / "reg_aladin.exe").exists():

So I guess you'd need to separate between Windows and Mac/Linux?

Perhaps this is not the way, but it's the only way I managed to get Brainreg to work

[adamltyson]

@willGraham01 is this something you could take a look at?

[willGraham01]

Will take a look this afternoon & next week. Would like to merge #132 in first before making any changes though.

[willGraham01]

Hi @lacan - taking a look at this, this morning. Just a couple of questions if that's OK:

Moreover, your test if (bin_path / "reg_aladin").exists() returns False for me, as the only way to get it to return True is to add .exe
if (bin_path / "reg_aladin.exe").exists():

Did you need to edit the bin_path variable (defined on the line above the one you reference) to CONDA_PREFIX\Library in addition to adding .exe, or did just adding .exe to reg_aladin work?

Can I also ask whether you had to add ".exe" to the program names in parameter.py to get the registration to work (the lines are here)?