Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/241 greek latin #252

Merged
merged 29 commits into from
Sep 26, 2020
Merged

Feature/241 greek latin #252

merged 29 commits into from
Sep 26, 2020

Conversation

zuevval
Copy link
Member

@zuevval zuevval commented Sep 3, 2020

Closes #241

Closes #239

Closes #204

Closes #224

Depends on #253

@winter-yuki
Copy link
Member

I've already solved #250 by #253.

@zuevval zuevval linked an issue Sep 5, 2020 that may be closed by this pull request
3 tasks
@zuevval zuevval added this to the 1.2.0 milestone Sep 5, 2020
@zuevval zuevval added interface Design and navigation lessons Lessons section improvement practice Practice section improvement enhancement New feature or request labels Sep 5, 2020
@winter-yuki
Copy link
Member

What this PR is waiting for?

@zuevval
Copy link
Member Author

zuevval commented Sep 19, 2020

What this PR is waiting for?

I am going to finish changing the course (today/tomorrow), merge it with the branch associated with this PR, and then request your review

@winter-yuki
Copy link
Member

winter-yuki commented Sep 25, 2020

@zuevval I'd like to write migrations after before merging dev to master. There also were information changes as I could remember.
#263

@winter-yuki
Copy link
Member

winter-yuki commented Sep 25, 2020

There is no horizontal padding for text view in ShowDotsFragment and in CardFragment for marker symbols. Would you like to add it, @zuevval ? #264

@winter-yuki
Copy link
Member

I'd like to change rename: "Все символы, кроме иностранных". Langs enumeration looks strange.

@winter-yuki
Copy link
Member

I've written tests for resources print rules and removed other case from them, all symbols are covered.

@winter-yuki
Copy link
Member

I'm done here

@zuevval
Copy link
Member Author

zuevval commented Sep 25, 2020

@zuevval I'd like to write migrations after before merging dev to master. There also were information changes as I could remember.
#263

OK, as you wish

@zuevval zuevval marked this pull request as draft September 25, 2020 19:17
@winter-yuki winter-yuki mentioned this pull request Sep 25, 2020
@zuevval zuevval force-pushed the feature/241-greek-latin branch 3 times, most recently from 06f20ee to 2403ede Compare September 26, 2020 14:41
@zuevval zuevval marked this pull request as ready for review September 26, 2020 15:37
@zuevval
Copy link
Member Author

zuevval commented Sep 26, 2020

I have checked everything. I suppose we may merge this, @winter-yuki please, do it if you agree.

@zuevval
Copy link
Member Author

zuevval commented Sep 26, 2020

There is no horizontal padding for text view in ShowDotsFragment and in CardFragment for marker symbols. Would you like to add it, @zuevval ? #264

There is some padding visually. It's not of great importance to my mind... thank you for the issue, maybe later I will do it, but after 1.2.0 I suppose (if you do not mind)

@zuevval
Copy link
Member Author

zuevval commented Sep 26, 2020

I'd like to change rename: "Все символы, кроме иностранных". Langs enumeration looks strange.

"maybe 'All symbols except for foreign letters' "? 'Foreign symbols' sounds a little weird, too. This may be confusing since there are Arabic numerals, are they foreign or not?

@winter-yuki
Copy link
Member

There is no horizontal padding for text view in ShowDotsFragment and in CardFragment for marker symbols. Would you like to add it, @zuevval ? #264

There is some padding visually. It's not of great importance to my mind... thank you for the issue, maybe later I will do it, but after 1.2.0 I suppose (if you do not mind)

I've just encountered this issue on my screen size on one step. Ok.

@winter-yuki
Copy link
Member

I'd like to change rename: "Все символы, кроме иностранных". Langs enumeration looks strange.

"maybe 'All symbols except for foreign letters' "? 'Foreign symbols' sounds a little weird, too. This may be confusing since there are Arabic numerals, are they foreign or not?

Yes, foreign letters are better

@zuevval
Copy link
Member Author

zuevval commented Sep 26, 2020

I'd like to change rename: "Все символы, кроме иностранных". Langs enumeration looks strange.

"maybe 'All symbols except for foreign letters' "? 'Foreign symbols' sounds a little weird, too. This may be confusing since there are Arabic numerals, are they foreign or not?

Yes, foreign letters are better

Done

@winter-yuki winter-yuki merged commit bce1c93 into dev Sep 26, 2020
@winter-yuki winter-yuki deleted the feature/241-greek-latin branch September 26, 2020 16:18
@zuevval zuevval mentioned this pull request Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interface Design and navigation lessons Lessons section improvement practice Practice section improvement
Projects
None yet
2 participants