-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/241 greek latin #252
Conversation
What this PR is waiting for? |
I am going to finish changing the course (today/tomorrow), merge it with the branch associated with this PR, and then request your review |
I'd like to change rename: "Все символы, кроме иностранных". Langs enumeration looks strange. |
I've written tests for resources print rules and removed |
I'm done here |
app/src/main/java/com/github/braillesystems/learnbraille/ui/views/BrailleDotsView.kt
Outdated
Show resolved
Hide resolved
06f20ee
to
2403ede
Compare
I have checked everything. I suppose we may merge this, @winter-yuki please, do it if you agree. |
There is some padding visually. It's not of great importance to my mind... thank you for the issue, maybe later I will do it, but after 1.2.0 I suppose (if you do not mind) |
"maybe 'All symbols except for foreign letters' "? 'Foreign symbols' sounds a little weird, too. This may be confusing since there are Arabic numerals, are they foreign or not? |
I've just encountered this issue on my screen size on one step. Ok. |
Yes, |
Done |
Closes #241
Closes #239
Closes #204
Closes #224
Depends on #253