fix: port implicit keyboard binding over to decision editors

[jarekdanielak]

Closes #920

Proposed Changes

Adjust Keyboard modules in dmn-js-decision-table and dmn-js-literal-expression to follow new implicit keyboard binding behavior.

Change the test for keyboard binding to subscript onto events instead of directly checking internal property.

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[nikku]

I don't see that the viewer-container or any other element is actively keyboard focusable. What is our strategy here?

What I see is that when the bpmn-io overlay is focused the undo/redo still triggers; that is somewhat unexpected, too:

Could you elaborate how this currently is supposed to work?

[jarekdanielak]

The goal of this pull request was to simply make sure the configuration in dmn-js is aligned with the new configuration in diagram-js, so that there is no need to explicitly specify bindTo parameter for any keyboard abstraction that we provide.

It doesn't change or fix any of the flaws we have now. The undo behavior you are showing can be reproduced with current version too. I think this one actually follows native browser behavior - you don't have to have an input focused in order to undo in it. See blow:

Screen.Recording.2024-11-14.at.18.05.31.mov

---

I agree some of undo/redo behaviors are unexpected. I've recently investigated it as a part of this Undo/redo in BKM issue.

In effort to wrap up integration of diagram-js@15 in our stack, I decided to only remove deprecated configuration this time and leave improvements for later.

[nikku]

I propose we link bpmn-io/diagram-js#662 as a breaking change resource.