Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/redo works unexpectedly in BKM #4613

Open
barmac opened this issue Oct 16, 2024 · 4 comments
Open

Undo/redo works unexpectedly in BKM #4613

barmac opened this issue Oct 16, 2024 · 4 comments
Assignees
Labels
backlog Queued in backlog bug Something isn't working DMN needs discussion Needs further discussion ux

Comments

@barmac
Copy link
Collaborator

barmac commented Oct 16, 2024

Describe the bug

When I am modeling a BKM, and trigger undo while typing the BKM name, it triggers undo outside of the name box.

Screen.Recording.2024-10-16.at.14.52.47.mov

Steps to reproduce

  1. Write in body or change formal parameters
  2. Write in the name box and hit undo
  3. now this happens

Expected behavior

Undo/redo stack should be isolated to the currently selected input. Changes outside should be undone only after input loses focus.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: all since BKM was introduced
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@barmac barmac added bug Something isn't working DMN labels Oct 16, 2024
@barmac
Copy link
Collaborator Author

barmac commented Oct 16, 2024

One could argue that we should commit all of the changes in the input to the command stack, but I'd rather leverage the browser input stack handling, so that we can undo the entire change if desired.

@nikku nikku added the ux label Oct 16, 2024
@nikku
Copy link
Member

nikku commented Oct 16, 2024

Let's discuss this, and consider what will be our future scheme. Relates to #3902, but also relevant to properties panel UX.

@nikku
Copy link
Member

nikku commented Oct 16, 2024

CC @lmbateman

@jarekdanielak jarekdanielak added the ready Ready to be worked on label Oct 22, 2024
@jarekdanielak
Copy link
Contributor

The root cause of this issue is lack of consistency in undo/redo behavior across Desktop Modeler. When I started testing different combinations of typing and undoing/redoing between text inputs, FEEL editors and canvas, it's clear there is no one strategy that we follow.

It requires more discussion (cc. @lmbateman). I will put it in the backlog as I don't have the capacity to work on it in the near future.

@jarekdanielak jarekdanielak added needs discussion Needs further discussion backlog Queued in backlog and removed ready Ready to be worked on labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working DMN needs discussion Needs further discussion ux
Projects
None yet
Development

No branches or pull requests

3 participants