fix: boundary event labels #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
requested changes
Sep 3, 2024
| @@ -2,7 +2,7 @@ | |||
| <bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" id="Definitions_027stl5" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="1.16.2"> | |||
| <bpmn:process id="Process_1" isExecutable="true"> | |||
| <bpmn:subProcess id="SubProcess_0w2vmlo" /> | |||
| <bpmn:boundaryEvent id="BoundaryEvent_1wvvk9q" attachedToRef="SubProcess_0w2vmlo" /> | |||
| <bpmn:boundaryEvent id="BoundaryEvent_1wvvk9q" name="Q" attachedToRef="SubProcess_0w2vmlo" /> | |||
There was a problem hiding this comment.
We can simply remove the boundary event since the only valid case is a boundary event with name.
bpmn-io-tasks
bot
added
in progress
abdul99ahad
force-pushed
the
141-boundary-event-label
branch
from
a0b8254 to
8721217
Compare
bpmn-io-tasks
bot
added
needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Proposed Changes
Boundary events now requires label
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}