Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label-required rule does not trigger for boundary events #141

Closed
nikku opened this issue Aug 19, 2024 · 0 comments · Fixed by #143
Closed

label-required rule does not trigger for boundary events #141

nikku opened this issue Aug 19, 2024 · 0 comments · Fixed by #143
Assignees
@abdul99ahad
Labels
bug Something isn't working good first issue Good for newcomers rules Concerning existing or missing rules

Comments

@nikku
Copy link
Member

nikku commented Aug 19, 2024

Describe the Bug

Boundary events are to date ignored by the label-required rule, for unknown reasons (ref)

image

Steps to Reproduce

  • Model boundary event
  • Do not provide label
  • See that label-required rule does not trigger

Expected Behavior

For boundary events the same rules apply as for any label (ref).

Environment

  • Host (Browser/Node version), if applicable: any
  • OS: Linux (Ubuntu)
  • Library version: v10.3.0
@nikku nikku added bug Something isn't working rules Concerning existing or missing rules good first issue Good for newcomers ready Ready to be worked on labels Aug 19, 2024
@abdul99ahad abdul99ahad added in progress Currently worked on and removed ready Ready to be worked on labels Aug 30, 2024
abdul99ahad added a commit that referenced this issue Aug 30, 2024
@abdul99ahad
fix: boundary event labels
a0b8254 
Closes #141
@abdul99ahad abdul99ahad mentioned this issue Aug 30, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Aug 30, 2024
abdul99ahad added a commit that referenced this issue Sep 3, 2024
@abdul99ahad
fix: boundary event labels
8721217 
Closes #141
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 3, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working good first issue Good for newcomers rules Concerning existing or missing rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: boundary event labels bpmn-io/bpmnlint
2 participants
@nikku @abdul99ahad