This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Refactors facts about Java version #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| java_version = Facter.value(:java_version) | ||
| java_patch_level = java_version.strip.split('_')[0].split('.')[1] unless java_version.nil? | ||
| end | ||
| end |
|
Hmm, I'm wondering if/why we need this for Java 8 support when we can just do version comparisons on the existing fact? |
Got some advice from some Puppetlabs people on how to do facts better! :)
Catches edge-case where which java is resolved, but Java is not actually installed!
|
@MikeMcQuaid We don't need it, as you can perform regex's on the current fact, it just makes it a little easier to have Facter/Ruby code to perform that string manipulation 😄 |
petems
force-pushed
the
refactor_java_version_facts
branch
2 times, most recently
from
90d9918
to
bf21c28
Compare
These facts have since been refactored, ported these changes from https://github.com/puppetlabs/puppetlabs-java/
petems
force-pushed
the
refactor_java_version_facts
branch
from
bf21c28
to
04d28d5
Compare
|
@petems Could I see some sample code that you'd like to use this? Thanks! |
|
Been a while, gonna close this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These facts have since been refactored, ported these changes from https://github.com/puppetlabs/puppetlabs-java/