Upgrade to Java 8 #33

jehrhardt · 2014-04-08T19:48:00Z

Install the latest Java 8 instead of Java 7.

Since the first release of Java 8 has no update version, I have removed the update_version parameter. This will break existing code, that sets the parameter manually. Once, Oracle will release the first update to Java 8, the parameter could be introduced again.

I would recommend to release this as version 2.0.0, due to the broken backwards compatibility and the new Java version.

Someone must upload Java 8 JDK and JRE to https://s3.amazonaws.com/boxen-downloads/java to make this really work.

The first release of Java 8 has no update version. This breaks the existing pattern for update versions. Since the update_version parameter has been removed, this commit will break existing usage, when the parameter is explicitly set by the user.

Java 8 requires a new version of JCE.

skottler · 2014-04-09T02:53:03Z

@jehrhardt I think releasing this as 2.0 is fine, but we'll need have 1.x live on for a while as well. Can you take a look at the puppet-lint issues that caused travis-ci to fail?

After removing the parameter `update_version`, the usage of double quotes is no longer necessary.

jbcpollak · 2014-04-10T04:20:18Z

You could support multiple version of Java at the same time by renaming init.pp to version.pp, the way the boxen-nodejs and boxen-ruby work. The advantage of this would be that Boxen could be easily configured to install multiple versions of Java.

Something like this:

First rename init.pp to version.pp and make it a define instead of a class:

define java::version (
    $jdk_version, # Note no default value set
    $jdk_dirname,
) {
...
...
$jdk_url = "${base_download_url}/jdk-${jdk_version}-macosx-x64.dmg"
$jdk_dir = "/Library/Java/JavaVirtualMachines/${jdk_dirname}"

Then you can do what the boxen-nodejs package does and create files like this:

v7u51.pp:

class java::v7u51 {
    java::version { 'v7u51' :
        jdk_version = '7u51',
        jdk_dirname = 'jdk1.7.0_51.jdk',
    }
}

v8.pp:

class java::v8 {
    java::version { 'v8':
        jdk_version = '8',
        jdk_dirname = 'jdk1.8.0.jdk',
    }
}

Using this method, I'm not sure if an init.pp is still required or if any other changes would be required to the new version.pp file.

jehrhardt · 2014-04-10T05:15:59Z

@jbcpollak I will add something like this to the pull request, when it is really necessary. The problems with with different versions do not exist for Java in the same way as for Ruby or node.js. I think a simple versioning of the Boxen module will fit well enough.

jbcpollak · 2014-04-11T00:53:58Z

@jehrhardt - fair enough, but my reason for suggesting this change was to facilitate easily installing any version boxen users want, from the latest version of this project, without having to be limited to the single version supported by the version of the project. Supporting multiple installs just happens to be a side effect.

However, I do think there are legitimate usecases for having multiple versions of Java installed simultaneously. The most obvious one to me is what we do at my company, when we are upgrading between versions (it helps isolate problems). I know more enterprise level companies compile and release against multiple versions.

Most IDEs let you choose your JDK on a project-by-project basis as well, and I'm pretty sure people take advantage of that.

If I submitted a PR with this implemented, would you consider merging it? I don't think it adds significant complexity to the code.

jehrhardt · 2014-04-11T07:59:53Z

I would like to get this pull request merged as is. So installation of Java 8 works.

The idea of supporting different versions of Java sounds interesting, but seems to fit better in a separate pull request.

jbcpollak · 2014-04-14T19:22:57Z

I made an experimental multi-version branch here: https://github.com/jbcpollak/puppet-java/tree/multiVersion

It seems to work fine, although Java 8 is hard to test because its missing from S3. I haven't updated the unit tests yet.

I ran into a problem with the Java 7 installer though when Java 8 is already installed, and I haven't been able to solve that: #34 Its not a problem with the code itself, but it is unfortunately a blocker to supporting multiple Java versions with Boxen. (Or even installing Java 7 with Boxen if a user has already installed Java 8).

mikeycmccarthy · 2014-05-01T16:15:06Z

Hey @jbcpollak, I'm in the same boat in terms of needing multiple Java versions on the same machine. Do you have your boxen fork somewhere public so I can have a look at how you've done it? Happy to be a guinea pig for the testing. Cheers!

jbcpollak · 2014-05-01T16:33:33Z

@mikeycmccarthy - you can see my branch here: https://github.com/jbcpollak/puppet-java/tree/multiVersion There is a problem though: If you already have Java 8 installed Java 7's installer will complain. It only complains when run from Boxen though, it doesn't complain when run from the commandline. I haven't figure out why.

mikeycmccarthy · 2014-05-01T16:43:01Z

My bad - I was actually looking to see your boxen files to see how you specify that you want two versions of Java on your workstation. Do you have a Puppetfile you can share?

jbcpollak · 2014-05-01T16:56:30Z

Ah sorry, here are some instructions for trying it out:

Check out the branch above to ~/src/boxen/puppet-java. As far as I know, this path is not configurable, but I couldn't find a lot of documentation on it.
Modify your boxen Puppetfile like this:

#github "java",       "1.4.0"
dev "java"

modify manifests/site.pp, or whatever pp file you want to include Java like this:

#include java
include java::v7u51

You can't test installing JDK 8 yet because it hasn't been uploaded to the S3 account (as far as I know). You would use include java::v8u05 if it was available.

What I would really like to see is an installer like the Ubuntu one that downloads the package directly from Oracle.

mikeycmccarthy · 2014-05-02T07:26:16Z

OK, just gave that a go:

Error: Syntax error at '='; expected '}' at /opt/boxen/repo/shared/java/manifests/v7u51.pp:3 on node gl04632m.local

when I run Boxen. I commit my boxen and point you in the direction of it if it would help.

utestmig · 2014-05-14T13:17:10Z

Will this be released in the near future?

n0ts · 2014-08-27T12:21:51Z

Please merge it!
👍

bbck · 2014-09-02T19:05:34Z

👍

runlevel5 · 2014-10-01T12:29:03Z

👍

chrisbraddock · 2014-10-19T22:34:03Z

👍

nickpellant · 2014-11-04T16:22:52Z

👍

ocxo · 2014-11-04T17:29:45Z

@dgoodlad will you be pushing java 8 binaries up or should we close this?

lunks · 2014-11-28T15:41:38Z

👍

ghost · 2014-12-28T22:31:01Z

👍

When will this module be available in the master branch?

ghost · 2014-12-29T18:30:46Z

No body in this room?

skottler · 2014-12-29T20:45:11Z

@julienlavergne there isn't 24/7 support for boxen.

Please rebase this PR and then it can get merged.

Conflicts: README.md manifests/init.pp

The update version was not considered in the test. After the indroduction of Java 8 the minimal update version for Mac OS X 10.10 has also ben changed.

jehrhardt · 2014-12-29T21:18:29Z

It can get merged.

jarib · 2015-01-30T14:42:52Z

👍

rick · 2015-02-17T22:57:38Z

Subscribing to this newsletter.

skottler · 2015-02-17T22:58:19Z

This should be good to go. Are you cool with that @dgoodlad?

ghost · 2015-02-17T23:00:06Z

What are your concerns for this module and Java 8 last release (31)?

On February 17, 2015 at 11:57:42 PM, Rick Bradley ([email protected]) wrote:

Subscribing to this newsletter.

—
Reply to this email directly or view it on GitHub.

rick · 2015-02-17T23:12:32Z

I'm interested in knowing when this module lands to master so I can use it.
Otherwise, I'll import to a fork and redirect my Puppetfile to my fork.

On Tue, Feb 17, 2015 at 3:00 PM, Julien Lavergne [email protected]
wrote:

What are your concerns for this module and Java 8 last release (31)?

On February 17, 2015 at 11:57:42 PM, Rick Bradley (
[email protected]) wrote:

Subscribing to this newsletter.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#33 (comment).

ghost · 2015-02-17T23:16:47Z

You can also submit your contribution after that to the master via a pull request

Le 18 févr. 2015 à 00:12, Rick Bradley [email protected] a écrit :

I'm interested in knowing when this module lands to master so I can use it.
Otherwise, I'll import to a fork and redirect my Puppetfile to my fork.

On Tue, Feb 17, 2015 at 3:00 PM, Julien Lavergne [email protected]
wrote:

What are your concerns for this module and Java 8 last release (31)?

On February 17, 2015 at 11:57:42 PM, Rick Bradley (
[email protected]) wrote:

Subscribing to this newsletter.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#33 (comment).

—
Reply to this email directly or view it on GitHub.

dgoodlad · 2015-02-18T00:24:07Z

I have no more objection to this; the reason I'd held off for quite awhile was worry about compatibility with ElasticSearch etc. I've spoken to a few people, all seems well, and folks who want to stay on Java 7 can simply continue using the older module version.

I reckon we merge and ship this as a new major version (2.0), and continue to maintain a 1.x branch for Java 7 compatibility if necessary.

ghost · 2015-02-23T19:33:29Z

When will this release 2.0 come? ;)

petems · 2015-03-09T15:56:28Z

@dgoodlad Once #55 is merged, it wouldn't be hard to basically implement this fully backwards compatible.

So by default the module installs Java 7, but you can specify 8 if required! 👍

kdorseyfmcna · 2015-07-15T20:14:58Z

There are numerous use cases in the enterprise that require multiple installs of the JDK on developer machines. Whether supported by a single boxen puppet module or multiple tagged releases for JDK 7 and JDK 8 is not an issue. We will be hosting our DMG downloads internally. Hope something is released for JDK 8 soon. I am having to roll my own in the mean time.

jehrhardt added 3 commits April 8, 2014 16:13

Update to Java 8

4624c27

The first release of Java 8 has no update version. This breaks the existing pattern for update versions. Since the update_version parameter has been removed, this commit will break existing usage, when the parameter is explicitly set by the user.

Upgrade JCE JARs

9be4aca

Java 8 requires a new version of JCE.

Update README for removed parameter

391641b

Fix puppet-lint error

753a144

After removing the parameter `update_version`, the usage of double quotes is no longer necessary.

jan.ehrhardt added 3 commits December 29, 2014 22:03

Merge branch 'master' of github.com:boxen/puppet-java into java-8

953262b

Conflicts: README.md manifests/init.pp

Fix tests

4d5f6e5

The update version was not considered in the test. After the indroduction of Java 8 the minimal update version for Mac OS X 10.10 has also ben changed.

Fix quotes

dde29e6

petems mentioned this pull request Jan 8, 2015

Take upstream java fixes and put them here #52

Closed

petems mentioned this pull request Mar 10, 2015

Java 8 Support #57

Open

lharding mentioned this pull request May 8, 2015

Update Java version cloudfour/cloudfour-boxen#39

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Java 8 #33

Upgrade to Java 8 #33

jehrhardt commented Apr 8, 2014

skottler commented Apr 9, 2014

jbcpollak commented Apr 10, 2014

jehrhardt commented Apr 10, 2014

jbcpollak commented Apr 11, 2014

jehrhardt commented Apr 11, 2014

jbcpollak commented Apr 14, 2014

mikeycmccarthy commented May 1, 2014

jbcpollak commented May 1, 2014

mikeycmccarthy commented May 1, 2014

jbcpollak commented May 1, 2014

mikeycmccarthy commented May 2, 2014

utestmig commented May 14, 2014

n0ts commented Aug 27, 2014

bbck commented Sep 2, 2014

runlevel5 commented Oct 1, 2014

chrisbraddock commented Oct 19, 2014

nickpellant commented Nov 4, 2014

ocxo commented Nov 4, 2014

lunks commented Nov 28, 2014

ghost commented Dec 28, 2014

ghost commented Dec 29, 2014

skottler commented Dec 29, 2014

jehrhardt commented Dec 29, 2014

jarib commented Jan 30, 2015

rick commented Feb 17, 2015

skottler commented Feb 17, 2015

ghost commented Feb 17, 2015

rick commented Feb 17, 2015

ghost commented Feb 17, 2015

dgoodlad commented Feb 18, 2015

ghost commented Feb 23, 2015

petems commented Mar 9, 2015

kdorseyfmcna commented Jul 15, 2015

Upgrade to Java 8 #33

Are you sure you want to change the base?

Upgrade to Java 8 #33

Conversation

jehrhardt commented Apr 8, 2014

skottler commented Apr 9, 2014

jbcpollak commented Apr 10, 2014

jehrhardt commented Apr 10, 2014

jbcpollak commented Apr 11, 2014

jehrhardt commented Apr 11, 2014

jbcpollak commented Apr 14, 2014

mikeycmccarthy commented May 1, 2014

jbcpollak commented May 1, 2014

mikeycmccarthy commented May 1, 2014

jbcpollak commented May 1, 2014

mikeycmccarthy commented May 2, 2014

utestmig commented May 14, 2014

n0ts commented Aug 27, 2014

bbck commented Sep 2, 2014

runlevel5 commented Oct 1, 2014

chrisbraddock commented Oct 19, 2014

nickpellant commented Nov 4, 2014

ocxo commented Nov 4, 2014

lunks commented Nov 28, 2014

ghost commented Dec 28, 2014

ghost commented Dec 29, 2014

skottler commented Dec 29, 2014

jehrhardt commented Dec 29, 2014

jarib commented Jan 30, 2015

rick commented Feb 17, 2015

skottler commented Feb 17, 2015

ghost commented Feb 17, 2015

rick commented Feb 17, 2015

ghost commented Feb 17, 2015

dgoodlad commented Feb 18, 2015

ghost commented Feb 23, 2015

petems commented Mar 9, 2015

kdorseyfmcna commented Jul 15, 2015