Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(printing): Fix print button on ContentPreview #1992

Merged
merged 8 commits into from
Mar 3, 2020
Merged

fix(printing): Fix print button on ContentPreview #1992

merged 8 commits into from
Mar 3, 2020

Conversation

mickr
Copy link
Contributor

@mickr mickr commented Feb 28, 2020

  • Print button should not show for non-printable file-types

@mickr mickr requested a review from a team as a code owner February 28, 2020 23:47
@mickr
fix(printing): Fix print button on ContentPreview
097a6da 
* Print button should not show for non-printable file-types
@mickr
Copy link
Contributor Author

mickr commented Feb 28, 2020

Dependent upon box/box-content-preview#1177

@mickr
Copy link
Contributor Author

mickr commented Feb 29, 2020

Document:
Screen Shot 2020-02-28 at 4 01 39 PM

Video:
Screen Shot 2020-02-28 at 4 03 29 PM

@box box deleted a comment Feb 29, 2020
ConradJChan
ConradJChan previously approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be fix(preview)?

ConradJChan
ConradJChan previously approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave a comment in handleCanPrint that explains more about how you want to avoid a flash of print icon by default only to have it removed when running the canPrint check, to help people like me understand better 😄

@mickr mickr requested a review from a team as a code owner March 3, 2020 01:22
@mergify mergify bot merged commit 04fccd3 into box:master Mar 3, 2020
@mickr mickr deleted the add-support-for-dynamic-print-button branch March 12, 2020 00:57
@greg-in-a-box greg-in-a-box mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiao6 mxiao6 mxiao6 left review comments

@jstoffan jstoffan jstoffan approved these changes

@ConradJChan ConradJChan ConradJChan left review comments

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickr @jstoffan @mxiao6 @ConradJChan