fix(printing): Adding compat for older preview versions

box · Feb 29, 2020 · 543f555 · 543f555
1 parent 172833f
commit 543f555
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/elements/content-preview/ContentPreview.js b/src/elements/content-preview/ContentPreview.js
@@ -690,12 +690,24 @@ class ContentPreview extends React.PureComponent<Props, State> {
         return !!showAnnotations && (this.canAnnotate() || hasViewAllPermissions || hasViewSelfPermissions);
     }
 
+    /**
+     * Returns whether a preview viewer supports printing
+     *
+     * @return {boolean}
+     */
     handleCanPrint() {
+        /*
+        Setting this as default so older preview versions can still print documents without having the
+        default state have the print icon.
+         */
+        let canPrint = true;
         const preview = this.getPreview();
 
         if (preview && typeof preview.canPrint === 'function') {
-            this.setState({ canPrint: preview.canPrint() });
+            canPrint = preview.canPrint();
         }
+
+        return this.setState({ canPrint });
     }
 
     /**

diff --git a/src/elements/content-preview/__tests__/ContentPreview.test.js b/src/elements/content-preview/__tests__/ContentPreview.test.js
@@ -192,6 +192,16 @@ describe('elements/content-preview/ContentPreview', () => {
             expect(canPrintMock).toBeCalled();
             expect(wrapper.state('canPrint')).toEqual(expected);
         });
+
+        it('should show print icon if printCheck is not available', () => {
+            const wrapper = getWrapper();
+            const instance = wrapper.instance();
+
+            wrapper.setState({ file });
+            instance.handleCanPrint();
+
+            expect(wrapper.state('canPrint')).toEqual(true);
+        });
     });
 
     describe('loadPreview()', () => {