Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix fullscreen nav and hide toggle thumbnail button #926

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Chore: Fix fullscreen nav and hide toggle thumbnail button #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fbcab6
Chore: Fix fullscreen nav and hide toggle thumbnail button
Feb 13, 2019
3cba8cc
Chore: add tabindex back to .bp
Feb 13, 2019
ec2ca0f
Chore: apply min-width to fullscreen el
Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/_common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ $header-height: 48px;
align-items: center;
display: flex;
flex: 1 1 auto;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to set the flex-basis to 100%, instead or as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but Safari doesn't seem to care about that value either

min-width: 100%;
position: relative;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/shell.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<button class="bp-btn-plain bp-btn-loading-download bp-is-invisible"></button>
</div>
</div>
<div class="bp-content" data-testid="bp-content">
<div class="bp-content" tabindex="0" data-testid="bp-content">
<button class="bp-btn-plain bp-navigate bp-navigate-left bp-is-hidden">
<svg viewBox="0 0 48 48" focusable="false">
<path fill="#494949" stroke="#DCDCDC" stroke-miterlimit="10" d="M30.8,33.2L21.7,24l9.2-9.2L28,12L16,24l12,12L30.8,33.2z"/>
Expand Down
5 changes: 5 additions & 0 deletions src/lib/viewers/doc/_docBase.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,8 @@ $thumbnail-border-radius: 4px;
display: block;
}
}

// Hide the toggle thumbnails button when in fullscreen
.bp-content.bp-is-fullscreen .bp-toggle-thumbnails-icon {
display: none;
}